From: Cornelia Huck <cohuck@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Eric Farman <farman@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/3] vfio/pci: Split linux/vfio_pci_core.h
Date: Mon, 29 Aug 2022 13:47:49 +0200 [thread overview]
Message-ID: <877d2rfeze.fsf@redhat.com> (raw)
In-Reply-To: <1-v2-1bd95d72f298+e0e-vfio_pci_priv_jgg@nvidia.com>
On Fri, Aug 26 2022, Jason Gunthorpe <jgg@nvidia.com> wrote:
> The header in include/linux should have only the exported interface for
> other vfio_pci module's to use. Internal definitions for vfio_pci.ko
s/module's/modules/
> should be in a "priv" header along side the .c files.
>
> Move the internal declarations out of vfio_pci_core.h. They either move to
> vfio_pci_priv.h or to the C file that is the only user.
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/pci/vfio_pci.c | 2 +-
> drivers/vfio/pci/vfio_pci_config.c | 2 +-
> drivers/vfio/pci/vfio_pci_core.c | 19 +++-
> drivers/vfio/pci/vfio_pci_igd.c | 2 +-
> drivers/vfio/pci/vfio_pci_intrs.c | 16 +++-
> drivers/vfio/pci/vfio_pci_priv.h | 106 +++++++++++++++++++++++
> drivers/vfio/pci/vfio_pci_rdwr.c | 2 +-
> drivers/vfio/pci/vfio_pci_zdev.c | 2 +-
> include/linux/vfio_pci_core.h | 134 +----------------------------
> 9 files changed, 145 insertions(+), 140 deletions(-)
> create mode 100644 drivers/vfio/pci/vfio_pci_priv.h
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2022-08-29 12:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 19:34 [PATCH v2 0/3] Remove private items from linux/vfio_pci_core.h Jason Gunthorpe
2022-08-26 19:34 ` [PATCH v2 1/3] vfio/pci: Split linux/vfio_pci_core.h Jason Gunthorpe
2022-08-29 11:47 ` Cornelia Huck [this message]
2022-08-26 19:34 ` [PATCH v2 2/3] vfio/pci: Rename vfio_pci_register_dev_region() Jason Gunthorpe
2022-08-29 0:45 ` Tian, Kevin
2022-08-29 11:49 ` Cornelia Huck
2022-08-26 19:34 ` [PATCH v2 3/3] vfio/pci: Simplify the is_intx/msi/msix/etc defines Jason Gunthorpe
2022-08-29 11:51 ` Cornelia Huck
2022-09-02 18:42 ` [PATCH v2 0/3] Remove private items from linux/vfio_pci_core.h Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d2rfeze.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.