From: Jani Nikula <jani.nikula@intel.com>
To: John Harrison <john.c.harrison@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3 01/14] drm/i915/guc: remove runtime info printing from time stamp logging
Date: Wed, 24 Aug 2022 13:12:42 +0300 [thread overview]
Message-ID: <877d2yj6g5.fsf@intel.com> (raw)
In-Reply-To: <cf627642-c570-8d7e-071b-195e84242c4d@intel.com>
On Tue, 23 Aug 2022, John Harrison <john.c.harrison@intel.com> wrote:
> On 8/19/2022 05:02, Jani Nikula wrote:
>> Commit 368d179adbac ("drm/i915/guc: Add GuC <-> kernel time stamp
>> translation information") added intel_device_info_print_runtime() in the
>> time info dump for no obvious reason or explanation in the commit
>> message. It only logs the rawclk freq. Remove it.
>>
>> Cc: John Harrison <John.C.Harrison@Intel.com>
>> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Thanks, this one pushed to drm-intel-gt-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>> index 01f2705cb94a..24451d000a6a 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>> @@ -365,8 +365,6 @@ void intel_guc_dump_time_info(struct intel_guc *guc, struct drm_printer *p)
>> u32 stamp = 0;
>> u64 ktime;
>>
>> - intel_device_info_print_runtime(RUNTIME_INFO(gt->i915), p);
>> -
>> with_intel_runtime_pm(>->i915->runtime_pm, wakeref)
>> stamp = intel_uncore_read(gt->uncore, GUCPMTIMESTAMP);
>> ktime = ktime_get_boottime_ns();
>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-08-24 10:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 12:02 [Intel-gfx] [PATCH v3 00/14] drm/i915: stop modifying "const" device info Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 01/14] drm/i915/guc: remove runtime info printing from time stamp logging Jani Nikula
2022-08-23 23:57 ` John Harrison
2022-08-24 10:12 ` Jani Nikula [this message]
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 02/14] drm/i915: combine device info printing into one Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 03/14] drm/i915: add initial runtime info into device info Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 04/14] drm/i915: move graphics.ver and graphics.rel to runtime info Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 05/14] drm/i915: move fbc_mask " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 06/14] drm/i915: move page_sizes " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 07/14] drm/i915: move ppgtt_type and ppgtt_size " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 08/14] drm/i915: move has_pooled_eu " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 09/14] drm/i915: move memory_regions " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 10/14] drm/i915: move platform_engine_mask " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 11/14] drm/i915: move pipe_mask and cpu_transcoder_mask " Jani Nikula
2022-08-19 12:02 ` Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 12/14] drm/i915: move has_hdcp " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 13/14] drm/i915: move has_dmc " Jani Nikula
2022-08-19 12:02 ` [Intel-gfx] [PATCH v3 14/14] drm/i915: move has_dsc " Jani Nikula
2022-08-23 11:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: stop modifying "const" device info (rev3) Patchwork
2022-08-23 11:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-23 11:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-24 3:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-08-24 10:13 ` [Intel-gfx] [PATCH v3 00/14] drm/i915: stop modifying "const" device info Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d2yj6g5.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.