From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F686C433EF for ; Thu, 5 May 2022 15:28:11 +0000 (UTC) Received: from localhost ([::1]:46216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmdOk-0003EU-3U for qemu-devel@archiver.kernel.org; Thu, 05 May 2022 11:28:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdK0-0000X4-QQ for qemu-devel@nongnu.org; Thu, 05 May 2022 11:23:16 -0400 Received: from us-smtp-delivery-74.mimecast.com ([170.10.133.74]:40814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdJy-0000RG-1D for qemu-devel@nongnu.org; Thu, 05 May 2022 11:23:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651764192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tdBilN6bjygL55nnbKnUDRD+M/5Tuw7ToGRtCINIi5c=; b=V/rkZi9ZMPd2itUaF4va6GRwdAU8Y9ya8WVcN+P65gbcbtUQaM1plnG7qg+duAzP/31I9G JAQvHsn+6RvN9M55JnqV/WmLfQLvQZDzfhbxTpUasCsg8iwJnPf85Np2tDsoCrBAG+VVjA G/PnqtWtOzZ2pmjo1kuN1iVZjXJcdN4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-456-6m6H7H7SPa6Jrs4EcuIKHw-1; Thu, 05 May 2022 11:23:09 -0400 X-MC-Unique: 6m6H7H7SPa6Jrs4EcuIKHw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 970BD3C1022E; Thu, 5 May 2022 15:23:08 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FB337B64; Thu, 5 May 2022 15:22:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E0FCE21E6880; Thu, 5 May 2022 17:22:35 +0200 (CEST) From: Markus Armbruster To: Stefan Hajnoczi Cc: Jagannathan Raman , qemu-devel@nongnu.org, mst@redhat.com, f4bug@amsat.org, pbonzini@redhat.com, marcandre.lureau@redhat.com, thuth@redhat.com, bleal@redhat.com, berrange@redhat.com, eduardo@habkost.net, marcel.apfelbaum@gmail.com, eblake@redhat.com, quintela@redhat.com, dgilbert@redhat.com, imammedo@redhat.com, peterx@redhat.com, john.levon@nutanix.com, thanos.makatos@nutanix.com, elena.ufimtseva@oracle.com, john.g.johnson@oracle.com, kanth.ghatraju@oracle.com Subject: Re: [PATCH v9 07/17] vfio-user: define vfio-user-server object References: <48d0f7214036d48b1f70b90a8c4a6c2a46363ee9.1651586203.git.jag.raman@oracle.com> <871qx97c8s.fsf@pond.sub.org> Date: Thu, 05 May 2022 17:22:35 +0200 In-Reply-To: (Stefan Hajnoczi's message of "Thu, 5 May 2022 16:14:07 +0100") Message-ID: <877d70qa10.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.74; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-74.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Stefan Hajnoczi writes: > On Wed, May 04, 2022 at 01:45:07PM +0200, Markus Armbruster wrote: >> Jagannathan Raman writes: >> >> > Define vfio-user object which is remote process server for QEMU. Setup >> > object initialization functions and properties necessary to instantiate >> > the object >> > >> > Signed-off-by: Elena Ufimtseva >> > Signed-off-by: John G Johnson >> > Signed-off-by: Jagannathan Raman >> > --- >> > qapi/qom.json | 20 +++- >> > include/hw/remote/machine.h | 2 + >> > hw/remote/machine.c | 27 +++++ >> > hw/remote/vfio-user-obj.c | 210 ++++++++++++++++++++++++++++++++++++ >> > MAINTAINERS | 1 + >> > hw/remote/meson.build | 1 + >> > hw/remote/trace-events | 3 + >> > 7 files changed, 262 insertions(+), 2 deletions(-) >> > create mode 100644 hw/remote/vfio-user-obj.c >> > >> > diff --git a/qapi/qom.json b/qapi/qom.json >> > index eeb5395ff3..582def0522 100644 >> > --- a/qapi/qom.json >> > +++ b/qapi/qom.json >> > @@ -703,6 +703,20 @@ >> > { 'struct': 'RemoteObjectProperties', >> > 'data': { 'fd': 'str', 'devid': 'str' } } >> > >> > +## >> > +# @VfioUserServerProperties: >> > +# >> > +# Properties for x-vfio-user-server objects. >> > +# >> > +# @socket: socket to be used by the libvfio-user library >> > +# >> > +# @device: the id of the device to be emulated at the server >> >> Suggest "the ID", because "id" is not a word. > > id (noun) > 1. In Freudian theory, the division of the psyche that is totally unconscious and serves as the source of instinctual impulses and demands for immediate satisfaction of primitive needs. > 2. In Weismann's doctrine of germ-plasm, the substance of inheritance or the bearer , in the germ-plasm, of the hereditary qualities of a single complete organism. > 3. In the somatic idioplasm of the hereditary qualities of a group of cells or a part of a developing embryo or growing organism. > https://duckduckgo.com/?q=define+id&ia=definition > > :D :D :D I stand corrected! %-)