From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Chung-Chiang Cheng <cccheng@synology.com>
Cc: linux-fsdevel@vger.kernel.org, kernel@cccheng.net, shepjeng@gmail.com
Subject: Re: [PATCH v4 1/3] fat: split fat_truncate_time() into separate functions
Date: Thu, 28 Apr 2022 02:47:50 +0900 [thread overview]
Message-ID: <877d7axvsp.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20220423032348.1475539-1-cccheng@synology.com> (Chung-Chiang Cheng's message of "Sat, 23 Apr 2022 11:23:46 +0800")
Chung-Chiang Cheng <cccheng@synology.com> writes:
> +/*
> + * truncate atime to 24 hour granularity (00:00:00 in local timezone)
> + */
> +void fat_truncate_atime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> + struct timespec64 *atime)
[...]
> +void fat_truncate_crtime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> + struct timespec64 *crtime)
[...]
> +void fat_truncate_mtime(struct msdos_sb_info *sbi, struct timespec64 *ts,
> + struct timespec64 *mtime)
Small stuff and not strong opinion though, those are better to return
timespec64, instead of taking pointer? Because we can
mtime = ctime = fat_truncate_mtime(sbi, &ts);
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2022-04-27 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 3:23 [PATCH v4 1/3] fat: split fat_truncate_time() into separate functions Chung-Chiang Cheng
2022-04-23 3:23 ` [PATCH v4 2/3] fat: ignore ctime updates, and keep ctime identical to mtime in memory Chung-Chiang Cheng
2022-04-23 3:23 ` [PATCH v4 3/3] fat: report creation time in statx Chung-Chiang Cheng
2022-04-27 17:45 ` OGAWA Hirofumi
2022-04-30 4:15 ` Chung-Chiang Cheng
2022-04-27 17:47 ` OGAWA Hirofumi [this message]
2022-04-30 4:12 ` [PATCH v4 1/3] fat: split fat_truncate_time() into separate functions Chung-Chiang Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d7axvsp.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=cccheng@synology.com \
--cc=kernel@cccheng.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shepjeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.