From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h
Date: Wed, 02 Feb 2022 13:25:49 +0200 [thread overview]
Message-ID: <877dadtsqq.fsf@intel.com> (raw)
In-Reply-To: <Yfpbceq3zV3qIm3n@intel.com>
On Wed, 02 Feb 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> I dropped the ball here a bit. If I respin the same patches, but with
>> the above line changed to one of these, is it okay? Which do you prefer?
>>
>> 1) outb(VGA_SEQ_CLOCK_MODE, VGA_SEQ_I); /* SR01 */
>>
>> 2) #define SR01 VGA_SEQ_CLOCK_MODE
>> outb(SR01, VGA_SEQ_I);
>>
>> 3) outb(0x01, VGA_SEQ_I);
>
> 3 seems like the best option of these.
Thanks, v2 on the list.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-02-02 11:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 9:57 [Intel-gfx] [PATCH 1/4] drm/i915: split out PCI config space registers from i915_reg.h Jani Nikula
2022-01-10 9:57 ` [Intel-gfx] [PATCH 2/4] drm/i915: split out vlv sideband " Jani Nikula
2022-01-10 14:32 ` Jani Nikula
2022-01-10 9:57 ` [Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h Jani Nikula
2022-01-10 16:03 ` Ville Syrjälä
2022-01-11 8:55 ` Jani Nikula
2022-01-11 16:14 ` Lucas De Marchi
2022-01-11 16:19 ` Jani Nikula
2022-01-11 16:37 ` Lucas De Marchi
2022-01-12 13:24 ` Ville Syrjälä
2022-02-02 9:17 ` Jani Nikula
2022-02-02 10:22 ` Ville Syrjälä
2022-02-02 11:25 ` Jani Nikula [this message]
2022-01-10 9:57 ` [Intel-gfx] [PATCH 4/4] drm/i915: remove VGA register definitions Jani Nikula
2022-01-10 10:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h Patchwork
2022-01-10 10:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-10 11:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-10 13:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dadtsqq.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.