Re: [PATCH] powerpc/pseries: delete scanlog

[Michael Ellerman <mpe@ellerman.id.au>]

Nathan Lynch <nathanl@linux.ibm.com> writes:
> Nathan Lynch <nathanl@linux.ibm.com> writes:
>> Remove the pseries scanlog driver.
>>
>> This code supports functions from Power4-era servers that are not present
>> on targets currently supported by arch/powerpc. System manuals from this
>> time have this description:
>>
>>   Scan Dump data is a set of chip data that the service processor gathers
>>   after a system malfunction. It consists of chip scan rings, chip trace
>>   arrays, and Scan COM (SCOM) registers. This data is stored in the
>>   scan-log partition of the system’s Nonvolatile Random Access
>>   Memory (NVRAM).
>>
>> PowerVM partition firmware development doesn't recognize the associated
>> function call or property, and they don't see any references to them in
>> their codebase. It seems to have been specific to non-virtualized
>> pseries.
>
> Just bumping this to see if there are any objections.

Not an objection, I like nothing better than dropping old unused cruft,
but are we sure it's safe to remove the proc file?

I see that rtas_errd still looks for it, have you checked that it will
handle the absence of the file gracefully and continue doing whatever
else it does?

On further inspection it looks like the code that looks for it in
rtas_errd is #if 0'ed out (??), so maybe it's dead.

Anyway if you can test that rtas_errd still works that'd be good.

Presumably there's no other code that cares about the proc file.

cheers