From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Andrew Jones" <drjones@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3 3/3] dump-guest-memory: Block live migration
Date: Mon, 01 Nov 2021 13:28:51 +0100 [thread overview]
Message-ID: <877ddsqcu4.fsf@secure.mitica> (raw)
In-Reply-To: <20210922162009.125622-4-peterx@redhat.com> (Peter Xu's message of "Wed, 22 Sep 2021 12:20:09 -0400")
Peter Xu <peterx@redhat.com> wrote:
> Both dump-guest-memory and live migration caches vm state at the beginning.
> Either of them entering the other one will cause race on the vm state, and even
> more severe on that (please refer to the crash report in the bug link).
>
> Let's block live migration in dump-guest-memory, and that'll also block
> dump-guest-memory if it detected that we're during a live migration.
>
> Side note: migrate_del_blocker() can be called even if the blocker is not
> inserted yet, so it's safe to unconditionally delete that blocker in
> dump_cleanup (g_slist_remove allows no-entry-found case).
>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1996609
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2021-11-01 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 16:20 [PATCH v3 0/3] dump-guest-memory: Add blocker for migration Peter Xu
2021-09-22 16:20 ` [PATCH v3 1/3] migration: Make migration blocker work for snapshots too Peter Xu
2021-11-01 12:27 ` Juan Quintela
2021-09-22 16:20 ` [PATCH v3 2/3] migration: Add migrate_add_blocker_internal() Peter Xu
2021-09-22 16:20 ` [PATCH v3 3/3] dump-guest-memory: Block live migration Peter Xu
2021-09-22 16:28 ` Marc-André Lureau
2021-11-01 12:28 ` Juan Quintela [this message]
2021-10-15 1:34 ` [PATCH v3 0/3] dump-guest-memory: Add blocker for migration Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ddsqcu4.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.