All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/ffmpeg: add -latomic to pkg-config files
Date: Sat, 04 Sep 2021 22:01:26 +0200	[thread overview]
Message-ID: <877dfwp0tl.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210807194031.1501659-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sat, 7 Aug 2021 21:40:31 +0200")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > -latomic was added to extralibs to fix static build of ffmpeg in commit
 > fc8798197b57488a852e2c14b4677b5eb0114a0b. However, extralibs is not
 > added to libavformat.pc resulting in the following static build failure
 > of motion:

 > /home/buildroot/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/9.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
 > /home/buildroot/autobuild/instance-1/output-1/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libavformat.a(fifo.o):
 > in function `fifo_init':
 > /home/buildroot/autobuild/instance-1/output-1/build/ffmpeg-4.4/libavformat/fifo.c:519:
 > undefined reference to `__atomic_store_8'

 > So add a patch to add extralibs (and so -latomic) to all pkg-config
 > files

 > Fixes:
 >  - http://autobuild.buildroot.org/results/62ec618e40081a250b8129ec6f5a178eb06fba1d

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2 (after review of Yann E. Morin):
 >  - Add extralibs to all pkg-config files and not only libavformat.pc

 >  ...igure-add-extralibs-to-extralibs_xxx.patch | 47 +++++++++++++++++++
 >  1 file changed, 47 insertions(+)
 >  create mode 100644 package/ffmpeg/0004-configure-add-extralibs-to-extralibs_xxx.patch

Committed to 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2021-09-04 20:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-07 19:40 [Buildroot] [PATCH v2, 1/1] package/ffmpeg: add -latomic to pkg-config files Fabrice Fontaine
2021-08-08 21:22 ` Thomas Petazzoni
2021-08-08 21:30   ` Fabrice Fontaine
2021-08-09  7:31     ` Thomas Petazzoni
2021-09-04 20:01 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dfwp0tl.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=mahyar.koshkouei@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.