From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD7BC4338F for ; Tue, 24 Aug 2021 14:52:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2560E61214 for ; Tue, 24 Aug 2021 14:52:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2560E61214 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIXnC-0000lW-Um for qemu-devel@archiver.kernel.org; Tue, 24 Aug 2021 10:52:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIXRK-0002mY-3z for qemu-devel@nongnu.org; Tue, 24 Aug 2021 10:30:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIXRI-0000lC-HK for qemu-devel@nongnu.org; Tue, 24 Aug 2021 10:30:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629815408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p/aZb5zj/inYlyLVHfucZevwoiQvZx6Ze0FbqpUKOBg=; b=Re+2iif1U5/Y0GvGxIOiHXxdE8vEiHTWNGh4HQLK+ex8qw+lVW6j+2gSXXoEQSn2tUqnCV zfdQU5ErL8VV9nyWSQ/Zfa1ynFo6b+q+jrMp1forTe+6Jiiovn9jZtvTvJf7zt5b7LVFyj zM/LOh/Svk5P2GSUNF00PHrTsvP3aWM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-SnalWyMqMrSI5mhDEBMmNQ-1; Tue, 24 Aug 2021 10:30:04 -0400 X-MC-Unique: SnalWyMqMrSI5mhDEBMmNQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 86CE318C8C15; Tue, 24 Aug 2021 14:30:03 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-4.ams2.redhat.com [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FAF15D6CF; Tue, 24 Aug 2021 14:29:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DC46711380A9; Tue, 24 Aug 2021 16:29:46 +0200 (CEST) From: Markus Armbruster To: Eduardo Habkost Subject: Re: [PATCH v2 2/3] hw/usb/hcd-xhci-pci: Abort if setting link property failed References: <20210819171547.2879725-1-philmd@redhat.com> <20210819171547.2879725-3-philmd@redhat.com> <20210823183414.hmu4ly2y5zkbw3mg@habkost.net> <87ilzvntu1.fsf@dusky.pond.sub.org> <87tujfdp4c.fsf@dusky.pond.sub.org> <20210824135742.auvxsilpjtlruwyc@habkost.net> Date: Tue, 24 Aug 2021 16:29:46 +0200 In-Reply-To: <20210824135742.auvxsilpjtlruwyc@habkost.net> (Eduardo Habkost's message of "Tue, 24 Aug 2021 09:57:42 -0400") Message-ID: <877dgadig5.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.747, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sergio Lopez , "Michael S. Tsirkin" , Richard Henderson , QEMU Developers , Gerd Hoffmann , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-?= =?utf-8?Q?Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eduardo Habkost writes: > On Tue, Aug 24, 2021 at 01:16:40PM +0100, Peter Maydell wrote: >> On Tue, 24 Aug 2021 at 13:05, Markus Armbruster wrote: >> > When you know that all callers handle errors like &error_fatal does, use >> > of &error_fatal doesn't produce wrong behavior. It's still kind of >> > wrong, because relying on such a non-local argument without a genuine >> > need is. >> >> Not using error_fatal results in quite a bit of extra boilerplate >> for all those extra explicit "check for failure, print the error >> message and exit" points. > > I don't get it. There's no need for extra boilerplate if the > caller is using &error_fatal. > >> If the MachineState init function took >> an Error** that might be a mild encouragement to "pass an Error >> upward rather than exiting"; but it doesn't. > > Agreed. > >> >> Right now we have nearly a thousand instances of error_fatal >> in the codebase, incidentally. > > It looks like 73 of them are in functions that take an Error** > argument. > > Coccinelle patch for finding them: > > @@ > typedef Error; > type T; > identifier errp, fn; > @@ > T fn(..., Error **errp) > { > ... > *&error_fatal > ... > } > > > Coccinelle output: [...] These do look suspicious to me.