From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mDQS7-0001I7-DA for mharc-qemu-riscv@gnu.org; Tue, 10 Aug 2021 08:01:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQS5-0001EB-KS for qemu-riscv@nongnu.org; Tue, 10 Aug 2021 08:01:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQS1-0004qj-Vv for qemu-riscv@nongnu.org; Tue, 10 Aug 2021 08:01:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628596904; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8yJTX7eNzzbNaJggB4MTVcWm01xc/Rs3c9Spl2Cmkgo=; b=FPa7X9IV/PQ9vwUG/+HHosiGO6Uz5j9T9EheWB+kZqkxgvhfKNipd/NrNY7U5RYvKiYSWm Oi5gZglqB5qPZxeZnN2l2jHY8Ev/5zbNjbhT7iDPYcHZ3gfUAVhI2itpb7j+Y06zU8BTJG Rq0qKQdNTX6Xah804hOsB9HYrmR/r1A= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-xoZWZ7swMfyFIiZZqVOYMA-1; Tue, 10 Aug 2021 08:01:43 -0400 X-MC-Unique: xoZWZ7swMfyFIiZZqVOYMA-1 Received: by mail-wm1-f70.google.com with SMTP id f25-20020a1c6a190000b029024fa863f6b0so978655wmc.1 for ; Tue, 10 Aug 2021 05:01:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version; bh=8yJTX7eNzzbNaJggB4MTVcWm01xc/Rs3c9Spl2Cmkgo=; b=jwZYm0DlCo9m+siNxmLlsyeGrM6SgAr4Uy2NlXz/k0Q6m8lrUC4PZrFNcHzajObRcU fBAutCJ+1EWUsK1S0YrO1XL5pO4eNLCoqSN0UPgEvlUxF8sj871mTq2PsySzgRS+ZmgO iTckT4LiIY8e/j0HUR7iYhd9c+lwCuxOtcxz34rJ3mn4w4iTGtJ3HPA99Osh7SbUVYgp 4kfmQkhZvTWPcOODlSUAD09bqCK36JgBH6nQE1cU4bbR91qT9phopAFHDzYsGEuRxtt2 vmBSqxldVP7tmpBKN4T3dBXzTJm0NtqauG0S63F4HZFz5Zxxb2FFRd4rwfuDzyAGyh/x yQ7w== X-Gm-Message-State: AOAM531oVYRRsttACQpUl3H02AmAspl1RMMMToZIJgBxpnTOwIIWhCg3 FpUUvZIdGlD+tGeZ8E1g1eHf/BVa1ZkB/7RLwGpQhLMLUXZNnZNCwirQ4T4PKRnZs9MbiWEhgXi nydzWTUE9laW+hM4= X-Received: by 2002:a5d:658a:: with SMTP id q10mr30910134wru.343.1628596902474; Tue, 10 Aug 2021 05:01:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3hzXJq/uMeMUgLEKYXP7YdeYgeEjV4RTqS2QrZnBsjiQwGsXJUTgme4xDTdtVLt8j8LEVnA== X-Received: by 2002:a5d:658a:: with SMTP id q10mr30910057wru.343.1628596902136; Tue, 10 Aug 2021 05:01:42 -0700 (PDT) Received: from localhost (62.83.194.64.dyn.user.ono.com. [62.83.194.64]) by smtp.gmail.com with ESMTPSA id j4sm20637348wmi.4.2021.08.10.05.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 05:01:41 -0700 (PDT) From: Juan Quintela To: Eduardo Habkost Cc: qemu-devel@nongnu.org, "Daniel P. Berrange" , Paolo Bonzini , Richard Henderson , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Peter Maydell , Andrew Baumann , Philippe =?utf-8?Q?Mathi?= =?utf-8?Q?eu-Daud=C3=A9?= , Thomas Huth , "Michael S. Tsirkin" , Igor Mammedov , Alexander Bulekov , Bandan Das , Stefan Hajnoczi , Huacai Chen , Jiaxun Yang , Aurelien Jarno , Aleksandar Rikalo , Havard Skinnemoen , Tyrone Ting , Pavel Pisa , Vikram Garhwal , Jason Wang , Keith Busch , Klaus Jensen , Cornelia Huck , Halil Pasic , Christian Borntraeger , David Hildenbrand , Gerd Hoffmann , Vijai Kumar K , Alistair Francis , Bin Meng , Palmer Dabbelt , "Edgar E. Iglesias" , Laurent Vivier , Corey Minyard , =?utf-8?Q?C=C3=A9?= =?utf-8?Q?dric?= Le Goater , Andrew Jeffery , Joel Stanley , Francisco Iglesias , David Gibson , Greg Kurz , Alexey Kardashevskiy , =?utf-8?Q?Herv=C3=A9?= Poussineau , Bastian Koppelmann , "Dr. David Alan Gilbert" , Stefan Berger , Taylor Simpson , qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org Subject: Re: [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes In-Reply-To: <20210806211127.646908-6-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 6 Aug 2021 17:11:20 -0400") References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-6-ehabkost@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Reply-To: quintela@redhat.com Date: Tue, 10 Aug 2021 14:01:40 +0200 Message-ID: <877dgt1paz.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.704, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2021 12:01:49 -0000 Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \ > $(git grep -l '' -- '*.[ch]') > > which will: > - split "typdef struct { ... } TypedefName" declarations > - move the typedefs and #defines above the type check macros > - add missing #include "qom/object.h" lines if necessary > > Signed-off-by: Eduardo Habkost Reviewed-by: Juan Quintela Just curious, how did my name ended on the CC'd list? I don't see any file that I touched or that is migration related. Later, Juan. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:c144:0:0:0:0:0 with SMTP id r65csp1252776lff; Tue, 10 Aug 2021 05:03:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3kcJXgJal8lMd18c+8+IzN+7h11jQaJKVc96YAjye+8aPfsIlKIQu2z+dLDDUn8MHnqe/ X-Received: by 2002:a50:c88d:: with SMTP id d13mr4390861edh.334.1628597031872; Tue, 10 Aug 2021 05:03:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628597031; cv=none; d=google.com; s=arc-20160816; b=aI1+arf1KuL99NtT3ALtuQtCiMaeDFdy75mpTO9jTnO+ZcVhEtoYAR2oLtyW5fAJQz dxcUpsoa3+9jfB+6Qas60n2ibz3Z5/5Nc8qKn+s9ChrcQtY/op3s5O72690RYrOdjlYx 1qvxhILHeJWDJOpOyOj5MohnPsslIkde8tBqmk0VXBUxAK/XC50/o6hbamMB5dlSGUxs CAr3gBCV48AOguJTtpl5Y34gqI5Eu6DfNB8UuL+uPM2KMX7HnLUt0t5CG9ZELlhyFDUl tU1zTTQ8IxQRlVJhM2ndEVyWTQ210/TKN4ACE4LZdTAj0Le6Kui62rtObkSFbsvo5ZRR Jdkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :message-id:date:user-agent:references:in-reply-to:subject:to:from :dkim-signature; bh=8yJTX7eNzzbNaJggB4MTVcWm01xc/Rs3c9Spl2Cmkgo=; b=CyhR/GwuRT7uB23/iQD4oj7sjPBH+t4bFcr0+WadUrfbQXY7W2e+eLyrp0sBAaauAy Oeb5oTHsvrvqj/OSiY8bw+OQT6Io4rHn7fn85Ry88DLbsJ+zw3f0Pp0a4spDucmttLZd PLCYDXlJcMiN2+oTjyZb6aKDcMjUV3grYJ8YbbO7lcE8JZNz2USBWCgUOWX4SkladN6Q O76n8t3TqNOnklWietiL5fa1KnWx9Xo7QKmmMwExsguBFIFVKOgrAlSdR+Tf6AzMez5h IAqpKyO93eccQHbF1cf9+M5IdGny/YvD4z7h2uP9t9EPFL/4862gaGuW1E+bxbpBIg4E VR9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=FPa7X9IV; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ht8si19525275ejc.381.2021.08.10.05.03.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Aug 2021 05:03:51 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=FPa7X9IV; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:55170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDQU2-0003lJ-Ub for alex.bennee@linaro.org; Tue, 10 Aug 2021 08:03:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQS5-0001EJ-M9 for qemu-arm@nongnu.org; Tue, 10 Aug 2021 08:01:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQS1-0004qh-Tb for qemu-arm@nongnu.org; Tue, 10 Aug 2021 08:01:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628596904; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8yJTX7eNzzbNaJggB4MTVcWm01xc/Rs3c9Spl2Cmkgo=; b=FPa7X9IV/PQ9vwUG/+HHosiGO6Uz5j9T9EheWB+kZqkxgvhfKNipd/NrNY7U5RYvKiYSWm Oi5gZglqB5qPZxeZnN2l2jHY8Ev/5zbNjbhT7iDPYcHZ3gfUAVhI2itpb7j+Y06zU8BTJG Rq0qKQdNTX6Xah804hOsB9HYrmR/r1A= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-Z-ZKJZ4sOuGDJaTPjDWYbA-1; Tue, 10 Aug 2021 08:01:43 -0400 X-MC-Unique: Z-ZKJZ4sOuGDJaTPjDWYbA-1 Received: by mail-wr1-f69.google.com with SMTP id o4-20020a5d47c40000b0290154ad228388so6291129wrc.9 for ; Tue, 10 Aug 2021 05:01:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version; bh=8yJTX7eNzzbNaJggB4MTVcWm01xc/Rs3c9Spl2Cmkgo=; b=rGrd5ZjRlmYOjPKgBHD7orP1I1ghidCYM9m2AHsYF6Ys6O22M+hSisCG2t+Uylyb3P h6/zb7H8E1y3hOaVafE0qZIqQ4enhJlMW0E7OlIeZEz1ZyhNoS2HFK6FvnruzrORkBzi gi/Mn7wZzK8jhRwTeT/E03rvhfpUOX+ucMYZ8a3nD6UqE1PaN9/UAktL/2gvEYuCmjhO crbaaGg8PESCY1yRgl7wQCAvNFzKLE3uOzNTaIi1lF6MxuqH33iLJSlki7g9jnlkNjS/ bzFfBDbJKVtIKc2mOMU4c/POgxI4W1+md2XXu5FU2K0joxnUs5LyFtaLIvCq5FZUnwwk 4YWw== X-Gm-Message-State: AOAM530erXttHAM4k3vHg0S4xb1y7xrm6YYVtYaF7enSoatwX3jiJA8c 1ai0GjN0nGz16w4bSruqlmMTAtuqDrlldJrBdDqlKEhtLXERcHxdtljZ5fUsNPNUE/Bw26WbwwM goV8OvtaVLnrF X-Received: by 2002:a5d:658a:: with SMTP id q10mr30910133wru.343.1628596902472; Tue, 10 Aug 2021 05:01:42 -0700 (PDT) X-Received: by 2002:a5d:658a:: with SMTP id q10mr30910057wru.343.1628596902136; Tue, 10 Aug 2021 05:01:42 -0700 (PDT) Received: from localhost (62.83.194.64.dyn.user.ono.com. [62.83.194.64]) by smtp.gmail.com with ESMTPSA id j4sm20637348wmi.4.2021.08.10.05.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 05:01:41 -0700 (PDT) From: Juan Quintela To: Eduardo Habkost Subject: Re: [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes In-Reply-To: <20210806211127.646908-6-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 6 Aug 2021 17:11:20 -0400") References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-6-ehabkost@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Tue, 10 Aug 2021 14:01:40 +0200 Message-ID: <877dgt1paz.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) DKIMWL_WL_HIGH=-0.704, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Peter Maydell , "Michael S. Tsirkin" , Alexey Kardashevskiy , Andrew Jeffery , Jason Wang , Bin Meng , David Hildenbrand , qemu-devel@nongnu.org, Jiaxun Yang , Laurent Vivier , Vijai Kumar K , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Klaus Jensen , Vikram Garhwal , qemu-block@nongnu.org, Stefan Berger , qemu-ppc@nongnu.org, Huacai Chen , Havard Skinnemoen , Halil Pasic , Christian Borntraeger , =?utf-8?Q?Herv=C3=A9?= Poussineau , Joel Stanley , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Pavel Pisa , Aleksandar Rikalo , Corey Minyard , qemu-s390x@nongnu.org, Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9?= =?utf-8?Q?dric?= Le Goater , Stefan Hajnoczi , Paolo Bonzini , Keith Busch , qemu-riscv@nongnu.org, David Gibson , "Daniel P. Berrange" , Francisco Iglesias , Thomas Huth , Bastian Koppelmann , Cornelia Huck , Philippe =?utf-8?Q?Mathi?= =?utf-8?Q?eu-Daud=C3=A9?= , Andrew Baumann , Tyrone Ting , Palmer Dabbelt , Igor Mammedov , Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: yXyGFSzewxk3 Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \ > $(git grep -l '' -- '*.[ch]') > > which will: > - split "typdef struct { ... } TypedefName" declarations > - move the typedefs and #defines above the type check macros > - add missing #include "qom/object.h" lines if necessary > > Signed-off-by: Eduardo Habkost Reviewed-by: Juan Quintela Just curious, how did my name ended on the CC'd list? I don't see any file that I touched or that is migration related. Later, Juan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089E7C4338F for ; Tue, 10 Aug 2021 12:03:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67A2960E78 for ; Tue, 10 Aug 2021 12:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 67A2960E78 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDQU4-0003ZT-AP for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 08:03:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQS4-0001By-Tb for qemu-devel@nongnu.org; Tue, 10 Aug 2021 08:01:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31369) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQS1-0004qk-Ka for qemu-devel@nongnu.org; Tue, 10 Aug 2021 08:01:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628596904; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8yJTX7eNzzbNaJggB4MTVcWm01xc/Rs3c9Spl2Cmkgo=; b=FPa7X9IV/PQ9vwUG/+HHosiGO6Uz5j9T9EheWB+kZqkxgvhfKNipd/NrNY7U5RYvKiYSWm Oi5gZglqB5qPZxeZnN2l2jHY8Ev/5zbNjbhT7iDPYcHZ3gfUAVhI2itpb7j+Y06zU8BTJG Rq0qKQdNTX6Xah804hOsB9HYrmR/r1A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-599-OeRf0sifNgOasCTNaz-wBg-1; Tue, 10 Aug 2021 08:01:43 -0400 X-MC-Unique: OeRf0sifNgOasCTNaz-wBg-1 Received: by mail-wr1-f71.google.com with SMTP id w1-20020adf8bc10000b0290154bed98988so5040793wra.1 for ; Tue, 10 Aug 2021 05:01:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version; bh=8yJTX7eNzzbNaJggB4MTVcWm01xc/Rs3c9Spl2Cmkgo=; b=Lc1Ypi/BCk2jUSFYkC1iPutxtFrTdXU3JZfYYwgCP1CAMo8ziZpRO1aVQwv7vF5jMU LMM6N3RBVSo2j/N1E/GdKK7DFF6M8fOxj0wZEXb6jaS9p7Nl90XcFWrbe2dTteZoPiYc 0dvTghSpAP24JK4fzrZXokYOI4SAlIuMKza+LEccgx/iVD3Dsfi7qqzoFhl8JPXeutG1 3mxyPbOCTaKV04ar919YqMJ1MWiVZ41kzJnvx4ATZORKbl/dEQQuiruqiJ2rJ9qEMnlB A0Mh32Gurg6JeeEu8JK7BsgZCw0CcReDnrk9qZwRWnq81tLp+94CO3rTzqKV8m1Wa3n0 hwdA== X-Gm-Message-State: AOAM533RTPNoCsdjtdu8QR7KfL9Irg/JI2YnHYwK2F4hvJSbTLgELv9F xKaS+eUjYE92p3TvgsJZHyBmhBHu02RYW98hSN5SO5HXcwcRAut3B5JFFaQzg2/qCNvp8o3dDPu rew/z28AhFalBYIY= X-Received: by 2002:a5d:658a:: with SMTP id q10mr30910126wru.343.1628596902441; Tue, 10 Aug 2021 05:01:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3hzXJq/uMeMUgLEKYXP7YdeYgeEjV4RTqS2QrZnBsjiQwGsXJUTgme4xDTdtVLt8j8LEVnA== X-Received: by 2002:a5d:658a:: with SMTP id q10mr30910057wru.343.1628596902136; Tue, 10 Aug 2021 05:01:42 -0700 (PDT) Received: from localhost (62.83.194.64.dyn.user.ono.com. [62.83.194.64]) by smtp.gmail.com with ESMTPSA id j4sm20637348wmi.4.2021.08.10.05.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 05:01:41 -0700 (PDT) From: Juan Quintela To: Eduardo Habkost Subject: Re: [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes In-Reply-To: <20210806211127.646908-6-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 6 Aug 2021 17:11:20 -0400") References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-6-ehabkost@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Tue, 10 Aug 2021 14:01:40 +0200 Message-ID: <877dgt1paz.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.704, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Peter Maydell , "Michael S. Tsirkin" , Alexey Kardashevskiy , Andrew Jeffery , Jason Wang , Bin Meng , David Hildenbrand , qemu-devel@nongnu.org, Laurent Vivier , Vijai Kumar K , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Klaus Jensen , "Edgar E. Iglesias" , Vikram Garhwal , qemu-block@nongnu.org, Stefan Berger , qemu-ppc@nongnu.org, Huacai Chen , Havard Skinnemoen , Halil Pasic , Christian Borntraeger , =?utf-8?Q?Herv=C3=A9?= Poussineau , Joel Stanley , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Pavel Pisa , Aleksandar Rikalo , Corey Minyard , qemu-s390x@nongnu.org, Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9?= =?utf-8?Q?dric?= Le Goater , Stefan Hajnoczi , Paolo Bonzini , Keith Busch , qemu-riscv@nongnu.org, David Gibson , "Daniel P. Berrange" , Francisco Iglesias , Thomas Huth , Bastian Koppelmann , Cornelia Huck , Philippe =?utf-8?Q?Mathi?= =?utf-8?Q?eu-Daud=C3=A9?= , Andrew Baumann , Tyrone Ting , Palmer Dabbelt , Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \ > $(git grep -l '' -- '*.[ch]') > > which will: > - split "typdef struct { ... } TypedefName" declarations > - move the typedefs and #defines above the type check macros > - add missing #include "qom/object.h" lines if necessary > > Signed-off-by: Eduardo Habkost Reviewed-by: Juan Quintela Just curious, how did my name ended on the CC'd list? I don't see any file that I touched or that is migration related. Later, Juan.