From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00033C433B4 for ; Thu, 15 Apr 2021 07:17:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 401E86102A for ; Thu, 15 Apr 2021 07:17:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 401E86102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWwFj-0005Yk-3a for qemu-devel@archiver.kernel.org; Thu, 15 Apr 2021 03:17:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWwEN-00053I-TN for qemu-devel@nongnu.org; Thu, 15 Apr 2021 03:16:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWwEK-0003uS-Vq for qemu-devel@nongnu.org; Thu, 15 Apr 2021 03:16:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618470959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Elc4B5iEmKjNXlpyAEfkF5lfrQulQTBtOCWRTPAbP5o=; b=CyfdwsoYzuO5LBjE7/2Hn/8/PxtHqtpAfeO1NKiTrhSvrFqIk12ILiyAbU4u1tjX3fuywt tKSIe/B8L4OwTZbs+9N9aALmrpsEYyaKRfGrqQb076pfqg+8g6og8GdJB2wlzrQPaCdJHA B7E7ZFrJLHC/LJwCUtOpHshAb6GY+sY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-118-mub9RWQHOU6_CRg7omQC9g-1; Thu, 15 Apr 2021 03:15:55 -0400 X-MC-Unique: mub9RWQHOU6_CRg7omQC9g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BECF883DD20; Thu, 15 Apr 2021 07:15:54 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7692E5D71F; Thu, 15 Apr 2021 07:15:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F2187113525D; Thu, 15 Apr 2021 09:15:52 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH v2 7/8] qapi/error: Add type hints References: <20210330171844.1197918-1-jsnow@redhat.com> <20210330171844.1197918-8-jsnow@redhat.com> Date: Thu, 15 Apr 2021 09:15:52 +0200 In-Reply-To: <20210330171844.1197918-8-jsnow@redhat.com> (John Snow's message of "Tue, 30 Mar 2021 13:18:43 -0400") Message-ID: <877dl4ggrb.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Michael Roth , Michael Roth , qemu-devel@nongnu.org, Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > No functional change. > > Signed-off-by: John Snow > --- > scripts/qapi/error.py | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi/error.py b/scripts/qapi/error.py > index 2183b8c6b7..6ba54821c9 100644 > --- a/scripts/qapi/error.py > +++ b/scripts/qapi/error.py > @@ -11,6 +11,10 @@ > # This work is licensed under the terms of the GNU GPL, version 2. > # See the COPYING file in the top-level directory. > > +from typing import Optional > + > +from .source import QAPISourceInfo > + > > class QAPIError(Exception): > """Base class for all exceptions from the QAPI package.""" > @@ -18,13 +22,16 @@ class QAPIError(Exception): > > class QAPISourceError(QAPIError): > """Error class for all exceptions identifying a source location.""" > - def __init__(self, info, msg, col=None): > + def __init__(self, > + info: Optional[QAPISourceInfo], The Optional is a bit surprising. Mind pointing to the / a reason in the commit message? > + msg: str, > + col: Optional[int] = None): > super().__init__() > self.info = info > self.msg = msg > self.col = col > > - def __str__(self): > + def __str__(self) -> str: > assert self.info is not None > loc = str(self.info) > if self.col is not None: