From: "Aurélien Aptel" <aaptel@suse.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Steve French <sfrench@samba.org>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] cifs: cifspdu.h: Replace one-element array with flexible-array member
Date: Fri, 26 Mar 2021 16:54:49 +0100 [thread overview]
Message-ID: <877dltrjue.fsf@suse.com> (raw)
In-Reply-To: <20210326011117.GA46303@embeddedor>
"Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of one-element or zero-length arrays should no longer be used[2].
I've checked the usages of the struct, looks OK (we don't allocate it
directly, we use memory from the small/big buff pools).
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-03-26 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 1:11 [PATCH][next] cifs: cifspdu.h: Replace one-element array with flexible-array member Gustavo A. R. Silva
2021-03-26 15:54 ` Aurélien Aptel [this message]
2021-03-26 15:13 ` Gustavo A. R. Silva
2021-04-09 4:23 ` Steve French
2021-04-09 7:06 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dltrjue.fsf@suse.com \
--to=aaptel@suse.com \
--cc=gustavoars@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.