From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3277C5519F for ; Wed, 25 Nov 2020 08:39:34 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id F1FD720857 for ; Wed, 25 Nov 2020 08:39:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l/191OTg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1FD720857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 402E44B91E; Wed, 25 Nov 2020 03:39:33 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S7VjOCx11o4o; Wed, 25 Nov 2020 03:39:32 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 07F8D4B77C; Wed, 25 Nov 2020 03:39:32 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C26DA4B581 for ; Wed, 25 Nov 2020 03:39:30 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pt1kHhPzCNLk for ; Wed, 25 Nov 2020 03:39:29 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 960D54B562 for ; Wed, 25 Nov 2020 03:39:29 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4651E206F9; Wed, 25 Nov 2020 08:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606293568; bh=eEJ5tvTMFCOh+2EgmsUylqMSCWDMdYDdOop9Zs0Wk+4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l/191OTg338rw+68Dnye0ev5H6ZLhvdRPn7/RM0z1TX3WWSs+XR7vUJCrmhcg1yYz Gwq7hcAqVZ+GppFQqdZZ3HrYMK6UTORgU8wj+amjmU8Ub4LY0fSUNZIqiZ/THgoOz4 JAl9nSWoWT/rJYPirLyATMqSbQX8XMVTEMxG5O/E= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1khqKk-00DTd2-1g; Wed, 25 Nov 2020 08:39:26 +0000 Date: Wed, 25 Nov 2020 08:39:24 +0000 Message-ID: <877dq96dab.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH 0/8] KVM: arm64: Disabled PMU handling In-Reply-To: <750f5543-054a-f1aa-229f-2d41b8e233dd@arm.com> References: <20201113182602.471776-1-maz@kernel.org> <750f5543-054a-f1aa-229f-2d41b8e233dd@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVHVlLCAyNCBOb3YgMjAyMCAxNzoyODozMCArMDAwMCwKQWxleGFuZHJ1IEVsaXNlaSA8YWxl eGFuZHJ1LmVsaXNlaUBhcm0uY29tPiB3cm90ZToKPiAKPiBIaSBNYXJjLAo+IAo+IEkgYmVsaWV2 ZSB0aGVyZSBpcyBzb21ldGhpbmcgbWlzc2luZyBmcm9tIHRoaXMgc2VyaWVzLgo+IAo+IFRoZSBv cmlnaW5hbCBiZWhhdmlvdXIsIHdoaWNoIHRoaXMgc2VyaWVzIGNoYW5nZXMsIHdhcyBub3QgdG8g ZG8KPiByZWdpc3RlciBlbXVsYXRpb24gYW5kIFBNVSBzdGF0ZSB1cGRhdGUgaWYgdGhlIFBNVSB3 YXNuJ3QgcmVhZHksCj4gd2hlcmUgdmNwdS0+YXJjaC5wbXUucmVhZHkgd2FzIHNldCB0byB0cnVl IGlmIHRoZSBQTVUgd2FzCj4gaW5pdGlhbGl6ZWQgcHJvcGVybHkgaW4ga3ZtX3ZjcHVfZmlyc3Rf cnVuX2luaXQoKSAtPgo+IGt2bV9hcm1fcG11X3YzX2VuYWJsZSgpLgo+IAo+IFRoZSBzZXJpZXMg Y2hhbmdlcyBQTVUgZW11bGF0aW9uIHN1Y2ggdGhhdCByZWdpc3RlciBlbXVsYXRpb24gYW5kCj4g cG11IHN0YXRlIHVwZGF0ZSBpcyBnYXRlZCBvbmx5IG9uIHRoZSBWQ1BVIGZlYXR1cmUgYmVpbmcg c2V0LiBUaGlzCj4gbWVhbnMgdGhhdCBub3cgdXNlcnNwYWNlIGNhbiBzZXQgdGhlIFZDUFUgZmVh dHVyZSwgZG9uJ3QgZG8gYW55Cj4gaW5pdGlhbGl6YXRpb24sIGFuZCBydW4gYSBndWVzdCB3aGlj aCBjYW4gYWNjZXNzIFBNVSByZWdpc3RlcnMuIEFsc28KPiBrdm1fcG11X3VwZGF0ZV9zdGF0ZSgp IHdpbGwgbm93IGJlIGNhbGxlZCBiZWZvcmUgZWFjaCBWTSBlbnRyeS4gSSdtCj4gbm90IGV4YWN0 bHkgc3VyZSB3aGF0IGhhcHBlbnMgaWYgd2UgY2FsbCBrdm1fdmdpY19pbmplY3RfaXJxKCkgZm9y Cj4gYW4gaXJxX251bSA9IDAgYW5kIG5vdCBvd25lZCBieSB0aGUgUE1VICh0aGUgb3duZXIgaXMg c2V0Cj4gS1ZNX0FSTV9WQ1BVX1BNVV9WM19JTklUIC0+IGt2bV9hcm1fcG11X3YzX2luaXQoKSks IGJ1dCBJIGRvbid0Cj4gdGhpbmsgdGhhdCdzIGFsbG93ZWQuCgpUaGF0J3MgYSB2ZXJ5IGdvb2Qg cG9pbnQuIEkgZHJvcHBlZCB0aGUgInJlYWR5IiBzdGF0ZSBhIGJpdApjYXJlbGVzc2x5LCBhbmQg bm90aGluZyBndWFyZHMgYSBoYWxmIGJha2VkIFBNVSBhbnltb3JlLgoKPiAKPiBJIHdhcyBhbHNv IGFibGUgdG8gdHJpZ2dlciB0aGlzIHdhcm5pbmcgd2l0aCBhIG1vZGlmaWVkIHZlcnNpb24gb2Yg a3ZtdG9vbDoKClt1Z2x5IHdhcm5pbmddCgo+IEkgcmVtb3ZlZCBhbGwgS1ZNX0FSTV9WQ1BVX1BN VV9WM19DVFJMIGlvY3RsIGNhbGxzIGZyb20ga3ZtdG9vbCdzCj4gcG11IGVtdWxhdGlvbiwgYW5k IEkgc3RhcnRlZCB0aGUgcG11IHRlc3QgZnJvbSBrdm0tdW5pdC10ZXN0czoKPiAKPiAkIC4vbGt2 bS1wbXUgcnVuIC1jMSAtbTY0IC1mIGFybS9wbXUuZmxhdCAtLXBtdSAtcCBjeWNsZS1jb3VudGVy Cj4gCj4gVGhlIHJlYXNvbiBmb3IgdGhlIHdhcm5pbmcgaXMgdGhhdCB0aGUgY29ycmVjdCB2YWx1 ZSBmb3IKPiBrdm0tPmFyY2gucG11dmVyIGlzIHNldCBpbiBrdm1fYXJtX3BtdV92M19zZXRfYXR0 cigpLCB3aGljaCBpcyBub3QKPiBjYWxsZWQgYW55bW9yZS4KPiAKPiBUaGlzIGRpZmYgc2VlbXMg dG8gc29sdmUgdGhlIGlzc3VlOgo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9wbXUt ZW11bC5jIGIvYXJjaC9hcm02NC9rdm0vcG11LWVtdWwuYwo+IGluZGV4IDY0M2NmODE5ZjNjMC4u MTUwYjljYjBmNzQxIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQva3ZtL3BtdS1lbXVsLmMKPiAr KysgYi9hcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jCj4gQEAgLTgyNSw5ICs4MjUsMTIgQEAgYm9v bCBrdm1fYXJtX3N1cHBvcnRfcG11X3YzKHZvaWQpCj4gwqAKPiDCoGludCBrdm1fYXJtX3BtdV92 M19lbmFibGUoc3RydWN0IGt2bV92Y3B1ICp2Y3B1KQo+IMKgewo+IC3CoMKgwqDCoMKgwqAgaWYg KCF2Y3B1LT5hcmNoLnBtdS5jcmVhdGVkKQo+ICvCoMKgwqDCoMKgwqAgaWYgKCFrdm1fdmNwdV9o YXNfcG11KHZjcHUpKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsK PiDCoAo+ICvCoMKgwqDCoMKgwqAgaWYgKCF2Y3B1LT5hcmNoLnBtdS5jcmVhdGVkKQo+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRU5PRVhFQzsKPiArCj4gwqDCoMKgwqDC oMKgwqAgLyoKPiDCoMKgwqDCoMKgwqDCoMKgICogQSB2YWxpZCBpbnRlcnJ1cHQgY29uZmlndXJh dGlvbiBmb3IgdGhlIFBNVSBpcyBlaXRoZXIgdG8gaGF2ZSBhCj4gwqDCoMKgwqDCoMKgwqDCoCAq IHByb3Blcmx5IGNvbmZpZ3VyZWQgaW50ZXJydXB0IG51bWJlciBhbmQgdXNpbmcgYW4gaW4ta2Vy bmVsCj4gCj4gSWYgeW91IGFncmVlIHdpdGggdGhlIGZpeCwgSSBjYW4gc2VuZCBhIHByb3BlciBw YXRjaC4KPiB2Y3B1LT5hcmNoLnBtdS5jcmVhdGVkIGlzIHNldCBpbiBrdm1fYXJtX3BtdV92M19p bml0KCksIHdoaWNoIGNoZWNrcwo+IGlmIHRoZSBpbnRlcnJ1cHQgSUQgaGFzIGJlZW4gc2V0LiBJ IGNob3NlIHRvIHJldHVybiAtRU5PRVhFQ8KgCj4gYmVjYXVzZSB0aGF0J3Mgd2hhdCBLVk1fUlVO IHJldHVybnMgaWYgdGhlIHZjcHUgaXNuJ3QgaW5pdGlhbGl6ZWQgaW4KPiBrdm1fYXJjaF92Y3B1 X2lvY3RsX3J1bigpLgoKWWVzLCB0aGlzIHNlZW1zIHJlYXNvbmFibGUuIFRoZSBmaXJzdCBydW4g d2lsbCBmYWlsLCBhcyBmb3IgYW4KdW5pbml0aWFsaXNlZCB2Y3B1LgoKV2hpc3QgeW91J3JlIGRv aW5nIHRoYXQsIGNhbiB5b3UgcGxlYXNlIGRvY3VtZW50IHRoZSBFTk9FWEVDIHJldHVybgp2YWx1 ZT8gV2Ugb25seSBkb2N1bWVudCBFSU5UUiBzbyBmYXIuCgpUaGFua3MsCgoJTS4KCi0tIApXaXRo b3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWls aW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNv bHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AEDC5519F for ; Wed, 25 Nov 2020 08:40:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2A7E208C3 for ; Wed, 25 Nov 2020 08:40:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BMp8QmhC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l/191OTg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2A7E208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DkejuSv12nyYdYTkrNxe5AX65MfHXX15/mkP/ef7RxY=; b=BMp8QmhC3MrINCe8QNXGIGL64 WjHZ6+hG7DAIvwWxb0l6A0T6oyG+8lnfmqXCBTzcTa6k1TLZWRJCxgFmIQsBXqqDq9XEYCp+Wh3sD Lq0YQ4ujPN8HRVXjlUoyuxUaCBld8Nw082QdVG+yrYRk15gwUGoDDsDIZvdH7SsLgksUNBBHWqAx3 LNkIOYttzNDt8ug8rY9v8l+6n5oA+VCUWL5ZEjnDg00etYJdPSUC2DpbJQ1kqxGnT1aQ6O7O03uYs hKrEfV5F+F2dy9kP91x3gV5NOZ2nNvR14+BB8EnupDDvH5AaFHb2UMmAl5P7MQErg1eMjRT0mcfe5 uTJJiRMhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khqKq-0005WN-LG; Wed, 25 Nov 2020 08:39:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khqKo-0005Va-36 for linux-arm-kernel@lists.infradead.org; Wed, 25 Nov 2020 08:39:31 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4651E206F9; Wed, 25 Nov 2020 08:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606293568; bh=eEJ5tvTMFCOh+2EgmsUylqMSCWDMdYDdOop9Zs0Wk+4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l/191OTg338rw+68Dnye0ev5H6ZLhvdRPn7/RM0z1TX3WWSs+XR7vUJCrmhcg1yYz Gwq7hcAqVZ+GppFQqdZZ3HrYMK6UTORgU8wj+amjmU8Ub4LY0fSUNZIqiZ/THgoOz4 JAl9nSWoWT/rJYPirLyATMqSbQX8XMVTEMxG5O/E= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1khqKk-00DTd2-1g; Wed, 25 Nov 2020 08:39:26 +0000 Date: Wed, 25 Nov 2020 08:39:24 +0000 Message-ID: <877dq96dab.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH 0/8] KVM: arm64: Disabled PMU handling In-Reply-To: <750f5543-054a-f1aa-229f-2d41b8e233dd@arm.com> References: <20201113182602.471776-1-maz@kernel.org> <750f5543-054a-f1aa-229f-2d41b8e233dd@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201125_033930_394332_DAE9EE4C X-CRM114-Status: GOOD ( 29.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNCBOb3YgMjAyMCAxNzoyODozMCArMDAwMCwKQWxleGFuZHJ1IEVsaXNlaSA8YWxl eGFuZHJ1LmVsaXNlaUBhcm0uY29tPiB3cm90ZToKPiAKPiBIaSBNYXJjLAo+IAo+IEkgYmVsaWV2 ZSB0aGVyZSBpcyBzb21ldGhpbmcgbWlzc2luZyBmcm9tIHRoaXMgc2VyaWVzLgo+IAo+IFRoZSBv cmlnaW5hbCBiZWhhdmlvdXIsIHdoaWNoIHRoaXMgc2VyaWVzIGNoYW5nZXMsIHdhcyBub3QgdG8g ZG8KPiByZWdpc3RlciBlbXVsYXRpb24gYW5kIFBNVSBzdGF0ZSB1cGRhdGUgaWYgdGhlIFBNVSB3 YXNuJ3QgcmVhZHksCj4gd2hlcmUgdmNwdS0+YXJjaC5wbXUucmVhZHkgd2FzIHNldCB0byB0cnVl IGlmIHRoZSBQTVUgd2FzCj4gaW5pdGlhbGl6ZWQgcHJvcGVybHkgaW4ga3ZtX3ZjcHVfZmlyc3Rf cnVuX2luaXQoKSAtPgo+IGt2bV9hcm1fcG11X3YzX2VuYWJsZSgpLgo+IAo+IFRoZSBzZXJpZXMg Y2hhbmdlcyBQTVUgZW11bGF0aW9uIHN1Y2ggdGhhdCByZWdpc3RlciBlbXVsYXRpb24gYW5kCj4g cG11IHN0YXRlIHVwZGF0ZSBpcyBnYXRlZCBvbmx5IG9uIHRoZSBWQ1BVIGZlYXR1cmUgYmVpbmcg c2V0LiBUaGlzCj4gbWVhbnMgdGhhdCBub3cgdXNlcnNwYWNlIGNhbiBzZXQgdGhlIFZDUFUgZmVh dHVyZSwgZG9uJ3QgZG8gYW55Cj4gaW5pdGlhbGl6YXRpb24sIGFuZCBydW4gYSBndWVzdCB3aGlj aCBjYW4gYWNjZXNzIFBNVSByZWdpc3RlcnMuIEFsc28KPiBrdm1fcG11X3VwZGF0ZV9zdGF0ZSgp IHdpbGwgbm93IGJlIGNhbGxlZCBiZWZvcmUgZWFjaCBWTSBlbnRyeS4gSSdtCj4gbm90IGV4YWN0 bHkgc3VyZSB3aGF0IGhhcHBlbnMgaWYgd2UgY2FsbCBrdm1fdmdpY19pbmplY3RfaXJxKCkgZm9y Cj4gYW4gaXJxX251bSA9IDAgYW5kIG5vdCBvd25lZCBieSB0aGUgUE1VICh0aGUgb3duZXIgaXMg c2V0Cj4gS1ZNX0FSTV9WQ1BVX1BNVV9WM19JTklUIC0+IGt2bV9hcm1fcG11X3YzX2luaXQoKSks IGJ1dCBJIGRvbid0Cj4gdGhpbmsgdGhhdCdzIGFsbG93ZWQuCgpUaGF0J3MgYSB2ZXJ5IGdvb2Qg cG9pbnQuIEkgZHJvcHBlZCB0aGUgInJlYWR5IiBzdGF0ZSBhIGJpdApjYXJlbGVzc2x5LCBhbmQg bm90aGluZyBndWFyZHMgYSBoYWxmIGJha2VkIFBNVSBhbnltb3JlLgoKPiAKPiBJIHdhcyBhbHNv IGFibGUgdG8gdHJpZ2dlciB0aGlzIHdhcm5pbmcgd2l0aCBhIG1vZGlmaWVkIHZlcnNpb24gb2Yg a3ZtdG9vbDoKClt1Z2x5IHdhcm5pbmddCgo+IEkgcmVtb3ZlZCBhbGwgS1ZNX0FSTV9WQ1BVX1BN VV9WM19DVFJMIGlvY3RsIGNhbGxzIGZyb20ga3ZtdG9vbCdzCj4gcG11IGVtdWxhdGlvbiwgYW5k IEkgc3RhcnRlZCB0aGUgcG11IHRlc3QgZnJvbSBrdm0tdW5pdC10ZXN0czoKPiAKPiAkIC4vbGt2 bS1wbXUgcnVuIC1jMSAtbTY0IC1mIGFybS9wbXUuZmxhdCAtLXBtdSAtcCBjeWNsZS1jb3VudGVy Cj4gCj4gVGhlIHJlYXNvbiBmb3IgdGhlIHdhcm5pbmcgaXMgdGhhdCB0aGUgY29ycmVjdCB2YWx1 ZSBmb3IKPiBrdm0tPmFyY2gucG11dmVyIGlzIHNldCBpbiBrdm1fYXJtX3BtdV92M19zZXRfYXR0 cigpLCB3aGljaCBpcyBub3QKPiBjYWxsZWQgYW55bW9yZS4KPiAKPiBUaGlzIGRpZmYgc2VlbXMg dG8gc29sdmUgdGhlIGlzc3VlOgo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9wbXUt ZW11bC5jIGIvYXJjaC9hcm02NC9rdm0vcG11LWVtdWwuYwo+IGluZGV4IDY0M2NmODE5ZjNjMC4u MTUwYjljYjBmNzQxIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQva3ZtL3BtdS1lbXVsLmMKPiAr KysgYi9hcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jCj4gQEAgLTgyNSw5ICs4MjUsMTIgQEAgYm9v bCBrdm1fYXJtX3N1cHBvcnRfcG11X3YzKHZvaWQpCj4gwqAKPiDCoGludCBrdm1fYXJtX3BtdV92 M19lbmFibGUoc3RydWN0IGt2bV92Y3B1ICp2Y3B1KQo+IMKgewo+IC3CoMKgwqDCoMKgwqAgaWYg KCF2Y3B1LT5hcmNoLnBtdS5jcmVhdGVkKQo+ICvCoMKgwqDCoMKgwqAgaWYgKCFrdm1fdmNwdV9o YXNfcG11KHZjcHUpKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsK PiDCoAo+ICvCoMKgwqDCoMKgwqAgaWYgKCF2Y3B1LT5hcmNoLnBtdS5jcmVhdGVkKQo+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRU5PRVhFQzsKPiArCj4gwqDCoMKgwqDC oMKgwqAgLyoKPiDCoMKgwqDCoMKgwqDCoMKgICogQSB2YWxpZCBpbnRlcnJ1cHQgY29uZmlndXJh dGlvbiBmb3IgdGhlIFBNVSBpcyBlaXRoZXIgdG8gaGF2ZSBhCj4gwqDCoMKgwqDCoMKgwqDCoCAq IHByb3Blcmx5IGNvbmZpZ3VyZWQgaW50ZXJydXB0IG51bWJlciBhbmQgdXNpbmcgYW4gaW4ta2Vy bmVsCj4gCj4gSWYgeW91IGFncmVlIHdpdGggdGhlIGZpeCwgSSBjYW4gc2VuZCBhIHByb3BlciBw YXRjaC4KPiB2Y3B1LT5hcmNoLnBtdS5jcmVhdGVkIGlzIHNldCBpbiBrdm1fYXJtX3BtdV92M19p bml0KCksIHdoaWNoIGNoZWNrcwo+IGlmIHRoZSBpbnRlcnJ1cHQgSUQgaGFzIGJlZW4gc2V0LiBJ IGNob3NlIHRvIHJldHVybiAtRU5PRVhFQ8KgCj4gYmVjYXVzZSB0aGF0J3Mgd2hhdCBLVk1fUlVO IHJldHVybnMgaWYgdGhlIHZjcHUgaXNuJ3QgaW5pdGlhbGl6ZWQgaW4KPiBrdm1fYXJjaF92Y3B1 X2lvY3RsX3J1bigpLgoKWWVzLCB0aGlzIHNlZW1zIHJlYXNvbmFibGUuIFRoZSBmaXJzdCBydW4g d2lsbCBmYWlsLCBhcyBmb3IgYW4KdW5pbml0aWFsaXNlZCB2Y3B1LgoKV2hpc3QgeW91J3JlIGRv aW5nIHRoYXQsIGNhbiB5b3UgcGxlYXNlIGRvY3VtZW50IHRoZSBFTk9FWEVDIHJldHVybgp2YWx1 ZT8gV2Ugb25seSBkb2N1bWVudCBFSU5UUiBzbyBmYXIuCgpUaGFua3MsCgoJTS4KCi0tIApXaXRo b3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6F9C56201 for ; Wed, 25 Nov 2020 08:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 813B620857 for ; Wed, 25 Nov 2020 08:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l/191OTg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726851AbgKYIj3 (ORCPT ); Wed, 25 Nov 2020 03:39:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:60146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgKYIj2 (ORCPT ); Wed, 25 Nov 2020 03:39:28 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4651E206F9; Wed, 25 Nov 2020 08:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606293568; bh=eEJ5tvTMFCOh+2EgmsUylqMSCWDMdYDdOop9Zs0Wk+4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l/191OTg338rw+68Dnye0ev5H6ZLhvdRPn7/RM0z1TX3WWSs+XR7vUJCrmhcg1yYz Gwq7hcAqVZ+GppFQqdZZ3HrYMK6UTORgU8wj+amjmU8Ub4LY0fSUNZIqiZ/THgoOz4 JAl9nSWoWT/rJYPirLyATMqSbQX8XMVTEMxG5O/E= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1khqKk-00DTd2-1g; Wed, 25 Nov 2020 08:39:26 +0000 Date: Wed, 25 Nov 2020 08:39:24 +0000 Message-ID: <877dq96dab.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 0/8] KVM: arm64: Disabled PMU handling In-Reply-To: <750f5543-054a-f1aa-229f-2d41b8e233dd@arm.com> References: <20201113182602.471776-1-maz@kernel.org> <750f5543-054a-f1aa-229f-2d41b8e233dd@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 24 Nov 2020 17:28:30 +0000, Alexandru Elisei wrote: >=20 > Hi Marc, >=20 > I believe there is something missing from this series. >=20 > The original behaviour, which this series changes, was not to do > register emulation and PMU state update if the PMU wasn't ready, > where vcpu->arch.pmu.ready was set to true if the PMU was > initialized properly in kvm_vcpu_first_run_init() -> > kvm_arm_pmu_v3_enable(). >=20 > The series changes PMU emulation such that register emulation and > pmu state update is gated only on the VCPU feature being set. This > means that now userspace can set the VCPU feature, don't do any > initialization, and run a guest which can access PMU registers. Also > kvm_pmu_update_state() will now be called before each VM entry. I'm > not exactly sure what happens if we call kvm_vgic_inject_irq() for > an irq_num =3D 0 and not owned by the PMU (the owner is set > KVM_ARM_VCPU_PMU_V3_INIT -> kvm_arm_pmu_v3_init()), but I don't > think that's allowed. That's a very good point. I dropped the "ready" state a bit carelessly, and nothing guards a half baked PMU anymore. >=20 > I was also able to trigger this warning with a modified version of kvmtoo= l: [ugly warning] > I removed all KVM_ARM_VCPU_PMU_V3_CTRL ioctl calls from kvmtool's > pmu emulation, and I started the pmu test from kvm-unit-tests: >=20 > $ ./lkvm-pmu run -c1 -m64 -f arm/pmu.flat --pmu -p cycle-counter >=20 > The reason for the warning is that the correct value for > kvm->arch.pmuver is set in kvm_arm_pmu_v3_set_attr(), which is not > called anymore. >=20 > This diff seems to solve the issue: >=20 > diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c > index 643cf819f3c0..150b9cb0f741 100644 > --- a/arch/arm64/kvm/pmu-emul.c > +++ b/arch/arm64/kvm/pmu-emul.c > @@ -825,9 +825,12 @@ bool kvm_arm_support_pmu_v3(void) > =C2=A0 > =C2=A0int kvm_arm_pmu_v3_enable(struct kvm_vcpu *vcpu) > =C2=A0{ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!vcpu->arch.pmu.created) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!kvm_vcpu_has_pmu(vcpu)) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 return 0; > =C2=A0 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!vcpu->arch.pmu.created) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 return -ENOEXEC; > + > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * A valid interrupt conf= iguration for the PMU is either to have a > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * properly configured in= terrupt number and using an in-kernel >=20 > If you agree with the fix, I can send a proper patch. > vcpu->arch.pmu.created is set in kvm_arm_pmu_v3_init(), which checks > if the interrupt ID has been set. I chose to return -ENOEXEC=C2=A0 > because that's what KVM_RUN returns if the vcpu isn't initialized in > kvm_arch_vcpu_ioctl_run(). Yes, this seems reasonable. The first run will fail, as for an uninitialised vcpu. Whist you're doing that, can you please document the ENOEXEC return value? We only document EINTR so far. Thanks, M. --=20 Without deviation from the norm, progress is not possible.