From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Drew DeVault <sir@cmpwn.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, lanodan <contact+git@hacktivis.me>
Subject: Re: [PATCH v3] help.c: configurable suggestions
Date: Wed, 18 Nov 2020 19:27:49 +0100 [thread overview]
Message-ID: <877dqir04a.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <C76K6Q09ATLR.1OI5KW390LKFX@taiga>
On Wed, Nov 18 2020, Drew DeVault wrote:
> On Wed Nov 18, 2020 at 12:16 PM EST, Junio C Hamano wrote:
>> It is unclear from this description alone why this is needed. The
>> seller of this change needs to emphasize how this is better than
>> setting the variable to "0" (do not autocorrect). My guess is that
>> some users do not even need the suggestion of correct spelling when
>> they made a typo?
>
> This is one reason. Another is that spell checking can be
> computationally expensive, and take an annoyingly long time on low-end
> devices.
As an aside it would be interesting if you're in a position to test it
whether it's the suggestion code itself that's so expensive, or e.g. the
stat()-ing on "git xyz" looking for "git-xyz" in $PATH. I if it's
FS-limited that there's easy optimization opportunities there.
prev parent reply other threads:[~2020-11-18 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 14:42 [PATCH v3] help.c: configurable suggestions Drew DeVault
2020-11-18 17:16 ` Junio C Hamano
2020-11-18 17:17 ` Drew DeVault
2020-11-18 17:46 ` Junio C Hamano
2020-11-18 18:27 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dqir04a.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=contact+git@hacktivis.me \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.