From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD08CC388F2 for ; Mon, 2 Nov 2020 15:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80C552225B for ; Mon, 2 Nov 2020 15:54:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MgB3NGJA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbgKBPym (ORCPT ); Mon, 2 Nov 2020 10:54:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59819 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726385AbgKBPyl (ORCPT ); Mon, 2 Nov 2020 10:54:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604332480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baNTDuDx70k7XjIF3i9X3EY75tEmpoVA8KNG+Qv0Vg4=; b=MgB3NGJAFYfmWy3x2CcneR5q7SFQ8WxOmwS5Omb2uNGa7fij7pQdxUYiznKeXMZ9b76AK0 olojxiHHnQuFEi0tXx6Sh2IwMq8ZjaToynQkYqe5rByFh/7uK1YE8moGygMZ7yIsMg9GzN 1sLCkdpf1pA5l03YpQDZXKL45yU5618= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-Y4gcp0T1OMaoDGhVAqN_lw-1; Mon, 02 Nov 2020 10:54:38 -0500 X-MC-Unique: Y4gcp0T1OMaoDGhVAqN_lw-1 Received: by mail-qt1-f197.google.com with SMTP id h16so8243190qtr.8 for ; Mon, 02 Nov 2020 07:54:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=baNTDuDx70k7XjIF3i9X3EY75tEmpoVA8KNG+Qv0Vg4=; b=GDoSA3k3RanEBlQhzB3XJ+P0CpJ/8zpDX/ps7ADI22y5to0VMTJbAxw13LllKdOIY8 nW/ypV2MJapcNRQF+tXdoijdNLln2nSjo3k5L+/+t++yfh4u9IwKXzTarmxGVa/1GznZ VwZ+/M6xHL3iQr12px8nJfHDVccO10dpnl75e1eFCUAiyN8Q4237LPrHbGBu0+oxmMmf LGW7Kn0JJTSy7J8idu02A1TwzkFGFOKitJhdiaCT62qlXm7+mbYCcNfPHcACCjRLh2ei s+O3MNw5sUzXwM5gwT9FBiJKZnFekQJjx/rW/pLkKujV2nvKukwPbTdtsiMzdghMQkvr NTgQ== X-Gm-Message-State: AOAM531ys5Q+skrGy3juTwgujrMhyISVOL7gKu7Uc2vHgoV/2wcmagMM ypVemzcfhwNyPemqoRwJnFtEvy4UJLwv9cochRel9lznL59IUMooavc0Umn2lNvbpVFFkp/lE3h nC6AE+oENUIq71fCEJp4t X-Received: by 2002:ac8:2bf7:: with SMTP id n52mr15507389qtn.164.1604332478244; Mon, 02 Nov 2020 07:54:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxizZfH98b/hy3aHOdoxbAxg+L1hI6MhcKTsry/nP4ffxRAZHd2XgxINLO5+o86Bs+PiBCFw== X-Received: by 2002:ac8:2bf7:: with SMTP id n52mr15507343qtn.164.1604332477722; Mon, 02 Nov 2020 07:54:37 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id v206sm1487066qkb.114.2020.11.02.07.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 07:54:36 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 17230181CED; Mon, 2 Nov 2020 16:54:35 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Pali =?utf-8?Q?Roh=C3=A1r?= Cc: vtolkm@gmail.com, Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Ilias Apalodimas , Marek =?utf-8?Q?Beh=C3=BAn?= , Thomas Petazzoni , Jason Cooper Subject: Re: PCI trouble on mvebu (Turris Omnia) In-Reply-To: <20201102152403.4jlmcaqkqeivuypm@pali> References: <2fb69e2a-4423-2b04-cd0f-ca819092bc5f@gmail.com> <20201028231626.GA344207@bjorn-Precision-5520> <20201030112331.meqg6lvultyn6v54@pali> <87k0v7n9y9.fsf@toke.dk> <20201030142337.yushrdcuecycfhcu@pali> <87zh42lfv6.fsf@toke.dk> <20201102152403.4jlmcaqkqeivuypm@pali> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 02 Nov 2020 16:54:35 +0100 Message-ID: <877dr3lpok.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Pali Roh=C3=A1r writes: > On Saturday 31 October 2020 13:49:49 Toke H=C3=B8iland-J=C3=B8rgensen wro= te: >> "=E2=84=A2=D6=9F=E2=98=BB=D2=87=CC=AD =D1=BC =D2=89 =C2=AE" writes: >>=20 >> > On 30/10/2020 15:23, Pali Roh=C3=A1r wrote: >> >> On Friday 30 October 2020 14:02:22 Toke H=C3=B8iland-J=C3=B8rgensen w= rote: >> >>> Pali Roh=C3=A1r writes: >> >>>> My experience with that WLE900VX card, aardvark driver and aspm cod= e: >> >>>> >> >>>> Link training in GEN2 mode for this card succeed only once after re= set. >> >>>> Repeated link retraining fails and it fails even when aardvark is >> >>>> reconfigured to GEN1 mode. Reset via PERST# signal is required to h= ave >> >>>> working link training. >> >>>> >> >>>> What I did in aardvark driver: Set mode to GEN2, do link training. = If >> >>>> success read "negotiated link speed" from "Link Control Status Regi= ster" >> >>>> (for WLE900VX it is 0x1 - GEN1) and set it into aardvark. And then >> >>>> retrain link again (for WLE900VX now it would be at GEN1). After th= at >> >>>> card is stable and all future retraining (e.g. from aspm.c) also pa= sses. >> >>>> >> >>>> If I do not change aardvark mode from GEN2 to GEN1 the second link >> >>>> training fails. And if I change mode to GEN1 after this failed link >> >>>> training then nothing happen, link training do not success. >> >>>> >> >>>> So just speculation now... In current setup initialization of card = does >> >>>> one link training at GEN2. Then aspm.c is called which is doing sec= ond >> >>>> link retraining at GEN2. And if it fails then below patch issue thi= rd >> >>>> link retraining at GEN1. If A38x/pci-mvebu has same problem as aard= vark >> >>>> then second link retraining must be at GEN1 (not GEN2) to workaround >> >>>> this issue. >> >>>> >> >>>> Bjorn, Toke: what about trying to hack aspm.c code to never do link >> >>>> retraining at GEN2 speed? And always force GEN1 speed prior link >> >>>> training? >> >>> Sounds like a plan. I poked around in aspm.c and must confess to bei= ng a >> >>> bit lost in the soup of registers ;) >> >>> >> >>> So if one of you can cook up a patch, that would be most helpful! >> >> I modified Bjorn's patch, explicitly set tls to 1 and added debug info >> >> about cls (current link speed, that what is used by aardvark). It is >> >> untested, I just tried to compile it. >> >> >> >> Can try it? >> >> >> >> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c >> >> index 253c30cc1967..f934c0b52f41 100644 >> >> --- a/drivers/pci/pcie/aspm.c >> >> +++ b/drivers/pci/pcie/aspm.c >> >> @@ -206,6 +206,27 @@ static bool pcie_retrain_link(struct pcie_link_s= tate *link) >> >> unsigned long end_jiffies; >> >> u16 reg16; >> >>=20=20=20 >> >> + u32 lnkcap2; >> >> + u16 lnksta, lnkctl2, cls, tls; >> >> + >> >> + pcie_capability_read_dword(parent, PCI_EXP_LNKCAP2, &lnkcap2); >> >> + pcie_capability_read_word(parent, PCI_EXP_LNKSTA, &lnksta); >> >> + pcie_capability_read_word(parent, PCI_EXP_LNKCTL2, &lnkctl2); >> >> + cls =3D lnksta & PCI_EXP_LNKSTA_CLS; >> >> + tls =3D lnkctl2 & PCI_EXP_LNKCTL2_TLS; >> >> + >> >> + pci_info(parent, "lnkcap2 %#010x sls %#04x lnksta %#06x cls %#03x l= nkctl2 %#06x tls %#03x\n", >> >> + lnkcap2, (lnkcap2 & 0x3F) >> 1, >> >> + lnksta, cls, >> >> + lnkctl2, tls); >> >> + >> >> + tls =3D 1; >> >> + pcie_capability_clear_and_set_word(parent, PCI_EXP_LNKCTL2, >> >> + PCI_EXP_LNKCTL2_TLS, tls); >> >> + pcie_capability_read_word(parent, PCI_EXP_LNKCTL2, &lnkctl2); >> >> + pci_info(parent, "lnkctl2 %#010x new tls %#03x\n", >> >> + lnkctl2, tls); >> >> + >> >> pcie_capability_read_word(parent, PCI_EXP_LNKCTL, ®16); >> >> reg16 |=3D PCI_EXP_LNKCTL_RL; >> >> pcie_capability_write_word(parent, PCI_EXP_LNKCTL, reg16); >> >> @@ -227,6 +248,8 @@ static bool pcie_retrain_link(struct pcie_link_st= ate *link) >> >> break; >> >> msleep(1); >> >> } while (time_before(jiffies, end_jiffies)); >> >> + pci_info(parent, "lnksta %#06x new cls %#03x\n", >> >> + lnksta, (cls & PCI_EXP_LNKSTA_CLS)); >> >> return !(reg16 & PCI_EXP_LNKSTA_LT); >> >> } >> >>=20=20=20 >> > >> > Still exhibiting the BAR update error, run tested with next--20201030 >>=20 >> Yup, same for me :( > > So then it is different issue and not similar to aardvark one. > > Anyway, was ASPM working on some previous kernel version? Or was it > always broken on Turris Omnia? I tried bisecting and couldn't find a commit that worked. And OpenWrt by default builds with ASPM off, so my best guess is that it was always broken. However, the two other PCI slots *do* work with ASPM on, as long as they're both occupied when booting. If I only have one card installed apart from the dodge WLE900, both of them fail... > And has somebody other Armada 385 device with mPCIe slots to test if > ASPM is working? Or any other 32bit Marvell Armada SOC? > > I would like to know if this is issue only on Turris Omnia or also on > other Armada 385 SOC device or even on any other device which uses > pci-mvebu.c driver. See above: It does partly work on my Omnia. Is it possible to define a quirk to just disable it on a per-slot basis for the WLE900 card? Maybe just doing that and calling it a day would be enough... -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85528C00A89 for ; Mon, 2 Nov 2020 15:56:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 200E322258 for ; Mon, 2 Nov 2020 15:56:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3Zu3JrVl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZeoruSK4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 200E322258 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LxEkCUMus7x94Eyw5EQWbXvzHxLNzJF8ppyZAZ/nQCs=; b=3Zu3JrVla6vYFMmC9JfarLfZ2 vCA9nepo5leUOs2FZdE0QXQKhGBiTEyBBM6qK7G9tmSFOeeh4kpoywEf6npN+8mKQkAKnmUD+c9l8 X4GshAFvHz7zCwgwV3V7m5sP/Pim8acoB5I2XPL4+iH8y6MrYaZ9tQjufj4kv0luSCF4GmgEQxO3S 9ZkJSFBQwVjJFJlQQhoxU2C3HQB33R+AmnzN1CYibdKsCWcyKBXVAqncNch00lT5wYPrVfGJRhEeL Gg6LQ/SvHWNLkAxWADo+V0E8UHWq3lliN2nbOfXhaKkRP9saLdAgZOL/K1ZiGJlcYoMZmvpEvkDEF zYdFKC1gg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZcAP-00052L-27; Mon, 02 Nov 2020 15:54:45 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZcAM-000513-7B for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 15:54:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604332480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=selEHHpBMAUvmcE19uWgXjtHTISCs55zxlywc6PqVwA=; b=ZeoruSK4iDiQOvTtOB7hxwLHOSl0jatzn10gUIVoAeDl6Pc8X2qA7I1i41vWpy3p4Mbp1W 1PTzmL5d+4iNcTy9sj5TfVmtrq7+89dPTGkCdofxWdAjB+QGy8kF4XqOkQU6rDupEIG+rG nPYKTO5H9012NfNvWnXl2hmIsL2WqIE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-_MEVRbXGPh-21bgUFKA6Ow-1; Mon, 02 Nov 2020 10:54:39 -0500 X-MC-Unique: _MEVRbXGPh-21bgUFKA6Ow-1 Received: by mail-qv1-f70.google.com with SMTP id b13so8511986qvz.2 for ; Mon, 02 Nov 2020 07:54:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=baNTDuDx70k7XjIF3i9X3EY75tEmpoVA8KNG+Qv0Vg4=; b=OzAkXru3i2I1iBiSMzq/8qfX8gbgvsSLR1ULJvUvkZfV/NGzc6WLfDuvAKBZmsaNs3 ixkxw+w2D6e9n1Hn/cPPKQhBjsw53NkV3s8v2fwiWJKkQCI7iesgGHiQ7Gs9E28MqeMh j30Z5UrtVEjiSqPomeBwyMePeZnPMi1WEIKeo54auFMFCa2yfdNx0k35NqexlWyopZVz KXzrcn3lcjAdKdu7L/LUylhhoJlurCumecikHmxlcGMWh2fyH4l7+/0ZGiM4bisnRle8 nSRMZFwUQX7RXdEwKTPaZOGkfkGGbhVE6Zir8WwtNUEo3NgezIqVTp3Zh1fHB6tAQmFb Tsuw== X-Gm-Message-State: AOAM533KIWXZ9o9+GPQmnP6Qkawsh1FMdbodznIeqvk36yqmZ/XVeem6 rv3E85oV4eWm+Uym18Eftn89oaYlr/mXwfBhLQVvLPjQZSra7IYTDChvohib5tq3l6Jbs3TiUbt eArS6scaCvo6ygekCAQ/wOOl1lluAhj7y/Qo= X-Received: by 2002:ac8:2bf7:: with SMTP id n52mr15507395qtn.164.1604332478246; Mon, 02 Nov 2020 07:54:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxizZfH98b/hy3aHOdoxbAxg+L1hI6MhcKTsry/nP4ffxRAZHd2XgxINLO5+o86Bs+PiBCFw== X-Received: by 2002:ac8:2bf7:: with SMTP id n52mr15507343qtn.164.1604332477722; Mon, 02 Nov 2020 07:54:37 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id v206sm1487066qkb.114.2020.11.02.07.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 07:54:36 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 17230181CED; Mon, 2 Nov 2020 16:54:35 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Pali =?utf-8?Q?Roh=C3=A1r?= Subject: Re: PCI trouble on mvebu (Turris Omnia) In-Reply-To: <20201102152403.4jlmcaqkqeivuypm@pali> References: <2fb69e2a-4423-2b04-cd0f-ca819092bc5f@gmail.com> <20201028231626.GA344207@bjorn-Precision-5520> <20201030112331.meqg6lvultyn6v54@pali> <87k0v7n9y9.fsf@toke.dk> <20201030142337.yushrdcuecycfhcu@pali> <87zh42lfv6.fsf@toke.dk> <20201102152403.4jlmcaqkqeivuypm@pali> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 02 Nov 2020 16:54:35 +0100 Message-ID: <877dr3lpok.fsf@toke.dk> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=toke@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_105442_297947_DE25D153 X-CRM114-Status: GOOD ( 25.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jason Cooper , linux-pci@vger.kernel.org, Ilias Apalodimas , Marek =?utf-8?Q?Beh=C3=BAn?= , Bjorn Helgaas , Thomas Petazzoni , vtolkm@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4gd3JpdGVzOgoKPiBPbiBTYXR1cmRheSAzMSBP Y3RvYmVyIDIwMjAgMTM6NDk6NDkgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+PiAi 4oSi1p/imLvSh8ytING8INKJIMKuIiA8dnRvbGttQGdvb2dsZW1haWwuY29tPiB3cml0ZXM6Cj4+ IAo+PiA+IE9uIDMwLzEwLzIwMjAgMTU6MjMsIFBhbGkgUm9ow6FyIHdyb3RlOgo+PiA+PiBPbiBG cmlkYXkgMzAgT2N0b2JlciAyMDIwIDE0OjAyOjIyIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiB3 cm90ZToKPj4gPj4+IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+IHdyaXRlczoKPj4gPj4+ PiBNeSBleHBlcmllbmNlIHdpdGggdGhhdCBXTEU5MDBWWCBjYXJkLCBhYXJkdmFyayBkcml2ZXIg YW5kIGFzcG0gY29kZToKPj4gPj4+Pgo+PiA+Pj4+IExpbmsgdHJhaW5pbmcgaW4gR0VOMiBtb2Rl IGZvciB0aGlzIGNhcmQgc3VjY2VlZCBvbmx5IG9uY2UgYWZ0ZXIgcmVzZXQuCj4+ID4+Pj4gUmVw ZWF0ZWQgbGluayByZXRyYWluaW5nIGZhaWxzIGFuZCBpdCBmYWlscyBldmVuIHdoZW4gYWFyZHZh cmsgaXMKPj4gPj4+PiByZWNvbmZpZ3VyZWQgdG8gR0VOMSBtb2RlLiBSZXNldCB2aWEgUEVSU1Qj IHNpZ25hbCBpcyByZXF1aXJlZCB0byBoYXZlCj4+ID4+Pj4gd29ya2luZyBsaW5rIHRyYWluaW5n Lgo+PiA+Pj4+Cj4+ID4+Pj4gV2hhdCBJIGRpZCBpbiBhYXJkdmFyayBkcml2ZXI6IFNldCBtb2Rl IHRvIEdFTjIsIGRvIGxpbmsgdHJhaW5pbmcuIElmCj4+ID4+Pj4gc3VjY2VzcyByZWFkICJuZWdv dGlhdGVkIGxpbmsgc3BlZWQiIGZyb20gIkxpbmsgQ29udHJvbCBTdGF0dXMgUmVnaXN0ZXIiCj4+ ID4+Pj4gKGZvciBXTEU5MDBWWCBpdCBpcyAweDEgLSBHRU4xKSBhbmQgc2V0IGl0IGludG8gYWFy ZHZhcmsuIEFuZCB0aGVuCj4+ID4+Pj4gcmV0cmFpbiBsaW5rIGFnYWluIChmb3IgV0xFOTAwVlgg bm93IGl0IHdvdWxkIGJlIGF0IEdFTjEpLiBBZnRlciB0aGF0Cj4+ID4+Pj4gY2FyZCBpcyBzdGFi bGUgYW5kIGFsbCBmdXR1cmUgcmV0cmFpbmluZyAoZS5nLiBmcm9tIGFzcG0uYykgYWxzbyBwYXNz ZXMuCj4+ID4+Pj4KPj4gPj4+PiBJZiBJIGRvIG5vdCBjaGFuZ2UgYWFyZHZhcmsgbW9kZSBmcm9t IEdFTjIgdG8gR0VOMSB0aGUgc2Vjb25kIGxpbmsKPj4gPj4+PiB0cmFpbmluZyBmYWlscy4gQW5k IGlmIEkgY2hhbmdlIG1vZGUgdG8gR0VOMSBhZnRlciB0aGlzIGZhaWxlZCBsaW5rCj4+ID4+Pj4g dHJhaW5pbmcgdGhlbiBub3RoaW5nIGhhcHBlbiwgbGluayB0cmFpbmluZyBkbyBub3Qgc3VjY2Vz cy4KPj4gPj4+Pgo+PiA+Pj4+IFNvIGp1c3Qgc3BlY3VsYXRpb24gbm93Li4uIEluIGN1cnJlbnQg c2V0dXAgaW5pdGlhbGl6YXRpb24gb2YgY2FyZCBkb2VzCj4+ID4+Pj4gb25lIGxpbmsgdHJhaW5p bmcgYXQgR0VOMi4gVGhlbiBhc3BtLmMgaXMgY2FsbGVkIHdoaWNoIGlzIGRvaW5nIHNlY29uZAo+ PiA+Pj4+IGxpbmsgcmV0cmFpbmluZyBhdCBHRU4yLiBBbmQgaWYgaXQgZmFpbHMgdGhlbiBiZWxv dyBwYXRjaCBpc3N1ZSB0aGlyZAo+PiA+Pj4+IGxpbmsgcmV0cmFpbmluZyBhdCBHRU4xLiBJZiBB Mzh4L3BjaS1tdmVidSBoYXMgc2FtZSBwcm9ibGVtIGFzIGFhcmR2YXJrCj4+ID4+Pj4gdGhlbiBz ZWNvbmQgbGluayByZXRyYWluaW5nIG11c3QgYmUgYXQgR0VOMSAobm90IEdFTjIpIHRvIHdvcmth cm91bmQKPj4gPj4+PiB0aGlzIGlzc3VlLgo+PiA+Pj4+Cj4+ID4+Pj4gQmpvcm4sIFRva2U6IHdo YXQgYWJvdXQgdHJ5aW5nIHRvIGhhY2sgYXNwbS5jIGNvZGUgdG8gbmV2ZXIgZG8gbGluawo+PiA+ Pj4+IHJldHJhaW5pbmcgYXQgR0VOMiBzcGVlZD8gQW5kIGFsd2F5cyBmb3JjZSBHRU4xIHNwZWVk IHByaW9yIGxpbmsKPj4gPj4+PiB0cmFpbmluZz8KPj4gPj4+IFNvdW5kcyBsaWtlIGEgcGxhbi4g SSBwb2tlZCBhcm91bmQgaW4gYXNwbS5jIGFuZCBtdXN0IGNvbmZlc3MgdG8gYmVpbmcgYQo+PiA+ Pj4gYml0IGxvc3QgaW4gdGhlIHNvdXAgb2YgcmVnaXN0ZXJzIDspCj4+ID4+Pgo+PiA+Pj4gU28g aWYgb25lIG9mIHlvdSBjYW4gY29vayB1cCBhIHBhdGNoLCB0aGF0IHdvdWxkIGJlIG1vc3QgaGVs cGZ1bCEKPj4gPj4gSSBtb2RpZmllZCBCam9ybidzIHBhdGNoLCBleHBsaWNpdGx5IHNldCB0bHMg dG8gMSBhbmQgYWRkZWQgZGVidWcgaW5mbwo+PiA+PiBhYm91dCBjbHMgKGN1cnJlbnQgbGluayBz cGVlZCwgdGhhdCB3aGF0IGlzIHVzZWQgYnkgYWFyZHZhcmspLiBJdCBpcwo+PiA+PiB1bnRlc3Rl ZCwgSSBqdXN0IHRyaWVkIHRvIGNvbXBpbGUgaXQuCj4+ID4+Cj4+ID4+IENhbiB0cnkgaXQ/Cj4+ ID4+Cj4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0uYyBiL2RyaXZlcnMv cGNpL3BjaWUvYXNwbS5jCj4+ID4+IGluZGV4IDI1M2MzMGNjMTk2Ny4uZjkzNGMwYjUyZjQxIDEw MDY0NAo+PiA+PiAtLS0gYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0uYwo+PiA+PiArKysgYi9kcml2 ZXJzL3BjaS9wY2llL2FzcG0uYwo+PiA+PiBAQCAtMjA2LDYgKzIwNiwyNyBAQCBzdGF0aWMgYm9v bCBwY2llX3JldHJhaW5fbGluayhzdHJ1Y3QgcGNpZV9saW5rX3N0YXRlICpsaW5rKQo+PiA+PiAg IAl1bnNpZ25lZCBsb25nIGVuZF9qaWZmaWVzOwo+PiA+PiAgIAl1MTYgcmVnMTY7Cj4+ID4+ICAg Cj4+ID4+ICsJdTMyIGxua2NhcDI7Cj4+ID4+ICsJdTE2IGxua3N0YSwgbG5rY3RsMiwgY2xzLCB0 bHM7Cj4+ID4+ICsKPj4gPj4gKwlwY2llX2NhcGFiaWxpdHlfcmVhZF9kd29yZChwYXJlbnQsIFBD SV9FWFBfTE5LQ0FQMiwgJmxua2NhcDIpOwo+PiA+PiArCXBjaWVfY2FwYWJpbGl0eV9yZWFkX3dv cmQocGFyZW50LCBQQ0lfRVhQX0xOS1NUQSwgJmxua3N0YSk7Cj4+ID4+ICsJcGNpZV9jYXBhYmls aXR5X3JlYWRfd29yZChwYXJlbnQsIFBDSV9FWFBfTE5LQ1RMMiwgJmxua2N0bDIpOwo+PiA+PiAr CWNscyA9IGxua3N0YSAmIFBDSV9FWFBfTE5LU1RBX0NMUzsKPj4gPj4gKwl0bHMgPSBsbmtjdGwy ICYgUENJX0VYUF9MTktDVEwyX1RMUzsKPj4gPj4gKwo+PiA+PiArCXBjaV9pbmZvKHBhcmVudCwg Imxua2NhcDIgJSMwMTB4IHNscyAlIzA0eCBsbmtzdGEgJSMwNnggY2xzICUjMDN4IGxua2N0bDIg JSMwNnggdGxzICUjMDN4XG4iLAo+PiA+PiArCQlsbmtjYXAyLCAobG5rY2FwMiAmIDB4M0YpID4+ IDEsCj4+ID4+ICsJCWxua3N0YSwgY2xzLAo+PiA+PiArCQlsbmtjdGwyLCB0bHMpOwo+PiA+PiAr Cj4+ID4+ICsJdGxzID0gMTsKPj4gPj4gKwlwY2llX2NhcGFiaWxpdHlfY2xlYXJfYW5kX3NldF93 b3JkKHBhcmVudCwgUENJX0VYUF9MTktDVEwyLAo+PiA+PiArCQkJCQlQQ0lfRVhQX0xOS0NUTDJf VExTLCB0bHMpOwo+PiA+PiArCXBjaWVfY2FwYWJpbGl0eV9yZWFkX3dvcmQocGFyZW50LCBQQ0lf RVhQX0xOS0NUTDIsICZsbmtjdGwyKTsKPj4gPj4gKwlwY2lfaW5mbyhwYXJlbnQsICJsbmtjdGwy ICUjMDEweCBuZXcgdGxzICUjMDN4XG4iLAo+PiA+PiArCQlsbmtjdGwyLCB0bHMpOwo+PiA+PiAr Cj4+ID4+ICAgCXBjaWVfY2FwYWJpbGl0eV9yZWFkX3dvcmQocGFyZW50LCBQQ0lfRVhQX0xOS0NU TCwgJnJlZzE2KTsKPj4gPj4gICAJcmVnMTYgfD0gUENJX0VYUF9MTktDVExfUkw7Cj4+ID4+ICAg CXBjaWVfY2FwYWJpbGl0eV93cml0ZV93b3JkKHBhcmVudCwgUENJX0VYUF9MTktDVEwsIHJlZzE2 KTsKPj4gPj4gQEAgLTIyNyw2ICsyNDgsOCBAQCBzdGF0aWMgYm9vbCBwY2llX3JldHJhaW5fbGlu ayhzdHJ1Y3QgcGNpZV9saW5rX3N0YXRlICpsaW5rKQo+PiA+PiAgIAkJCWJyZWFrOwo+PiA+PiAg IAkJbXNsZWVwKDEpOwo+PiA+PiAgIAl9IHdoaWxlICh0aW1lX2JlZm9yZShqaWZmaWVzLCBlbmRf amlmZmllcykpOwo+PiA+PiArCXBjaV9pbmZvKHBhcmVudCwgImxua3N0YSAlIzA2eCBuZXcgY2xz ICUjMDN4XG4iLAo+PiA+PiArCQlsbmtzdGEsIChjbHMgJiBQQ0lfRVhQX0xOS1NUQV9DTFMpKTsK Pj4gPj4gICAJcmV0dXJuICEocmVnMTYgJiBQQ0lfRVhQX0xOS1NUQV9MVCk7Cj4+ID4+ICAgfQo+ PiA+PiAgIAo+PiA+Cj4+ID4gU3RpbGwgZXhoaWJpdGluZyB0aGUgQkFSIHVwZGF0ZSBlcnJvciwg cnVuIHRlc3RlZCB3aXRoIG5leHQtLTIwMjAxMDMwCj4+IAo+PiBZdXAsIHNhbWUgZm9yIG1lIDoo Cj4KPiBTbyB0aGVuIGl0IGlzIGRpZmZlcmVudCBpc3N1ZSBhbmQgbm90IHNpbWlsYXIgdG8gYWFy ZHZhcmsgb25lLgo+Cj4gQW55d2F5LCB3YXMgQVNQTSB3b3JraW5nIG9uIHNvbWUgcHJldmlvdXMg a2VybmVsIHZlcnNpb24/IE9yIHdhcyBpdAo+IGFsd2F5cyBicm9rZW4gb24gVHVycmlzIE9tbmlh PwoKSSB0cmllZCBiaXNlY3RpbmcgYW5kIGNvdWxkbid0IGZpbmQgYSBjb21taXQgdGhhdCB3b3Jr ZWQuIEFuZCBPcGVuV3J0IGJ5CmRlZmF1bHQgYnVpbGRzIHdpdGggQVNQTSBvZmYsIHNvIG15IGJl c3QgZ3Vlc3MgaXMgdGhhdCBpdCB3YXMgYWx3YXlzCmJyb2tlbi4KCkhvd2V2ZXIsIHRoZSB0d28g b3RoZXIgUENJIHNsb3RzICpkbyogd29yayB3aXRoIEFTUE0gb24sIGFzIGxvbmcgYXMKdGhleSdy ZSBib3RoIG9jY3VwaWVkIHdoZW4gYm9vdGluZy4gSWYgSSBvbmx5IGhhdmUgb25lIGNhcmQgaW5z dGFsbGVkCmFwYXJ0IGZyb20gdGhlIGRvZGdlIFdMRTkwMCwgYm90aCBvZiB0aGVtIGZhaWwuLi4K Cj4gQW5kIGhhcyBzb21lYm9keSBvdGhlciBBcm1hZGEgMzg1IGRldmljZSB3aXRoIG1QQ0llIHNs b3RzIHRvIHRlc3QgaWYKPiBBU1BNIGlzIHdvcmtpbmc/IE9yIGFueSBvdGhlciAzMmJpdCBNYXJ2 ZWxsIEFybWFkYSBTT0M/Cj4KPiBJIHdvdWxkIGxpa2UgdG8ga25vdyBpZiB0aGlzIGlzIGlzc3Vl IG9ubHkgb24gVHVycmlzIE9tbmlhIG9yIGFsc28gb24KPiBvdGhlciBBcm1hZGEgMzg1IFNPQyBk ZXZpY2Ugb3IgZXZlbiBvbiBhbnkgb3RoZXIgZGV2aWNlIHdoaWNoIHVzZXMKPiBwY2ktbXZlYnUu YyBkcml2ZXIuCgpTZWUgYWJvdmU6IEl0IGRvZXMgcGFydGx5IHdvcmsgb24gbXkgT21uaWEuIElz IGl0IHBvc3NpYmxlIHRvIGRlZmluZSBhCnF1aXJrIHRvIGp1c3QgZGlzYWJsZSBpdCBvbiBhIHBl ci1zbG90IGJhc2lzIGZvciB0aGUgV0xFOTAwIGNhcmQ/IE1heWJlCmp1c3QgZG9pbmcgdGhhdCBh bmQgY2FsbGluZyBpdCBhIGRheSB3b3VsZCBiZSBlbm91Z2guLi4KCi1Ub2tlCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=