All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] pc: comment stule fixup
Date: Mon, 02 Nov 2020 13:00:49 +0100	[thread overview]
Message-ID: <877dr4j7da.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20201102100948.1101121-1-mst@redhat.com> (Michael S. Tsirkin's message of "Mon, 2 Nov 2020 05:09:54 -0500")

"Michael S. Tsirkin" <mst@redhat.com> writes:

> Fix up checkpatch comment style warnings.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/i386/pc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 416fb0e0f6..5872ae6095 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1150,9 +1150,9 @@ void pc_basic_device_init(struct PCMachineState *pcms,
>              exit(1);
>          }
>          /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
> -            * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> -            * IRQ8 and IRQ2.
> -            */
> +         * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> +         * IRQ8 and IRQ2.
> +         */
>          uint8_t compat = object_property_get_uint(OBJECT(hpet),
>                  HPET_INTCAP, NULL);
>          if (!compat) {

Since you're touching this already...

CODING_STYLE.rst:

    Multiline comment blocks should have a row of stars on the left,
    and the initial /``*`` and terminating ``*``/ both on their own lines:

    .. code-block:: c

        /*
         * like
         * this
         */



      parent reply	other threads:[~2020-11-02 12:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 10:09 [PATCH] pc: comment stule fixup Michael S. Tsirkin
2020-11-02 10:25 ` Philippe Mathieu-Daudé
2020-11-02 12:00 ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dr4j7da.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.