From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D847FC388F9 for ; Tue, 27 Oct 2020 13:33:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 328D821556 for ; Tue, 27 Oct 2020 13:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CLOyIy87" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 328D821556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXP6U-0008PU-6E for qemu-devel@archiver.kernel.org; Tue, 27 Oct 2020 09:33:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXOYi-0006rz-Gm for qemu-devel@nongnu.org; Tue, 27 Oct 2020 08:58:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXOYg-00026S-7D for qemu-devel@nongnu.org; Tue, 27 Oct 2020 08:58:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603803515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bLjaIsRc1S6ewa6g07CRntNXt6IGH9iRzNZZKQiS3JI=; b=CLOyIy87WTh80BaDe54WFaQYaG2vDZXxAtNhyeBFVVFIAaVA+XhP1qpXu0XL3pJNNKAYuq RNht0kqct/GWIYaWGlJB1/Sf+kjhoVw4C1ZXrgwqYbTk+Ye45NwtIo7+ttAxyEm6bO7WH8 P/aq7ztyivqq4Y8JOgvhi6K/32sZJg8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-8f2hS73-M3GiMK2rSTQgiA-1; Tue, 27 Oct 2020 08:58:33 -0400 X-MC-Unique: 8f2hS73-M3GiMK2rSTQgiA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6CA2803F62; Tue, 27 Oct 2020 12:58:32 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 827EA10013D9; Tue, 27 Oct 2020 12:58:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F2701113865F; Tue, 27 Oct 2020 13:58:27 +0100 (CET) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH v6 01/11] block: Simplify QAPI_LIST_ADD References: <20201027050556.269064-1-eblake@redhat.com> <20201027050556.269064-2-eblake@redhat.com> Date: Tue, 27 Oct 2020 13:58:27 +0100 In-Reply-To: <20201027050556.269064-2-eblake@redhat.com> (Eric Blake's message of "Tue, 27 Oct 2020 00:05:46 -0500") Message-ID: <877drbu8p8.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, pkrempa@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, rjones@redhat.com, vsementsov@virtuozzo.com, stefanha@redhat.com, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > There is no need to rely on the verbosity of the gcc/clang compiler > extension of g_new(typeof(X), 1) when we can instead use the standard > g_malloc(sizeof(X)). In general, we like g_new over g_malloc for > returning type X rather than void* to let the compiler catch more > potential typing mistakes, but in this particular macro, our other use > of typeof on the same line already ensures we are getting correct > results. > > Suggested-by: Markus Armbruster > Signed-off-by: Eric Blake > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index 430edf79bb10..857387f3912f 100644 > --- a/block.c > +++ b/block.c > @@ -5231,7 +5231,7 @@ BlockDeviceInfoList *bdrv_named_nodes_list(bool flat, > } > > #define QAPI_LIST_ADD(list, element) do { \ > - typeof(list) _tmp = g_new(typeof(*(list)), 1); \ > + typeof(list) _tmp = g_malloc(sizeof(*(list))); \ > _tmp->value = (element); \ > _tmp->next = (list); \ > (list) = _tmp; \ Reviewed-by: Markus Armbruster