All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Vandita Kulkarni <vandita.kulkarni@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [V9 1/4] drm/i915/dsi: Add details about TE in get_config
Date: Tue, 15 Sep 2020 14:38:36 +0300	[thread overview]
Message-ID: <877dsvxoar.fsf@intel.com> (raw)
In-Reply-To: <20200909085047.31004-2-vandita.kulkarni@intel.com>

On Wed, 09 Sep 2020, Vandita Kulkarni <vandita.kulkarni@intel.com> wrote:
> We need details about enabling TE on which port
> before we enable TE through vblank enable path.
> This is based on the configuration that we receive
> from the VBT wrt ports, dual_link.
>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c | 30 +++++++++++++++-----------
>  1 file changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index f4053dd6bde9..ee3c5c085cd3 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1447,6 +1447,18 @@ static bool gen11_dsi_is_periodic_cmd_mode(struct intel_dsi *intel_dsi)
>  	return (val & DSI_PERIODIC_FRAME_UPDATE_ENABLE);
>  }
>  
> +static void gen11_dsi_get_cmd_mode_config(struct intel_dsi *intel_dsi,
> +					  struct intel_crtc_state *pipe_config)
> +{
> +	if (intel_dsi->ports == (BIT(PORT_B) | BIT(PORT_A)))
> +		pipe_config->mode_flags |= I915_MODE_FLAG_DSI_USE_TE1 |
> +					    I915_MODE_FLAG_DSI_USE_TE0;
> +	else if (intel_dsi->ports == BIT(PORT_B))
> +		pipe_config->mode_flags |= I915_MODE_FLAG_DSI_USE_TE1;
> +	else
> +		pipe_config->mode_flags |= I915_MODE_FLAG_DSI_USE_TE0;
> +}
> +
>  static void gen11_dsi_get_config(struct intel_encoder *encoder,
>  				 struct intel_crtc_state *pipe_config)
>  {
> @@ -1468,6 +1480,10 @@ static void gen11_dsi_get_config(struct intel_encoder *encoder,
>  	pipe_config->output_types |= BIT(INTEL_OUTPUT_DSI);
>  	pipe_config->pipe_bpp = bdw_get_pipemisc_bpp(crtc);
>  
> +	/* Get the details on which TE should be enabled */
> +	if (is_cmd_mode(intel_dsi))
> +		gen11_dsi_get_cmd_mode_config(intel_dsi, pipe_config);
> +
>  	if (gen11_dsi_is_periodic_cmd_mode(intel_dsi))
>  		pipe_config->mode_flags |= I915_MODE_FLAG_DSI_PERIODIC_CMD_MODE;
>  }
> @@ -1562,18 +1578,8 @@ static int gen11_dsi_compute_config(struct intel_encoder *encoder,
>  	 * receive TE from the slave if
>  	 * dual link is enabled
>  	 */
> -	if (is_cmd_mode(intel_dsi)) {
> -		if (intel_dsi->ports == (BIT(PORT_B) | BIT(PORT_A)))
> -			pipe_config->mode_flags |=
> -						I915_MODE_FLAG_DSI_USE_TE1 |
> -						I915_MODE_FLAG_DSI_USE_TE0;
> -		else if (intel_dsi->ports == BIT(PORT_B))
> -			pipe_config->mode_flags |=
> -						I915_MODE_FLAG_DSI_USE_TE1;
> -		else
> -			pipe_config->mode_flags |=
> -						I915_MODE_FLAG_DSI_USE_TE0;
> -	}
> +	if (is_cmd_mode(intel_dsi))
> +		gen11_dsi_get_cmd_mode_config(intel_dsi, pipe_config);
>  
>  	return 0;
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-09-15 11:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  8:50 [Intel-gfx] [V9 0/4] Add support for mipi dsi cmd mode Vandita Kulkarni
2020-09-09  8:50 ` [Intel-gfx] [V9 1/4] drm/i915/dsi: Add details about TE in get_config Vandita Kulkarni
2020-09-15 11:38   ` Jani Nikula [this message]
2020-09-09  8:50 ` [Intel-gfx] [V9 2/4] i915/dsi: Configure TE interrupt for cmd mode Vandita Kulkarni
2020-09-09  8:50 ` [Intel-gfx] [V9 3/4] drm/i915/dsi: Add TE handler for dsi " Vandita Kulkarni
2020-09-09 12:30   ` kernel test robot
2020-09-09 12:30     ` kernel test robot
2020-09-09 12:30   ` [Intel-gfx] [RFC PATCH] drm/i915/dsi: gen11_dsi_te_interrupt_handler() can be static kernel test robot
2020-09-09 12:30     ` kernel test robot
2020-09-15 12:01   ` [Intel-gfx] [V9 3/4] drm/i915/dsi: Add TE handler for dsi cmd mode Jani Nikula
2020-09-09  8:50 ` [Intel-gfx] [V9 4/4] drm/i915/dsi: Initiate fame request in " Vandita Kulkarni
2020-09-15 12:05   ` Jani Nikula
2020-09-15 12:28     ` Kulkarni, Vandita
2020-09-09  9:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for mipi dsi cmd mode (rev9) Patchwork
2020-09-09  9:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-09-09  9:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-09 11:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dsvxoar.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vandita.kulkarni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.