All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
	syzbot <syzbot+8267241609ae8c23b248@syzkaller.appspotmail.com>
Cc: davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	syzkaller-bugs@googlegroups.com, tglx@linutronix.de,
	xiyou.wangcong@gmail.com
Subject: Re: INFO: rcu detected stall in cleanup_net (4)
Date: Wed, 09 Sep 2020 14:54:36 -0700	[thread overview]
Message-ID: <877dt2pqeb.fsf@intel.com> (raw)
In-Reply-To: <20200909085203.5e335c61@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Hi Jakub,

Jakub Kicinski <kuba@kernel.org> writes:

> On Tue, 08 Sep 2020 22:29:21 -0700 syzbot wrote:
>> Hello,
>> 
>> syzbot found the following issue on:
>> 
>> HEAD commit:    59126901 Merge tag 'perf-tools-fixes-for-v5.9-2020-09-03' ..
>> git tree:       upstream
>> console output: https://syzkaller.appspot.com/x/log.txt?x=12edb935900000
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=3c5f6ce8d5b68299
>> dashboard link: https://syzkaller.appspot.com/bug?extid=8267241609ae8c23b248
>> compiler:       gcc (GCC) 10.1.0-syz 20200507
>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=157c7aa5900000
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13c92ef9900000
>> 
>> The issue was bisected to:
>> 
>> commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22
>> Author: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> Date:   Sat Sep 29 00:59:43 2018 +0000
>> 
>>     tc: Add support for configuring the taprio scheduler
>
>
> Vinicius, could you please take a look at all the syzbot reports which
> point to your commit? I know syzbot bisection is not super reliable,
> but at least 3 reports point to your commit now, so something's
> probably going on.

I did take a look, and it seems that it all boils down to having too
small (unreasonable?) intervals in the schedule, which causes the
hrtimer handler to starve the other kernel threads.

I have a quick fix to restrict the interval values to more sensible
values (at least equal to the time it takes to transmit the mininum
ethernet frame size), I am testing it and I will propose it soon. But a
proper solution will require more time.


Cheers,
-- 
Vinicius

  reply	other threads:[~2020-09-09 21:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  5:29 INFO: rcu detected stall in cleanup_net (4) syzbot
2020-09-09 15:52 ` Jakub Kicinski
2020-09-09 21:54   ` Vinicius Costa Gomes [this message]
2020-09-09 22:51     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dt2pqeb.fsf@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+8267241609ae8c23b248@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tglx@linutronix.de \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.