From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5042:0:0:0:0:0 with SMTP id a2csp1012559lfm; Wed, 24 Jun 2020 23:39:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZZMfNpJrawyP/0niEVB3YOyxfOlMrlJdtM2MWHpOpxFmrECUnRS3RePk3eWGXBhymaLBZ X-Received: by 2002:a25:7351:: with SMTP id o78mr48410060ybc.437.1593067146501; Wed, 24 Jun 2020 23:39:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593067146; cv=none; d=google.com; s=arc-20160816; b=zHB3z958WX4UNQZCp5DF+i+qvYixfP7ga8Uvtbf/pTrHOCAKjlpfEsN72aiVMiEoPX 30e3iiYAvWWb0YEGLzlVvToxvF5cohQVcocZGVtpoMcwgdGv/muH4RGAs/uIMXFE7lj2 ZbwDvaT+Zeg4Jm/PsnuT5w2QocMHvjmBBnve/DV2Hc+jIg6JxJSC7fSSpsok+5Haj2GT Kj8/xV+gOqal5/mrrIu+Hafr3emVLXwqNMNPsUPLRLbWzIVNDGu+B/7B780ZSOKyHXlK kUp7C9OWlgQ1PZ503+XWwhqRtKNvehGAlxJz7o0mWPn5elDUPwVjQZHVJkmtzlIcAq31 JjfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:dkim-signature; bh=HymxzkekFH6JguRLqQNclhKOAHUnbMVMPoKNI5hr4YQ=; b=PfIAswMrAUx8N+7tsLfdboa8eLWMo7h/ji/O1BNKJvVmbe4jTCGhMqW6ngZEfXqBpS I5UTZp2cIbNELevuHG/IPUGunGPTPv8S35ZQUgRs1Geh0VgDz1DFeRzZ4sDeX8GuYh2a n/9d8/WgSHXgCrqppheEBCwbgjjOCrEU3TYk+DDwyMJq4qN45KKrXSkO+8wNuBc+3xM+ m3N+4EHAAz4EMVOuItLGrrD4f1tqvi6JqnizCvWLj0JE8o1l9XH99oMT1gqPn4oGCOCq cPFaxsCnwTO5hyHfnT+7FjAVR6wYT9vhX8+MQOddfPbita3ZXB9Og3H8zApfgWN7nWOT 0JEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=jV+2Zi+z; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s46si20942866ybi.263.2020.06.24.23.39.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jun 2020 23:39:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=jV+2Zi+z; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:34930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joLXN-0004A7-US for alex.bennee@linaro.org; Thu, 25 Jun 2020 02:39:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joLWS-0003MK-V2 for qemu-devel@nongnu.org; Thu, 25 Jun 2020 02:38:08 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:25656 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joLWQ-0007pr-BZ for qemu-devel@nongnu.org; Thu, 25 Jun 2020 02:38:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593067085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HymxzkekFH6JguRLqQNclhKOAHUnbMVMPoKNI5hr4YQ=; b=jV+2Zi+zx+x1mh8lz2ohKC4jBaD4SPim+gUbVD26ZlpUc6ecDD6hIr7kOCbsvZAMGDB2BV 42yDZGIlgp0HSJx9L12hYOB5X8OGK/KbI+nrLeZb98bJ4ubIBCIky7dBcIA+qWDQ4X7nlE cEH43FCfQi9asG40TyY8adrX4tczZno= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-DDLDEzJoPtWYJB0x_81XKg-1; Thu, 25 Jun 2020 02:38:02 -0400 X-MC-Unique: DDLDEzJoPtWYJB0x_81XKg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B357107ACCA; Thu, 25 Jun 2020 06:38:01 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA0D260C87; Thu, 25 Jun 2020 06:38:00 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5672211384D4; Thu, 25 Jun 2020 08:37:59 +0200 (CEST) From: Markus Armbruster To: =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH v4 4/8] hw/misc/pca9552: Add a 'description' property for debugging purpose References: <20200620225854.31160-1-f4bug@amsat.org> <20200620225854.31160-5-f4bug@amsat.org> <4d335933-9669-43e1-0966-5f0255142012@kaod.org> <34fe3d2b-6b41-0509-f172-5b45486fdf0c@amsat.org> Date: Thu, 25 Jun 2020 08:37:59 +0200 In-Reply-To: (=?utf-8?Q?=22C=C3=A9dric?= Le Goater"'s message of "Mon, 22 Jun 2020 15:24:50 +0200") Message-ID: <877dvv4pmg.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 00:45:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Peter Maydell , Andrew Jeffery , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Joel Stanley , Paolo Bonzini Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: B81EICscOFYH C=C3=A9dric Le Goater writes: > On 6/22/20 10:31 AM, Philippe Mathieu-Daud=C3=A9 wrote: >> On 6/22/20 8:27 AM, C=C3=A9dric Le Goater wrote: >>> On 6/21/20 12:58 AM, Philippe Mathieu-Daud=C3=A9 wrote: >>>> Add a description field to distinguish between multiple devices. Pardon my lack of imagination: how does this help you with debugging? >>> Reviewed-by: C=C3=A9dric Le Goater >>> >>> Could it be a QOM attribute ?=20 >>=20 >> What do you call a 'QOM attribute'? >> Is it what qdev properties implement? >> (in this case via DEFINE_PROP_STRING). > > I meant a default Object property, which would apply to all Objects.=20 Good point. Many devices have multiple component objects of the same type. > What you did is fine, so : > > Reviewed-by: C=C3=A9dric Le Goater > > but, may be, a well defined child name is enough for the purpose. object_get_canonical_path() returns a distinct path for each (component) object. The path components are the child property names. Properties can have descriptions: object_property_set_description(). Sufficient?