From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9656DC2BB85 for ; Thu, 16 Apr 2020 10:13:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7013321D92 for ; Thu, 16 Apr 2020 10:13:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7013321D92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CCDB6E2EF; Thu, 16 Apr 2020 10:13:18 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 395E96E2EF for ; Thu, 16 Apr 2020 10:13:17 +0000 (UTC) IronPort-SDR: jcmk6M/FDooFX8zYrHjcAGc5LMqQMrcuVUoa7fBYo7pwqX/zps7alVCdi08W4IGwk4iI5mxcXy 1GtFyyZn7ZBw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 03:13:16 -0700 IronPort-SDR: C7Z/hoRB0wWX4IdpCvnjF3X/aZgdv5CiXfY0jx2GQX5L9LhcDsL7p/KeYkyq0qaL0j+h8UtXoo k09MLzdfV9mQ== X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="427783217" Received: from ellenfax-mobl2.ger.corp.intel.com (HELO localhost) ([10.249.44.122]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 03:13:14 -0700 From: Jani Nikula To: Anshuman Gupta , Uma Shankar In-Reply-To: <20200416095828.GK5533@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200416074721.472-1-uma.shankar@intel.com> <20200416095828.GK5533@intel.com> Date: Thu, 16 Apr 2020 13:13:12 +0300 Message-ID: <877dyf4u2v.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kai.vehmanen@intel.com, intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 16 Apr 2020, Anshuman Gupta wrote: > IMHO with control flow this function above initilization is not required. > u may remove this initilization if u agree, while pushing the patch. I don't recommend anyone changing anything even remotely functional while pushing. I'm fine with doing comment and whitepace changes, and as a rule nothing else. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx