From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F10C2BA19 for ; Tue, 14 Apr 2020 16:21:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1ACAE2075E for ; Tue, 14 Apr 2020 16:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SNJRtIP5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ACAE2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOJk-0000NC-7w for qemu-devel@archiver.kernel.org; Tue, 14 Apr 2020 12:21:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50334) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOHn-0006VS-PG for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOOHh-0004z1-1p for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:19:42 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:40047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOMrF-0004Jp-7F for qemu-devel@nongnu.org; Tue, 14 Apr 2020 10:48:13 -0400 Received: by mail-wr1-x443.google.com with SMTP id h26so3242404wrb.7 for ; Tue, 14 Apr 2020 07:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=ZR24j9hWskrgk6aq2YDPWPZ+EtU5XKar0fjET1Xo38w=; b=SNJRtIP5OiZcLISfO3oZ4TDdN0WDSCTg7eckN6uZFvSpJge5IJ5W7uszsFdXFAXLX/ Q4f69ozu/n0/iH5GSNyHowrsPWSRrUGzXJcMdFI2vkGeDDEfJUqp7VfNH6n0S2YcHsGE EJvetmqsNeJeO0Za4yYp26goD+/GgedvswqHYmvd5kAgeMy3kXK7+q6+tha0zb4upffC bxCkZ1IeYJJgFQCjckrPe+BDvkXCmlS2dZjtDq7yuwpKWQucleX/Z1ZPbO2tLB5evJXA zjymMWQs8UgPqbMiiMt3Uk5usWwoUClg+4YVq7F3fzp+tPxtFoQJ1AILq28GAucIY/QZ +LLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=ZR24j9hWskrgk6aq2YDPWPZ+EtU5XKar0fjET1Xo38w=; b=IBFcTdoGE7ogjWqxTx6chFKfIkILJXl9fVVG8z8rK5kcbDXPYAhsR3kg0o96eq4Cal prkQ14MGDC3D30j66qqsvDYUPDTpF9Pe/cSNZqK0rhMmfZl/rPZU1PBQgliQs+Asw0XS PPvt6oQr51RhCYwQEaIlZ+5iN723E9fP0VBKno47T98/O3TyNHXFlt4n/hnuC6TNV5XW tayGDwaFPTEs07S9pLKqU0caAeiULFSolBYr03VZeCTP+v01tiwIjX2uGa/1gvbAfkMo xBFHDYBBvq/1l6QV7z3E3FzHXX3k12zhzDc7VsANnbygZHRCFBq1gPsk9mqCqiYzHa4K B54A== X-Gm-Message-State: AGi0PuYfkFVzgBYRiknk6E6AAp5aNX/Xh5JPJj/QqMgFKQrlj7PsbIOc Ld/89VW4vUeEbgPobSRbsbzJYQ== X-Google-Smtp-Source: APiQypIzsgQ/BrzcUJEgi44YmJ0O15YabQdaKDxTd0iyMF5xlSlQat07r26VW5tACY6ch931/axnkQ== X-Received: by 2002:adf:a704:: with SMTP id c4mr1681835wrd.303.1586875691662; Tue, 14 Apr 2020 07:48:11 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x18sm19114640wrs.11.2020.04.14.07.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 07:48:10 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 4CB311FF7E; Tue, 14 Apr 2020 15:48:08 +0100 (BST) References: <20200411182934.28678-1-peter.maydell@linaro.org> <20200411182934.28678-2-peter.maydell@linaro.org> User-agent: mu4e 1.3.10; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Subject: Re: [PATCH for-5.0? 1/3] configure: Honour --disable-werror for Sphinx In-reply-to: <20200411182934.28678-2-peter.maydell@linaro.org> Date: Tue, 14 Apr 2020 15:48:08 +0100 Message-ID: <877dyi9l93.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > If we are not making warnings fatal for compilation, make them > non-fatal when building the Sphinx documentation also. (For instance > Sphinx 3.0 warns about some constructs that older versions were happy > with, which is a build failure if we use the warnings-as-errors > flag.) > > This provides a workaround at least for LP:1872113. > > Signed-off-by: Peter Maydell > --- > configure | 9 ++++++++- > Makefile | 2 +- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 22870f38672..7b9ae0418d0 100755 > --- a/configure > +++ b/configure > @@ -4928,6 +4928,12 @@ if check_include sys/kcov.h ; then > kcov=3Dyes > fi >=20=20 > +# If we're making warnings fatal, apply this to Sphinx runs as well > +sphinx_werror=3D"" > +if test "$werror" =3D "yes"; then > + sphinx_werror=3D"-W" > +fi > + I wonder if this would have caught the failure I was seeing on debian9 + mxe images? > # Check we have a new enough version of sphinx-build > has_sphinx_build() { > # This is a bit awkward but works: create a trivial document and > @@ -4936,7 +4942,7 @@ has_sphinx_build() { > # sphinx-build doesn't exist at all or if it is too old. > mkdir -p "$TMPDIR1/sphinx" > touch "$TMPDIR1/sphinx/index.rst" > - "$sphinx_build" -c "$source_path/docs" -b html "$TMPDIR1/sphinx" "$T= MPDIR1/sphinx/out" >/dev/null 2>&1 > + "$sphinx_build" $sphinx_werror -c "$source_path/docs" -b html > "$TMPDIR1/sphinx" "$TMPDIR1/sphinx/out" >/dev/null 2>&1 Note this will clash with the simple configure change I made to redirect the output to config.log. Anyway: Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e