From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Date: Mon, 23 Mar 2020 12:48:05 +0000 Subject: Re: [PATCH v3 8/9] KVM: VMX: Annotate vmx_x86_ops as __initdata Message-Id: <877dzb9r0a.fsf@vitty.brq.redhat.com> List-Id: References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-9-sean.j.christopherson@intel.com> In-Reply-To: <20200321202603.19355-9-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson , Paolo Bonzini Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Sean Christopherson writes: > Tag vmx_x86_ops with __initdata now the the struct is copied by value Typo, "now that the struct". > to a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/vmx/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index fac22e316417..eae90379d0d1 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -7668,7 +7668,7 @@ static bool vmx_check_apicv_inhibit_reasons(ulong bit) > return supported & BIT(bit); > } > > -static struct kvm_x86_ops vmx_x86_ops __ro_after_init = { > +static struct kvm_x86_ops vmx_x86_ops __initdata = { > .hardware_unsetup = hardware_unsetup, > > .hardware_enable = hardware_enable, Reviewed-by: Vitaly Kuznetsov -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D912C4332B for ; Mon, 23 Mar 2020 13:35:44 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 512702074D for ; Mon, 23 Mar 2020 13:35:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="btEvOdqZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 512702074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 084F14B0CB; Mon, 23 Mar 2020 09:35:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ucOayuUuL9Bs; Mon, 23 Mar 2020 09:35:43 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 82C1C4B0D2; Mon, 23 Mar 2020 09:35:37 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3771E4A534 for ; Mon, 23 Mar 2020 08:48:12 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OL2TNPZNYbiC for ; Mon, 23 Mar 2020 08:48:11 -0400 (EDT) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 64B0C4A4C0 for ; Mon, 23 Mar 2020 08:48:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584967691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B8wQahKGoRUIUJ5ZWFkVo9acPARo3TGrEWALHtiunpg=; b=btEvOdqZ9D7AaaGA3iliV9DU+70UMVihkk/dazaJbhkM2Jae9c1IbsMLvwfxg6whyL2Zn8 m+kh8KFM2CpmVQIcF6yxNuHYSMPRny1qc5aIiT/bN6frZRX9uas8X7JLIG1s+MoIv5y5wZ 0cD3eBbirBh1byy2u38sZ/w+rlW5DJE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-uz7PP1ocNmeAwWuKbTpnPA-1; Mon, 23 Mar 2020 08:48:09 -0400 X-MC-Unique: uz7PP1ocNmeAwWuKbTpnPA-1 Received: by mail-wr1-f71.google.com with SMTP id h17so7335758wru.16 for ; Mon, 23 Mar 2020 05:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=oZZMumaLZJu5X3TxC1ggPEB/siyDp674fd3PHOwNKOk=; b=J1FDCr1nE6gbNNi+WttiOTyJZJVMcPNfT8aAKvFbqyTQLV/GefRabpLOHCMq9nlqS1 l9b5dWAFPSVHoCy78RL7rYLW0cv+Atx1odEOYPKZzz0bgWrDUYoJLWSXiNPiE1ElJbWF HIkbB+EekDreHkuYkUwzUMoz+5l1xR9C/ZtOCJDMTIvADeb3yGYCE6x05fpV/wn68rZO X4/o7zTSvoZfF0HN2j/3t6gdM/pBh/6u5Vqmb8cFuNG3aFJ/sjRssixfOl9yxeGTplJ1 cGztueRbkyZmwaCP4JzTW+vEyZl7+C9ELJQLUyJKzOpgRNnHp/8DBHcu+VNWO34DF/zZ hsyg== X-Gm-Message-State: ANhLgQ0y5uh2Rcm7NGagE4UlOxZV+3BpFOPno8N8hd9k+WwCTzqNIkHQ B090PPdS2JMur/iaXzYyUsaTloPaf8uF9Kv+gfPjbhxgnN3AvlXms+D+mrV9bfYKFQsWQqh++kJ 4NDSgZIvohwlH5dFoOw7f/j6A X-Received: by 2002:adf:decf:: with SMTP id i15mr26153363wrn.277.1584967688272; Mon, 23 Mar 2020 05:48:08 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtzfkKiGqY46hQmyiE1uEEqN2+GnJhVE7scycSa3L2yRyeY3La61RQMFCIJXOpzJGHNoWPMLQ== X-Received: by 2002:adf:decf:: with SMTP id i15mr26153331wrn.277.1584967688007; Mon, 23 Mar 2020 05:48:08 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id m12sm15324212wmi.3.2020.03.23.05.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 05:48:07 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson , Paolo Bonzini Subject: Re: [PATCH v3 8/9] KVM: VMX: Annotate vmx_x86_ops as __initdata In-Reply-To: <20200321202603.19355-9-sean.j.christopherson@intel.com> References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-9-sean.j.christopherson@intel.com> Date: Mon, 23 Mar 2020 13:48:05 +0100 Message-ID: <877dzb9r0a.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Mailman-Approved-At: Mon, 23 Mar 2020 09:35:35 -0400 Cc: linux-arm-kernel@lists.infradead.org, Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, Sean Christopherson , linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , kvm-ppc@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Sean Christopherson writes: > Tag vmx_x86_ops with __initdata now the the struct is copied by value Typo, "now that the struct". > to a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/vmx/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index fac22e316417..eae90379d0d1 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -7668,7 +7668,7 @@ static bool vmx_check_apicv_inhibit_reasons(ulong bit) > return supported & BIT(bit); > } > > -static struct kvm_x86_ops vmx_x86_ops __ro_after_init = { > +static struct kvm_x86_ops vmx_x86_ops __initdata = { > .hardware_unsetup = hardware_unsetup, > > .hardware_enable = hardware_enable, Reviewed-by: Vitaly Kuznetsov -- Vitaly _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AF0C3F2CD for ; Mon, 23 Mar 2020 12:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 475282076A for ; Mon, 23 Mar 2020 12:48:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="USfXImCF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728293AbgCWMsM (ORCPT ); Mon, 23 Mar 2020 08:48:12 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:41185 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727840AbgCWMsM (ORCPT ); Mon, 23 Mar 2020 08:48:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584967691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oZZMumaLZJu5X3TxC1ggPEB/siyDp674fd3PHOwNKOk=; b=USfXImCFJKadRb001iHR6e1rBoAlfR0GSqjryUxPGTwN1Z1W3SiA6dtMbnEGioY+uGKXYv ZlZ4pJQvOkAdc7zn9QpSqdIPTLChLZJpr2MXq4AYt0Qy2OSBD7TttHrL9tpWTAiHHBTuP8 tfCJbqdZHmruWzxehVs9raf6VVKeP5Q= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-85-Ep1GgkzNPhaqu49hH3LCzQ-1; Mon, 23 Mar 2020 08:48:09 -0400 X-MC-Unique: Ep1GgkzNPhaqu49hH3LCzQ-1 Received: by mail-wr1-f72.google.com with SMTP id q18so7317925wrw.5 for ; Mon, 23 Mar 2020 05:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=oZZMumaLZJu5X3TxC1ggPEB/siyDp674fd3PHOwNKOk=; b=RCiVroPmE5hCutTKuugzch95Plg5novc4n6Ukp+CJ35xwiwTKodG5xa4aoHuws5mm3 8WbR3xc4dl88rNu3uYGKlho9hxq+ErWqwOifsRU5QFIJIYP41ozXQL0Bi2suqcYqUzfm r6ycZzPyUkh4wryBct0PylRMHts4hnqSCmnadW3/ht6rZY+p62hqASujuNRKBGitkAoB zxaGAypc2CW5wZNhkZcMtcNIHn8zh9F+eAsQdL7hDk21pVm5uGX+kCQIs238xwgk6yc3 96LaDkwyBonLJqsNF5hbnXrDmCXLjmVF1MvBE5YE7biXPoO57UyrT6KA3vVL6a63Yk3x +HxQ== X-Gm-Message-State: ANhLgQ3Uwj29ub/o0CbRTmc4M1v5IPQRqt906BCsh5aJjMoLdVU24S1t 3u+QLhFfDY/IBHY5eeYG7AAbFRVhf6XBC0GlXBo6S4ruIkTxY20O8hZgcJdohsdbtDlgl5uztWP xyan2uu0Xgw+nBDqgWug66Q== X-Received: by 2002:adf:decf:: with SMTP id i15mr26153358wrn.277.1584967688272; Mon, 23 Mar 2020 05:48:08 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtzfkKiGqY46hQmyiE1uEEqN2+GnJhVE7scycSa3L2yRyeY3La61RQMFCIJXOpzJGHNoWPMLQ== X-Received: by 2002:adf:decf:: with SMTP id i15mr26153331wrn.277.1584967688007; Mon, 23 Mar 2020 05:48:08 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id m12sm15324212wmi.3.2020.03.23.05.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 05:48:07 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson , Paolo Bonzini Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 8/9] KVM: VMX: Annotate vmx_x86_ops as __initdata In-Reply-To: <20200321202603.19355-9-sean.j.christopherson@intel.com> References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-9-sean.j.christopherson@intel.com> Date: Mon, 23 Mar 2020 13:48:05 +0100 Message-ID: <877dzb9r0a.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Sean Christopherson writes: > Tag vmx_x86_ops with __initdata now the the struct is copied by value Typo, "now that the struct". > to a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/vmx/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index fac22e316417..eae90379d0d1 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -7668,7 +7668,7 @@ static bool vmx_check_apicv_inhibit_reasons(ulong bit) > return supported & BIT(bit); > } > > -static struct kvm_x86_ops vmx_x86_ops __ro_after_init = { > +static struct kvm_x86_ops vmx_x86_ops __initdata = { > .hardware_unsetup = hardware_unsetup, > > .hardware_enable = hardware_enable, Reviewed-by: Vitaly Kuznetsov -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CA5C4332B for ; Mon, 23 Mar 2020 12:48:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC8482072E for ; Mon, 23 Mar 2020 12:48:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W17aqAvl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="btEvOdqZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC8482072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fod4qNIl/j7xTPNEs/yD/zqEZRDNxIwbvbAfH0FHV0Q=; b=W17aqAvlWmym32 dA5o3qISqfcj6dsCAThWNKU7ilS82z77uVJHvngYDcfQmbbRD1AUCbeKlbC1feJj6A0LuM/RDxblw dTIHQdD+gQfc7ItgHaRR9ey0t56Kbd9xGaG4IsH2letdHnm6rc9H+R58AZzglGrxq5EYZi8YrrDQy 99+Czoj+gNQzA3ZUR8vDl1/SYW6tmJ2FmGET0pqYk4OyL0rmpVVYeRhRP5CyvHcwKEIF6n9ZqbE8Q Nt6lfUMqeZetflUywvmBvK+EesPsakmvY1c401A236Pbze/yjV/9ihESbE4x/VCtEOhScl366O3WO 3nyM/l/Y0IDglMzPk+qw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGMV4-0006ZX-Tm; Mon, 23 Mar 2020 12:48:14 +0000 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGMV2-0006Z6-2O for linux-arm-kernel@lists.infradead.org; Mon, 23 Mar 2020 12:48:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584967691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B8wQahKGoRUIUJ5ZWFkVo9acPARo3TGrEWALHtiunpg=; b=btEvOdqZ9D7AaaGA3iliV9DU+70UMVihkk/dazaJbhkM2Jae9c1IbsMLvwfxg6whyL2Zn8 m+kh8KFM2CpmVQIcF6yxNuHYSMPRny1qc5aIiT/bN6frZRX9uas8X7JLIG1s+MoIv5y5wZ 0cD3eBbirBh1byy2u38sZ/w+rlW5DJE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-85-LM-HjYibNBGUWAQtT2sOnA-1; Mon, 23 Mar 2020 08:48:09 -0400 X-MC-Unique: LM-HjYibNBGUWAQtT2sOnA-1 Received: by mail-wr1-f71.google.com with SMTP id o18so3921947wrx.9 for ; Mon, 23 Mar 2020 05:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=oZZMumaLZJu5X3TxC1ggPEB/siyDp674fd3PHOwNKOk=; b=IW/cMytcChwUnfC/7pZDZgVpl9FZ79CC02xzUwSpFDs2Jt6vQYihgJaP7TPpddbmJA q7mm9hMC6dMOxEF0YWjHh7j632bRnGn/E1En2+UQd7qrZBd6rb8G7od5hjdo52g3ZuZ/ ijHzsbt9DqRb6emBeT+B3GkiHIbpMZtzB8KcFXWxzEYjp79lz50s6qmfWLR3kpW28KlN 1iE3+75pyoHsJrLgHVypOWj5Kb21Z25Zy2smsEwDmzeuwxZ+UQigPP5pxVOXw6r/GHB7 I+o/tz7LoWiYkZC8GbTUsJqN9btSVEtROhlmthHsN3FyfNVWLG7HVMkqxPs9Ry/UIQWD HOXA== X-Gm-Message-State: ANhLgQ0Xf1cXz9urr/5O5CK6N2cYbcaxQhnsHisUAoP7SsGe1IuOgRLA 3Wwwqf/9QFF5/PfixCJZGp307ecHb+QHu32i0Ah5/Xgt9mDtGgVC3KqLVbwhkpEF4uGkk8nFrWo qrB2k+4sN66jGMRRNht7Ao8qAW6wLcLRv35U= X-Received: by 2002:adf:decf:: with SMTP id i15mr26153368wrn.277.1584967688273; Mon, 23 Mar 2020 05:48:08 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtzfkKiGqY46hQmyiE1uEEqN2+GnJhVE7scycSa3L2yRyeY3La61RQMFCIJXOpzJGHNoWPMLQ== X-Received: by 2002:adf:decf:: with SMTP id i15mr26153331wrn.277.1584967688007; Mon, 23 Mar 2020 05:48:08 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id m12sm15324212wmi.3.2020.03.23.05.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 05:48:07 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson , Paolo Bonzini Subject: Re: [PATCH v3 8/9] KVM: VMX: Annotate vmx_x86_ops as __initdata In-Reply-To: <20200321202603.19355-9-sean.j.christopherson@intel.com> References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-9-sean.j.christopherson@intel.com> Date: Mon, 23 Mar 2020 13:48:05 +0100 Message-ID: <877dzb9r0a.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200323_054812_197374_CDFC70A5 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, Sean Christopherson , linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Morse , kvm-ppc@vger.kernel.org, Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sean Christopherson writes: > Tag vmx_x86_ops with __initdata now the the struct is copied by value Typo, "now that the struct". > to a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/vmx/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index fac22e316417..eae90379d0d1 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -7668,7 +7668,7 @@ static bool vmx_check_apicv_inhibit_reasons(ulong bit) > return supported & BIT(bit); > } > > -static struct kvm_x86_ops vmx_x86_ops __ro_after_init = { > +static struct kvm_x86_ops vmx_x86_ops __initdata = { > .hardware_unsetup = hardware_unsetup, > > .hardware_enable = hardware_enable, Reviewed-by: Vitaly Kuznetsov -- Vitaly _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel