All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/pkg-meson.mk: fix multiple _MESON_EXTRA_BINARIES
Date: Sat, 21 Mar 2020 20:45:27 +0100	[thread overview]
Message-ID: <877dzd5w6g.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200310121510.905791-1-john@metanate.com> (John Keeping's message of "Tue, 10 Mar 2020 12:15:10 +0000")

>>>>> "John" == John Keeping <john@metanate.com> writes:

 > If multiple entries are specified for _MESON_EXTRA_BINARIES, the current
 > sed expression will only replace the first one.

 > Specifically, from GNU sed 4.8 the manual says:

 >     /regexp/
 >         Match  lines matching the regular expression regexp.  Matching
 >         is performed on the current pattern space, which can be modified
 >         with commands such as ``s///''.

 > so after the first binary has been added, the next entry no longer
 > matches since the pattern space has been modifed.

 > Instead of adding a script for each value, apply the match once and add
 > a subsitution for each entry.

 > Signed-off-by: John Keeping <john@metanate.com>

Committed to 2020.02.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2020-03-21 19:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 12:15 [Buildroot] [PATCH] package/pkg-meson.mk: fix multiple _MESON_EXTRA_BINARIES John Keeping
2020-03-10 14:01 ` Peter Seiderer
2020-03-11 22:31 ` Yann E. MORIN
2020-03-21 19:45 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dzd5w6g.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.