From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFAD6C2BB1D for ; Fri, 13 Mar 2020 22:02:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C9812074A for ; Fri, 13 Mar 2020 22:02:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cLVXnxhD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C9812074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCsNe-0002s7-MI for qemu-devel@archiver.kernel.org; Fri, 13 Mar 2020 18:02:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56009) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCsMq-0002SA-3g for qemu-devel@nongnu.org; Fri, 13 Mar 2020 18:01:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCsMo-0004Tl-7C for qemu-devel@nongnu.org; Fri, 13 Mar 2020 18:01:20 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:48679 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCsMn-0004MJ-Hv for qemu-devel@nongnu.org; Fri, 13 Mar 2020 18:01:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584136876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z+85ZI/QpsKxlLuONDNDAPRvMh4mNYZ9s0UVbCPuCGE=; b=cLVXnxhDGDav4XcBKPUwFnhqo8zZCzZ3YKKgT52v66Qc1yYdmGn4ZS0jt0kQKKByD654GO AxNkoRo3wGiOrndsq3nftZde7Tv+0Tn42KKmAiKjANN72MJ/66zyqUP6+3eJVkFfQ8qDHn bYcq8ixMClaL1QOAhCMoX2CtFWx/NGA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-qpR6Qvq2MvKMBn6DKKBDNA-1; Fri, 13 Mar 2020 18:01:14 -0400 X-MC-Unique: qpR6Qvq2MvKMBn6DKKBDNA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33A9D800D6C; Fri, 13 Mar 2020 22:01:13 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D2CA271A3; Fri, 13 Mar 2020 22:01:12 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1102111386A6; Fri, 13 Mar 2020 23:01:11 +0100 (CET) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH] net: Complete qapi-fication of netdev_add References: <20200312211440.3767626-1-eblake@redhat.com> Date: Fri, 13 Mar 2020 23:01:10 +0100 In-Reply-To: <20200312211440.3767626-1-eblake@redhat.com> (Eric Blake's message of "Thu, 12 Mar 2020 16:14:40 -0500") Message-ID: <877dznewyh.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lekiravi@yandex-team.ru, Jason Wang , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" It's too late in my day for a full review. Just one observation for now. Eric Blake writes: > We've had all the required pieces for doing a type-safe representation > of netdev_add as a flat union for quite some time now (since > 0e55c381f6 in v2.7.0, released in 2016), but did not make the final > switch to using it because of concern about whether a command-line > regression in accepting "1" in place of 1 for integer arguments would > be problematic. Back then, we did not have the deprecation cycle to > allow us to make progress. But now that we have waited so long, other > problems have crept in: for example, our desire to add > qemu-storage-daemon is hampered by the inability to express net > objects, and we are unable to introspect what we actually accept. > Additionally, our round-trip through QemuOpts silently eats any > argument that expands to an array, rendering dnssearch, hostfwd, and > guestfwd useless through QMP: > > {"execute": "netdev_add", "arguments": { "id": "netdev0", > "type": "user", "dnssearch": [ > { "str": "8.8.8.8" }, { "str": "8.8.4.4" } > ]}} > > So without further ado, let's turn on proper QAPI. > > There are a few places where the QMP 'netdev_add' command is now > more strict: anywhere that the QAPI lists an integer member, we > now require a strict JSON integer (previously, we allowed both > integers and strings, because the conversion from QMP to QemuOpts > back to QObject collapsed them into integers). For example, > pre-patch, both of these examples succeed, but post-patch, the > second example now fails: > > {'execute':'netdev_add', > 'arguments':{'id':'net1', 'type':'hubport', 'hubid':1}} > {"return": {}} > {'execute':'netdev_add', > 'arguments':{'id':'net2', 'type':'hubport', 'hubid':"2"}} > {"error": {"class": "GenericError", "desc": "Invalid parameter type for '= hubid', expected: integer"}} > > But this stricter QMP is desirable, and introspection is sufficient > for any affected applications to make sure they use it correctly. > > In qmp_netdev_add(), we still have to create a QemuOpts object > so that qmp_netdev_del() will be able to remove a hotplugged > network device; but the opts->head remains empty since we now > manage all parsing through the QAPI object rather than QemuOpts. > > Reported-by: Alex Kirillov > Signed-off-by: Eric Blake > --- > qapi/net.json | 14 +------------- > include/net/net.h | 1 - > monitor/misc.c | 2 -- > net/net.c | 6 +++--- > 4 files changed, 4 insertions(+), 19 deletions(-) > > diff --git a/qapi/net.json b/qapi/net.json > index 1cb9a7d782b4..cebb1b52e3b1 100644 > --- a/qapi/net.json > +++ b/qapi/net.json > @@ -39,18 +39,8 @@ > # > # Add a network backend. > # > -# @type: the type of network backend. Possible values are listed in > -# NetClientDriver (excluding 'none' and 'nic') > -# > -# @id: the name of the new network backend > -# > # Additional arguments depend on the type. > # > -# TODO: This command effectively bypasses QAPI completely due to its > -# "additional arguments" business. It shouldn't have been added t= o > -# the schema in this form. It should be qapified properly, or > -# replaced by a properly qapified command. > -# > # Since: 0.14.0 > # > # Returns: Nothing on success > @@ -64,9 +54,7 @@ > # <- { "return": {} } > # > ## > -{ 'command': 'netdev_add', > - 'data': {'type': 'str', 'id': 'str'}, > - 'gen': false } # so we can get the additional arguments > +{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true } > > ## > # @netdev_del: > diff --git a/include/net/net.h b/include/net/net.h > index e175ba9677dc..96e6eae8176e 100644 > --- a/include/net/net.h > +++ b/include/net/net.h > @@ -203,7 +203,6 @@ void net_cleanup(void); > void hmp_host_net_add(Monitor *mon, const QDict *qdict); > void hmp_host_net_remove(Monitor *mon, const QDict *qdict); > void netdev_add(QemuOpts *opts, Error **errp); > -void qmp_netdev_add(QDict *qdict, QObject **ret, Error **errp); > > int net_hub_id_for_client(NetClientState *nc, int *id); > NetClientState *net_hub_port_find(int hub_id); > diff --git a/monitor/misc.c b/monitor/misc.c > index c3bc34c099dd..41a86e7012a1 100644 > --- a/monitor/misc.c > +++ b/monitor/misc.c > @@ -247,8 +247,6 @@ static void monitor_init_qmp_commands(void) > qmp_query_qmp_schema, QCO_ALLOW_PRECONFIG); > qmp_register_command(&qmp_commands, "device_add", qmp_device_add, > QCO_NO_OPTIONS); > - qmp_register_command(&qmp_commands, "netdev_add", qmp_netdev_add, > - QCO_NO_OPTIONS); > qmp_register_command(&qmp_commands, "object-add", qmp_object_add, > QCO_NO_OPTIONS); > > diff --git a/net/net.c b/net/net.c > index 9e93c3f8a1e2..a2065aabede2 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -1170,7 +1170,7 @@ void netdev_add(QemuOpts *opts, Error **errp) > net_client_init(opts, true, errp); > } > > -void qmp_netdev_add(QDict *qdict, QObject **ret, Error **errp) > +void qmp_netdev_add(Netdev *netdev, Error **errp) > { > Error *local_err =3D NULL; > QemuOptsList *opts_list; > @@ -1181,12 +1181,12 @@ void qmp_netdev_add(QDict *qdict, QObject **ret, = Error **errp) > goto out; > } > > - opts =3D qemu_opts_from_qdict(opts_list, qdict, &local_err); > + opts =3D qemu_opts_create(opts_list, netdev->id, 1, &local_err); As oyu explain in your commit message, we still create a QemuOpts with the same ID, but no other parameters, because qmp_netdev_del() needs it. I show it below. > if (local_err) { > goto out; > } > > - netdev_add(opts, &local_err); > + net_client_init1(netdev, true, &local_err); > if (local_err) { > qemu_opts_del(opts); > goto out; } out: error_propagate(errp, local_err); } void qmp_netdev_del(const char *id, Error **errp) { NetClientState *nc; QemuOpts *opts; nc =3D qemu_find_netdev(id); if (!nc) { error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, "Device '%s' not found", id); return; } opts =3D qemu_opts_find(qemu_find_opts_err("netdev", NULL), id); ---> if (!opts) { error_setg(errp, "Device '%s' is not a netdev", id); return; } qemu_del_net_client(nc); qemu_opts_del(opts); } We better check all other uses of option group "netdev".