From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: linmiaohe <linmiaohe@huawei.com>
Cc: "pbonzini\@redhat.com" <pbonzini@redhat.com>,
"rkrcmar\@redhat.com" <rkrcmar@redhat.com>,
"sean.j.christopherson\@intel.com"
<sean.j.christopherson@intel.com>,
"wanpengli\@tencent.com" <wanpengli@tencent.com>,
"jmattson\@google.com" <jmattson@google.com>,
"joro\@8bytes.org" <joro@8bytes.org>,
"tglx\@linutronix.de" <tglx@linutronix.de>,
"mingo\@redhat.com" <mingo@redhat.com>,
"bp\@alien8.de" <bp@alien8.de>, "hpa\@zytor.com" <hpa@zytor.com>,
"kvm\@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86\@kernel.org" <x86@kernel.org>
Subject: Re: [Question] some questions about vmx
Date: Thu, 06 Feb 2020 13:00:02 +0100 [thread overview]
Message-ID: <877e10gc3h.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <70c0804949234ad8b6c1834cc9b109ca@huawei.com>
linmiaohe <linmiaohe@huawei.com> writes:
> About nWMX.
> When nested_vmx_handle_enlightened_vmptrld() return 0, it do not inject any exception or set rflags to
> Indicate VMLAUNCH instruction failed and skip this instruction. This would cause nested_vmx_run()
> return 1 and resume guest and retry this instruction. When the error causing nested_vmx_handle_enlightened_vmptrld()
> failed can't be handled, would deadloop ouucr ?
Yes, it seems it can.
nested_vmx_handle_enlightened_vmptrld() has two possible places where it
can fail:
kvm_vcpu_map() -- meaning that the guest passed some invalid GPA.
revision id check -- meaning that the supplied eVMCS is
unsupported/garbage.
I think the right behavior would be to nested_vmx_failInvalid() in both
these cases. We can also check what genuing Hyper-V does.
--
Vitaly
next prev parent reply other threads:[~2020-02-06 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 7:11 [Question] some questions about vmx linmiaohe
2020-02-06 12:00 ` Vitaly Kuznetsov [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-07 7:10 linmiaohe
2020-02-07 9:08 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e10gc3h.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.