From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: igt-dev <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests
Date: Fri, 31 Jan 2020 21:42:50 -0800 [thread overview]
Message-ID: <877e166exx.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200131173109.12527-2-ramalingam.c@intel.com>
On Fri, 31 Jan 2020 09:31:01 -0800, Ramalingam C wrote:
>
> In the absence of the mappable aperture, skip GTT and
> fence specific tests.
>
> v2:
> requirement check is moved to subtest start [Zbigniew]
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> tests/prime_vgem.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
> index 3bdb23007d56..c483cbe722ea 100644
> --- a/tests/prime_vgem.c
> +++ b/tests/prime_vgem.c
> @@ -846,14 +846,18 @@ igt_main
> igt_subtest("basic-write")
> test_write(vgem, i915);
>
> - igt_subtest("basic-gtt")
> + igt_subtest("basic-gtt") {
> + gem_require_mappable_ggtt(i915);
> test_gtt(vgem, i915);
> + }
To me seems no reason to skip this. We could either unconditionally use
device_coherent() or use mmap_gtt() if gtt is available else
device_coherent()? Though probably the test would need to be renamed as
test_device_coherent()?
>
> igt_subtest("shrink")
> test_shrink(vgem, i915);
>
> - igt_subtest("coherency-gtt")
> + igt_subtest("coherency-gtt") {
> + gem_require_mappable_ggtt(i915);
> test_gtt_interleaved(vgem, i915);
> + }
Probably similar situation here, though with WC instead of GTT the test
should always pass?
>
> for (e = intel_execution_engines; e->name; e++) {
> igt_subtest_f("%ssync-%s",
> @@ -902,8 +906,10 @@ igt_main
>
> igt_subtest("basic-fence-read")
> test_fence_read(i915, vgem);
> - igt_subtest("basic-fence-mmap")
> + igt_subtest("basic-fence-mmap") {
> + gem_require_mappable_ggtt(i915);
> test_fence_mmap(i915, vgem);
> + }
Once again, just use device_coherent()?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-01 5:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 17:31 [igt-dev] [PATCH i-g-t 0/9] Handling mmap_gtt Ramalingam C
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests Ramalingam C
2020-02-01 5:42 ` Dixit, Ashutosh [this message]
2020-02-03 9:19 ` Janusz Krzysztofik
2020-02-03 9:28 ` Janusz Krzysztofik
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported Ramalingam C
2020-02-01 5:55 ` Dixit, Ashutosh
2020-02-04 5:55 ` Dixit, Ashutosh
2020-02-04 6:00 ` Ramalingam C
2020-02-04 6:15 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 3/9] tests/prime_mmap_coherency: use device coherent mapping instead of mmap_gtt Ramalingam C
2020-02-01 6:27 ` Dixit, Ashutosh
2020-02-02 18:24 ` Ramalingam C
2020-02-04 6:14 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 4/9] tests/prime_mmap: " Ramalingam C
2020-02-01 6:57 ` Dixit, Ashutosh
2020-02-02 18:28 ` Ramalingam C
2020-02-04 6:29 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture Ramalingam C
2020-02-04 6:38 ` Dixit, Ashutosh
2020-02-09 0:41 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_available_modes_crc: Skip test if mappable aperture not supported Ramalingam C
2020-02-04 6:49 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 7/9] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt Ramalingam C
2020-02-05 0:16 ` Dixit, Ashutosh
2020-02-07 12:59 ` Ramalingam C
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 8/9] tests/i915_suspend: skip fence related tests, if no mmap_gtt Ramalingam C
2020-02-05 2:06 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 9/9] tests/gem_tiling_max_stride: Skip if set tiling is not supported Ramalingam C
2020-02-05 0:43 ` Antonio Argenziano
2020-02-05 1:29 ` Dixit, Ashutosh
2020-01-31 18:45 ` [igt-dev] ✓ Fi.CI.BAT: success for Handling mmap_gtt Patchwork
2020-02-04 12:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e166exx.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.