From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Include the debugfs params header for its own definition
Date: Fri, 17 Jan 2020 13:05:45 +0200 [thread overview]
Message-ID: <877e1qibqu.fsf@intel.com> (raw)
In-Reply-To: <20200117102145.2948244-1-chris@chris-wilson.co.uk>
On Fri, 17 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> drivers/gpu/drm/i915/i915_debugfs_params.c:228:15: warning: symbol 'i915_debugfs_params' was not declared. Should it be static?
> drivers/gpu/drm/i915/i915_debugfs_params.c:228:16: error: no previous prototype for ‘i915_debugfs_params’ [-Werror=missing-prototypes]
> 228 | struct dentry *i915_debugfs_params(struct drm_i915_private *i915)
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@intel.com>
/o\
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Fixes: c43c5a8818d4 ("drm/i915/params: add i915 parameters to debugfs")
> ---
> drivers/gpu/drm/i915/i915_debugfs_params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c b/drivers/gpu/drm/i915/i915_debugfs_params.c
> index 12cbdbdf4d80..62b2c5f0495d 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs_params.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs_params.c
> @@ -5,6 +5,7 @@
>
> #include <linux/kernel.h>
>
> +#include "i915_debugfs_params.h"
> #include "i915_drv.h"
> #include "i915_params.h"
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-17 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 10:21 [Intel-gfx] [PATCH] drm/i915: Include the debugfs params header for its own definition Chris Wilson
2020-01-17 11:05 ` Jani Nikula [this message]
2020-01-17 12:28 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-01-17 12:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-17 12:54 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-20 13:06 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e1qibqu.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.