From: Jani Nikula <jani.nikula@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 04/10] drm/i915: add display engine uncore helpers
Date: Wed, 11 Dec 2019 08:46:47 +0200 [thread overview]
Message-ID: <877e33l5pk.fsf@intel.com> (raw)
In-Reply-To: <157598608411.9435.15464881874218047518@jlahtine-desk.ger.corp.intel.com>
On Tue, 10 Dec 2019, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2019-12-02 18:00:52)
>> Add convenience helpers for the most common uncore operations with
>> struct drm_i915_private * as context rather than struct intel_uncore *.
>>
>> The goal is to replace all instances of I915_READ(),
>> I915_POSTING_READ(), I915_WRITE(), I915_READ_FW(), and I915_WRITE_FW()
>> in display/ with these, to finally be able to get rid of the implicit
>> dev_priv local parameter use.
>>
>> The idea is that any non-u32 reads or writes are special enough that
>> they can use the intel_uncore_* functions directly.
>>
>> v2:
>> - rename the file intel_de.h
>> - move intel_de_wait_for_* there too
>> - also add de fw helpers
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_de.h | 72 +++++++++++++++++++
>> .../drm/i915/display/intel_display_types.h | 1 +
>> drivers/gpu/drm/i915/i915_drv.h | 14 ----
>> 3 files changed, 73 insertions(+), 14 deletions(-)
>> create mode 100644 drivers/gpu/drm/i915/display/intel_de.h
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
>> new file mode 100644
>> index 000000000000..00da10bf35f5
>> --- /dev/null
>> +++ b/drivers/gpu/drm/i915/display/intel_de.h
>> @@ -0,0 +1,72 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2019 Intel Corporation
>> + */
>> +
>> +#ifndef __INTEL_DE_H__
>> +#define __INTEL_DE_H__
>> +
>> +#include "i915_drv.h"
>> +#include "i915_reg.h"
>> +#include "intel_uncore.h"
>> +
>> +static inline u32
>> +intel_de_read(struct drm_i915_private *i915, i915_reg_t reg)
>
> Is the plan to have struct intel_de inside i915 and then have that as
> the prime parameter going forward?
No. The plan is to keep i915 as the prime parameter for display.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-11 6:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 16:00 [PATCH 00/10] drm/i915: add display uncore helpers Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:00 ` [PATCH 01/10] drm/i915/gvt: use intel uncore functions for forcewake register access Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:06 ` Chris Wilson
2019-12-02 16:06 ` [Intel-gfx] " Chris Wilson
2020-01-17 14:36 ` Jani Nikula
2020-01-17 14:47 ` Chris Wilson
2020-01-17 14:50 ` Chris Wilson
2019-12-02 16:00 ` [PATCH 02/10] drm/i915/debugfs: " Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:14 ` Chris Wilson
2019-12-02 16:14 ` [Intel-gfx] " Chris Wilson
2019-12-02 16:00 ` [PATCH 03/10] drm/i915/dmc: " Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:00 ` [PATCH 04/10] drm/i915: add display engine uncore helpers Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-10 13:54 ` Joonas Lahtinen
2019-12-11 6:46 ` Jani Nikula [this message]
2019-12-02 16:00 ` [PATCH 05/10] drm/i915/display: use intel de functions for forcewake register access Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:00 ` [PATCH 06/10] drm/i915/irq: " Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:00 ` [PATCH 07/10] drm/i915/gmbus: " Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:00 ` [PATCH 08/10] drm/i915/sprite: " Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:00 ` [PATCH 09/10] drm/i915/pm: " Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 16:00 ` [PATCH 10/10] drm/i915: remove I915_READ_FW() and I915_WRITE_FW() macros Jani Nikula
2019-12-02 16:00 ` [Intel-gfx] " Jani Nikula
2019-12-02 17:29 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display uncore helpers Patchwork
2019-12-02 17:29 ` [Intel-gfx] " Patchwork
2019-12-02 18:00 ` ✓ Fi.CI.BAT: success " Patchwork
2019-12-02 18:00 ` [Intel-gfx] " Patchwork
2019-12-02 21:58 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-12-02 21:58 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e33l5pk.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.