From: Kalle Valo <kvalo@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: <yhchuang@realtek.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rtw88: fix GENMASK_ULL for u64
Date: Fri, 25 Oct 2019 10:41:00 +0300 [thread overview]
Message-ID: <877e4te0hf.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <87ftjie9t3.fsf@tynnyri.adurom.net> (Kalle Valo's message of "Thu, 24 Oct 2019 13:07:20 +0300")
Kalle Valo <kvalo@codeaurora.org> writes:
> <yhchuang@realtek.com> writes:
>
>> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>>
>> This fixes compile warning:
>>
>> In file included from include/linux/bitops.h:5:0,
>> from include/linux/kernel.h:12,
>> from include/asm-generic/bug.h:19,
>> from arch/mips/include/asm/bug.h:42,
>> from include/linux/bug.h:5,
>> from include/net/mac80211.h:16,
>> from drivers/net/wireless/realtek/rtw88/main.h:8,
>> from drivers/net/wireless/realtek/rtw88/main.c:5:
>> drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask':
>> include/linux/bits.h:23:11: warning: right shift count is negative
>> [-Wshift-count-negative]
>> (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
>> ^
>> drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK'
>> u64 cfg_mask = GENMASK(63, 0);
>> ^~~~~~~
>>
>> Fixes: f39e9bd49a3d ("rtw88: add set_bitrate_mask support")
>> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> I'll add:
>
> Reported-by: kbuild test robot <lkp@intel.com>
Oh nice, patchwork automatically added the tag from my email above and I
didn't have to do anything :)
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-25 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 9:19 [PATCH] rtw88: fix GENMASK_ULL for u64 yhchuang
2019-10-24 10:07 ` Kalle Valo
2019-10-24 10:13 ` Tony Chuang
2019-10-25 7:41 ` Kalle Valo [this message]
2019-10-25 7:39 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e4te0hf.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.