Re: [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen

[Juan Quintela <quintela@redhat.com>]

Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Tue, Aug 20, 2019 at 10:24:55AM +0200, Juan Quintela wrote:
>> Current parameter was always one.  We continue with that value for now
>> in all callers.
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>

>> @@ -309,7 +311,8 @@ static int inet_listen_saddr(InetSocketAddress *saddr,
>>                      goto listen_failed;
>>                  }
>>              } else {
>> -                if (!listen(slisten, 1)) {
>> +                trace_inet_listen_saddr(num);
>
> It is a bit odd to only have the trace event for inet sockets. I'd
> prefer it in the caller for all sockets, with just "socket_listen"
> name.

Ok. will change.

This is the one that I needed, I just changed an error_report() to a
trace O:-)