From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF1CCC433FF for ; Tue, 6 Aug 2019 05:49:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5F8D206A2 for ; Tue, 6 Aug 2019 05:49:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5F8D206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1husLW-0000md-OM for qemu-devel@archiver.kernel.org; Tue, 06 Aug 2019 01:49:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53126) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1husL3-0000M1-NB for qemu-devel@nongnu.org; Tue, 06 Aug 2019 01:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1husL2-0003iC-PZ for qemu-devel@nongnu.org; Tue, 06 Aug 2019 01:48:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45584) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1husL2-0003i2-KJ for qemu-devel@nongnu.org; Tue, 06 Aug 2019 01:48:48 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CAB808DA34 for ; Tue, 6 Aug 2019 05:48:47 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 386FC10016E8; Tue, 6 Aug 2019 05:48:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A94041138619; Tue, 6 Aug 2019 07:48:43 +0200 (CEST) From: Markus Armbruster To: Gerd Hoffmann References: <1565042940-8837-1-git-send-email-pbonzini@redhat.com> <87imrasv8m.fsf@dusky.pond.sub.org> Date: Tue, 06 Aug 2019 07:48:43 +0200 In-Reply-To: <87imrasv8m.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Tue, 06 Aug 2019 07:44:57 +0200") Message-ID: <877e7qsv2c.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 06 Aug 2019 05:48:47 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] Makefile: remove unused variables X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > Paolo Bonzini writes: > >> Signed-off-by: Paolo Bonzini >> --- >> Makefile | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 73fbba0..7b0e2f4 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -429,10 +429,6 @@ dummy := $(call unnest-vars,, \ >> io-obj-y \ >> common-obj-y \ >> common-obj-m \ >> - ui-obj-y \ >> - ui-obj-m \ >> - audio-obj-y \ >> - audio-obj-m \ >> trace-obj-y) >> >> include $(SRC_PATH)/tests/Makefile.include > > Reviewed-by: Markus Armbruster Hmm... the two go back to commit 08a05b379ac56430cbb748882ff1b48dc9fe8729 Author: Gerd Hoffmann Date: Tue Mar 6 08:40:49 2018 +0100 build: enable audio modules Add audio/ to common-obj-m variable. Also run both audio and ui variables through unnest-vars. This avoids sdl.mo (exists in both audio/ and ui/) name clashes. Signed-off-by: Gerd Hoffmann Message-id: 20180306074053.22856-4-kraxel@redhat.com Gerd, anything funny going on here, or is Paolo's patch okay?