All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <nathanl@linux.ibm.com>
To: Juliet Kim <julietk@linux.vnet.ibm.com>
Cc: ego@linux.vnet.ibm.com, mmc <mmc@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/rtas: retry when cpu offline races with suspend/migration
Date: Tue, 25 Jun 2019 13:51:40 -0500	[thread overview]
Message-ID: <877e99ts5f.fsf@linux.ibm.com> (raw)
In-Reply-To: <5a825cec-234a-ee8a-a776-8ba305f9cb26@linux.vnet.ibm.com>

Juliet Kim <julietk@linux.vnet.ibm.com> writes:

> There's some concern this could retry forever, resulting in live lock.

First of all the system will make progress in other areas even if there
are repeated retries; we're not indefinitely holding locks or anything
like that.

Second, Linux checks the H_VASI_STATE result on every retry. If the
platform wants to terminate the migration (say, if it imposes a
timeout), Linux will abandon it when H_VASI_STATE fails to return
H_VASI_SUSPENDING. And it seems incorrect to bail out before that
happens, absent hard errors on the Linux side such as allocation
failures.


  reply	other threads:[~2019-06-25 18:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  6:05 [PATCH] powerpc/rtas: retry when cpu offline races with suspend/migration Nathan Lynch
2019-06-24 16:52 ` mmc
2019-06-24 17:23   ` Nathan Lynch
2019-06-25  1:02     ` Juliet Kim
2019-06-25 18:51       ` Nathan Lynch [this message]
2019-06-26 21:40         ` Juliet Kim
2019-06-27  5:01           ` Michael Ellerman
2019-06-27 21:59             ` Juliet Kim
2019-07-01 22:12 ` Nathan Lynch
2019-07-02  2:16   ` Michael Ellerman
2019-07-03 14:27 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e99ts5f.fsf@linux.ibm.com \
    --to=nathanl@linux.ibm.com \
    --cc=ego@linux.vnet.ibm.com \
    --cc=julietk@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mmc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.