From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Git <git@vger.kernel.org>, CB Bailey <cb@hashpling.org>
Subject: Re: Deadname rewriting
Date: Fri, 21 Jun 2019 23:34:06 +0200 [thread overview]
Message-ID: <877e9e8vxt.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CABURp0p2Z=qD2gF59AHBLaRn9iiTOeJyNXYsQDNk-_KEC4uSGg@mail.gmail.com>
On Fri, Jun 21 2019, Phil Hord wrote:
> On Sat, Jun 15, 2019 at 1:19 AM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>> On Sat, Jun 15 2019, Phil Hord wrote:
>>
>> > At $work we have a long time employee who has changed their name from
>> > Alice to Bob. Bob doesn't want anyone to call him "Alice" anymore and
>> > is prone to be offended if they do. This is called "deadnaming".
> ...
>> What should be done is to extend the .mailmap support to other
>> cases. I.e. make tools like blame, shortlog etc. show the equivalent of
>> %aN and %aE by default.
>
> It seems that shortlog and blame do use %aE and %aN by default. Even
> log does. It is only because I didn't know about %aN 10 years ago
> that my custom log format does not.
>
> It's a pity the format author has the option to ignore the mailmap. I
> think it's a choice commonly made by mistake rather than intention. I
> wonder if anyone would mind a forced-override config. Maybe a force
> flag in the .mailmap file itself.
>
> <cto@company.xx> <cto@coompany.xx>
> Other Author <other@author.xx> nick2 <bugs@company.xx>
> Alice Doe <alice.doe@myco.com> <bob.doe@myco.co> --force
Yeah I'm sure a lot of people who do %an really mean %aN, but blanket
forcing it seems a recipe for breakage since "log" and friends are also
used as plumbing where you really mean "what does it say in this commit
object".
E.g. I use %an intentionally for a company-internal tool to map an Alice
to Bob for reporting purposes, which presumably you'd also want.
But yeah, there'll be other uses that didn't intend it. I think probably
the best way forward is to just make git use %aN by default in
porcelain, and outside users presumably would get reports about such
issues eventually in cases like this where someone cared.
>> This topic was discussed at the last git contributor summit (brought up
>> by CB Bailey) resulting in this patch, which I see didn't make it in &
>> needs to be resurrected again:
>> https://public-inbox.org/git/20181212171052.13415-1-cb@hashpling.org/
>
> Thanks for the link.
>
> I didn't know about config options for mailmap.file and log.mailmap
> before. These do make this option much more useful, especially when we
> can insert default settings for them into /etc/gitconfig across the
> company.
Right, and to the extent that we don't --use-mailmap by default I think
that's mainly because nobody's cared enough to advocate for it. I think
it would be a sensible default.
next prev parent reply other threads:[~2019-06-21 21:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 1:54 Deadname rewriting Phil Hord
2019-06-15 7:27 ` Andreas Schwab
2019-06-15 8:19 ` Ævar Arnfjörð Bjarmason
2019-06-17 21:21 ` Philip Oakley
2019-06-17 22:33 ` Ævar Arnfjörð Bjarmason
2019-06-21 21:12 ` Phil Hord
2019-06-21 21:34 ` Ævar Arnfjörð Bjarmason [this message]
2019-06-21 22:16 ` CB Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e9e8vxt.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=cb@hashpling.org \
--cc=git@vger.kernel.org \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.