From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Wed, 19 Jun 2019 15:34:56 +0000 Subject: Re: [PATCH] drm: self_refresh: Fix a reversed condition in drm_self_refresh_helper_cleanup() Message-Id: <877e9hlhb3.fsf@intel.com> List-Id: References: <20190619100141.GA28596@mwanda> <20190619150339.GF25413@art_vandelay> In-Reply-To: <20190619150339.GF25413@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Paul , Dan Carpenter Cc: Maxime Ripard , David Airlie , kernel-janitors@vger.kernel.org, Sean Paul , dri-devel@lists.freedesktop.org On Wed, 19 Jun 2019, Sean Paul wrote: > On Wed, Jun 19, 2019 at 01:01:41PM +0300, Dan Carpenter wrote: >> This test is flipped around so it either leads to a memory leak or a >> NULL dereference. >> >> Fixes: 1452c25b0e60 ("drm: Add helpers to kick off self refresh mode in drivers") >> Signed-off-by: Dan Carpenter > > Thanks for the patch and your bug report! I've applied this to -misc-next and > will dig into the bug report shortly. > >> --- >> I'm not totally sure what the prefered patch prefix for this code. One >> thing that would help is when we're adding new files we should specify >> the prefix that they're going to use: >> >> - drm: Add helpers to kick off self refresh mode in drivers >> + drm: refresh mode: Add helpers to kick off self refresh mode in drivers >> >> It's a small thing and email always sounds whiny but I'm sending this >> suggestion to everyone today so... > > There's no hard rule. For drivers we use drm/, and for core people > use drm or drm/. checkpatch.pl should have a git log popularity contest based check for the prefix. For new files, first come first served. ;) BR, Jani. > >> >> drivers/gpu/drm/drm_self_refresh_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_self_refresh_helper.c b/drivers/gpu/drm/drm_self_refresh_helper.c >> index 2b3daaf77841..e0d2ad1f070c 100644 >> --- a/drivers/gpu/drm/drm_self_refresh_helper.c >> +++ b/drivers/gpu/drm/drm_self_refresh_helper.c >> @@ -205,7 +205,7 @@ void drm_self_refresh_helper_cleanup(struct drm_crtc *crtc) >> struct drm_self_refresh_data *sr_data = crtc->self_refresh_data; >> >> /* Helper is already uninitialized */ >> - if (sr_data) >> + if (!sr_data) >> return; >> >> crtc->self_refresh_data = NULL; >> -- >> 2.20.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: self_refresh: Fix a reversed condition in drm_self_refresh_helper_cleanup() Date: Wed, 19 Jun 2019 18:34:56 +0300 Message-ID: <877e9hlhb3.fsf@intel.com> References: <20190619100141.GA28596@mwanda> <20190619150339.GF25413@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id A16816E3D6 for ; Wed, 19 Jun 2019 15:33:30 +0000 (UTC) In-Reply-To: <20190619150339.GF25413@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul , Dan Carpenter Cc: Maxime Ripard , David Airlie , kernel-janitors@vger.kernel.org, Sean Paul , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAxOSBKdW4gMjAxOSwgU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+IHdyb3RlOgo+ IE9uIFdlZCwgSnVuIDE5LCAyMDE5IGF0IDAxOjAxOjQxUE0gKzAzMDAsIERhbiBDYXJwZW50ZXIg d3JvdGU6Cj4+IFRoaXMgdGVzdCBpcyBmbGlwcGVkIGFyb3VuZCBzbyBpdCBlaXRoZXIgbGVhZHMg dG8gYSBtZW1vcnkgbGVhayBvciBhCj4+IE5VTEwgZGVyZWZlcmVuY2UuCj4+IAo+PiBGaXhlczog MTQ1MmMyNWIwZTYwICgiZHJtOiBBZGQgaGVscGVycyB0byBraWNrIG9mZiBzZWxmIHJlZnJlc2gg bW9kZSBpbiBkcml2ZXJzIikKPj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNh cnBlbnRlckBvcmFjbGUuY29tPgo+Cj4gVGhhbmtzIGZvciB0aGUgcGF0Y2ggYW5kIHlvdXIgYnVn IHJlcG9ydCEgSSd2ZSBhcHBsaWVkIHRoaXMgdG8gLW1pc2MtbmV4dCBhbmQKPiB3aWxsIGRpZyBp bnRvIHRoZSBidWcgcmVwb3J0IHNob3J0bHkuCj4KPj4gLS0tCj4+IEknbSBub3QgdG90YWxseSBz dXJlIHdoYXQgdGhlIHByZWZlcmVkIHBhdGNoIHByZWZpeCBmb3IgdGhpcyBjb2RlLiAgT25lCj4+ IHRoaW5nIHRoYXQgd291bGQgaGVscCBpcyB3aGVuIHdlJ3JlIGFkZGluZyBuZXcgZmlsZXMgd2Ug c2hvdWxkIHNwZWNpZnkKPj4gdGhlIHByZWZpeCB0aGF0IHRoZXkncmUgZ29pbmcgdG8gdXNlOgo+ PiAKPj4gLSBkcm06IEFkZCBoZWxwZXJzIHRvIGtpY2sgb2ZmIHNlbGYgcmVmcmVzaCBtb2RlIGlu IGRyaXZlcnMKPj4gKyBkcm06IHJlZnJlc2ggbW9kZTogQWRkIGhlbHBlcnMgdG8ga2ljayBvZmYg c2VsZiByZWZyZXNoIG1vZGUgaW4gZHJpdmVycwo+PiAKPj4gSXQncyBhIHNtYWxsIHRoaW5nIGFu ZCBlbWFpbCBhbHdheXMgc291bmRzIHdoaW55IGJ1dCBJJ20gc2VuZGluZyB0aGlzCj4+IHN1Z2dl c3Rpb24gdG8gZXZlcnlvbmUgdG9kYXkgc28uLi4KPgo+IFRoZXJlJ3Mgbm8gaGFyZCBydWxlLiBG b3IgZHJpdmVycyB3ZSB1c2UgZHJtLzxkcml2ZXI+LCBhbmQgZm9yIGNvcmUgcGVvcGxlCj4gdXNl IGRybSBvciBkcm0vPGZpbGU+LgoKY2hlY2twYXRjaC5wbCBzaG91bGQgaGF2ZSBhIGdpdCBsb2cg cG9wdWxhcml0eSBjb250ZXN0IGJhc2VkIGNoZWNrIGZvcgp0aGUgcHJlZml4LiBGb3IgbmV3IGZp bGVzLCBmaXJzdCBjb21lIGZpcnN0IHNlcnZlZC4gOykKCkJSLApKYW5pLgoKCj4KPj4gCj4+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX3NlbGZfcmVmcmVzaF9oZWxwZXIuYyB8IDIgKy0KPj4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+PiAKPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fc2VsZl9yZWZyZXNoX2hlbHBlci5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9zZWxmX3JlZnJlc2hfaGVscGVyLmMKPj4gaW5kZXggMmIzZGFhZjc3ODQxLi5l MGQyYWQxZjA3MGMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fc2VsZl9yZWZy ZXNoX2hlbHBlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc2VsZl9yZWZyZXNoX2hl bHBlci5jCj4+IEBAIC0yMDUsNyArMjA1LDcgQEAgdm9pZCBkcm1fc2VsZl9yZWZyZXNoX2hlbHBl cl9jbGVhbnVwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4gIAlzdHJ1Y3QgZHJtX3NlbGZfcmVm cmVzaF9kYXRhICpzcl9kYXRhID0gY3J0Yy0+c2VsZl9yZWZyZXNoX2RhdGE7Cj4+ICAKPj4gIAkv KiBIZWxwZXIgaXMgYWxyZWFkeSB1bmluaXRpYWxpemVkICovCj4+IC0JaWYgKHNyX2RhdGEpCj4+ ICsJaWYgKCFzcl9kYXRhKQo+PiAgCQlyZXR1cm47Cj4+ICAKPj4gIAljcnRjLT5zZWxmX3JlZnJl c2hfZGF0YSA9IE5VTEw7Cj4+IC0tIAo+PiAyLjIwLjEKPj4gCj4+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK Pj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkphbmkgTmlrdWxhLCBJ bnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs