From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2901CC31E57 for ; Mon, 17 Jun 2019 11:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EED2C2084D for ; Mon, 17 Jun 2019 11:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727987AbfFQLR7 convert rfc822-to-8bit (ORCPT ); Mon, 17 Jun 2019 07:17:59 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:33795 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727631AbfFQLR7 (ORCPT ); Mon, 17 Jun 2019 07:17:59 -0400 Received: by mail-ed1-f66.google.com with SMTP id s49so15662838edb.1 for ; Mon, 17 Jun 2019 04:17:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=V6M79Bvlfn3Y/3r6Oi9ctX8EPoRwXSGOlJOMMHDPmWM=; b=lhaasLpPqfb4oCpMouFWTWXiOKKJNKKppLvTp/QEMgb0VqRZS/4h6iigFd8UubMqce qODCzc+jq4WdekrXklz4o7eH1cHiDwWvrTiVheBbgT/SE67IPWYNcJfqMI3RJduJGYvJ sII27io8bS36UHYn4FZrjzcBdHM7hy7Oc0xoxQD0OF0dx4VS/dV2uJ+Z1rBL5E7ta/L6 Xwb5d7IRvlyMhNO+33f9jP4lkaz3MngqmmIx1p9B1Wh7HjQ/r9OmjX4M6Yk6p8Nj56j1 0LCMmxE7oDhAaESgNg/yyubMSudoGflaNoS2OKfdYftBtPZFzPPdWH01zxZJQ/VBY3ni fHaQ== X-Gm-Message-State: APjAAAVGq+9zJOhCvTARFGsEgY9jqeTRyIKX+vRUnSbUpbnF2qiUYBm8 3nmN54NXghJAn0kBAD7wSgROig== X-Google-Smtp-Source: APXvYqybOnw23k91/01uyTY1erdQuXnt4RumEV5SJQxuntvKl1Idy+2CKVinXUELC+WWGYW2kTgDhg== X-Received: by 2002:a17:906:6a45:: with SMTP id n5mr42843163ejs.61.1560770277849; Mon, 17 Jun 2019 04:17:57 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id f3sm2149878ejo.90.2019.06.17.04.17.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 17 Jun 2019 04:17:57 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id BEA4C1804AF; Mon, 17 Jun 2019 13:17:56 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Anton Protopopov , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , "David S. Miller" , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Anton Protopopov Subject: Re: [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup In-Reply-To: <20190615225348.2539-1-a.s.protopopov@gmail.com> References: <20190615225348.2539-1-a.s.protopopov@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 17 Jun 2019 13:17:56 +0200 Message-ID: <877e9ka2aj.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Anton Protopopov writes: > The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED > when forwarding is disabled for the input device. However instead of checking > if forwarding is enabled on the input device, it checked the global > net->ipv6.devconf_all->forwarding flag. Change it to behave as expected. > > Signed-off-by: Anton Protopopov Thanks! Acked-by: Toke Høiland-Jørgensen