From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309B5C282DA for ; Wed, 17 Apr 2019 12:08:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3BFF206BA for ; Wed, 17 Apr 2019 12:08:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="azm72sGO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3BFF206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VJOJo0QpaYpQBHw/Cv9+M8egLv5Fm1Vf3jkswUX/2ww=; b=azm72sGOJdDs3D CL5I+2icNvymLLITM7yeR3WczAg6uA+Dlq8rXx58wu+whcNF+MO1PJLFFnq7A11+H2MdQPhjfzTBG gUDHoLMZM1HnX8m8WYG3c0/lqwWe+TjOOYvdNHw65y3Y1nrPBO9bkSjID1LS9NXvnWeVC26WNEt2d kvMOkl3LBbv9KiKhNA3E1Uv8wotWPohMGcC0vcYZEB5lqCbhEXHJ1oyq0QUGgGknxyIiq3O2PM4Yp NFuIVNZ50ayImBfRQSJl3niB1knV5dIfH4U9DlLOtISKcwrYCLqL5Nxl28TGsPYy1FqUjmycZU91V 8bE2NV3ZJ1sIf0ggw11A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGjMB-0008PF-6e; Wed, 17 Apr 2019 12:08:03 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGjM7-0008OW-5E for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 12:08:00 +0000 X-Originating-IP: 109.212.207.226 Received: from localhost (alyon-652-1-176-226.w109-212.abo.wanadoo.fr [109.212.207.226]) (Authenticated sender: gregory.clement@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BDB7EE0003; Wed, 17 Apr 2019 12:07:44 +0000 (UTC) From: Gregory CLEMENT To: Nicholas Mc Guire , Andrew Lunn Subject: Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure In-Reply-To: <20190417114228.GA20280@osadl.at> References: <1555386991-8855-1-git-send-email-hofrat@osadl.org> <20190416133957.GB29190@lunn.ch> <20190417114228.GA20280@osadl.at> Date: Wed, 17 Apr 2019 14:07:44 +0200 Message-ID: <877ebsal7z.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_050759_350993_C5CC457B X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , linux-kernel@vger.kernel.org, Russell King , Nicholas Mc Guire , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicholas, Nicholas Mc Guire writes: > On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: >> On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: >> >> > Note that this will trigger a checkpatch WARNING >> > "WARNING: Possible unnecessary 'out of memory' message" >> > but comparing the oops with an without the one-line pr_err I would >> > argue that it makes sense to include it: >> >> Hi Nicholas >> >> It might be worth adding this as a comment, so that newbies don't >> submit patches removing the pr_err() because of the checkpatch >> warning. >> > hmm... I think if we start doing that we would make quite a mess of > documentation in the kernel. Also note its a warning stating "possible > unneceessary" - so I would not see the necessity. > > At most I would include a note on this in the commit message so that > anyone checking the origin would see that this is intenttional - assuming > that people modifying code would be using git blame to locate the > origin of any code... Don't bother to send a new version I don't attempt to take this patch. As you pointed it is very unlikely that we get an error so early during the boot for a very small amount of memory. If it happened then we have serious trouble and the message provided by the BUG() call will be more than enough. Thanks, Gregory > > thx! > hofrat > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6A16C282DA for ; Wed, 17 Apr 2019 12:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 911EB206BA for ; Wed, 17 Apr 2019 12:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732066AbfDQMHu (ORCPT ); Wed, 17 Apr 2019 08:07:50 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:37531 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731508AbfDQMHt (ORCPT ); Wed, 17 Apr 2019 08:07:49 -0400 X-Originating-IP: 109.212.207.226 Received: from localhost (alyon-652-1-176-226.w109-212.abo.wanadoo.fr [109.212.207.226]) (Authenticated sender: gregory.clement@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BDB7EE0003; Wed, 17 Apr 2019 12:07:44 +0000 (UTC) From: Gregory CLEMENT To: Nicholas Mc Guire , Andrew Lunn Cc: Jason Cooper , Russell King , linux-kernel@vger.kernel.org, Nicholas Mc Guire , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure In-Reply-To: <20190417114228.GA20280@osadl.at> References: <1555386991-8855-1-git-send-email-hofrat@osadl.org> <20190416133957.GB29190@lunn.ch> <20190417114228.GA20280@osadl.at> Date: Wed, 17 Apr 2019 14:07:44 +0200 Message-ID: <877ebsal7z.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicholas, Nicholas Mc Guire writes: > On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: >> On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: >> >> > Note that this will trigger a checkpatch WARNING >> > "WARNING: Possible unnecessary 'out of memory' message" >> > but comparing the oops with an without the one-line pr_err I would >> > argue that it makes sense to include it: >> >> Hi Nicholas >> >> It might be worth adding this as a comment, so that newbies don't >> submit patches removing the pr_err() because of the checkpatch >> warning. >> > hmm... I think if we start doing that we would make quite a mess of > documentation in the kernel. Also note its a warning stating "possible > unneceessary" - so I would not see the necessity. > > At most I would include a note on this in the commit message so that > anyone checking the origin would see that this is intenttional - assuming > that people modifying code would be using git blame to locate the > origin of any code... Don't bother to send a new version I don't attempt to take this patch. As you pointed it is very unlikely that we get an error so early during the boot for a very small amount of memory. If it happened then we have serious trouble and the message provided by the BUG() call will be more than enough. Thanks, Gregory > > thx! > hofrat > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com