From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alex Henrie <alexhenrie24@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit
Date: Sun, 24 Mar 2019 19:58:41 +0100 [thread overview]
Message-ID: <877ecocd5q.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq36ncpgpe.fsf@gitster-ct.c.googlers.com>
On Sun, Mar 24 2019, Junio C Hamano wrote:
> Alex Henrie <alexhenrie24@gmail.com> writes:
>
>> Having --pretty=medium as the default almost always makes the graph too
>> difficult to follow.
>>
>> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
>> ---
>
> I too thought that "--graph" should make "--oneline" the default
> back when I originally accepted the patch series that introduced the
> "--graph" feature, but with frequent use of "--graph" myself, I
> stopped being sure that "--oneline" should be the default long time
> ago. I find that the default level of prettiness goes reasonably
> well with the "--graph" option.
>
> This would be something that needs a long transition period if
> somebody really wants to force people to adapt to it. I am not sure
> if the complication is worth it.
Aside from historical/backcompat concerns I think the current rendering
makes sense. One could also argue that e.g. --stat benefits from
--oneline.
We shouldn't have unrelated options implying one another, except stuff
like "--compact-summary" implying "--stat" (makes no sense
otherwise...).
I use --graph without --oneline more frequently than not. It gives you a
glance at how deep in a merge hierarchy some log range is, whereas with
--oneline you're most involved in the shape of that graph to the
exclusion of other things.
But maybe a built-in "git-graph" is in order? E.g. one can imagine that
once we have a dedicated command for that (similar to range-diff) you
could really focus on the UX of that, e.g. going further than --oneline
and truncating a N+ divergence as "...and N more.." or something.
next prev parent reply other threads:[~2019-03-24 18:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 4:13 [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit Alex Henrie
2019-03-23 6:03 ` Abhisek Ghosh
2019-03-24 13:03 ` [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit Junio C Hamano
2019-03-24 18:58 ` Ævar Arnfjörð Bjarmason [this message]
2019-03-24 22:37 ` Alex Henrie
2019-03-25 1:17 ` Rafael Ascensão
2019-03-25 5:10 ` Alex Henrie
2019-03-25 5:16 ` Alex Henrie
[not found] ` <CACUQV59x-W+fCz_O5EnbZhjZ1CB2NhEQbkR8dAYMizAQGQ2SFA@mail.gmail.com>
2019-03-27 17:49 ` Alex Henrie
2019-04-01 10:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ecocd5q.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.