All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Beware temporary wedging when determining -EIO
Date: Tue, 19 Feb 2019 15:47:33 +0200	[thread overview]
Message-ID: <877edvyjnu.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <155058379115.30979.2059563217754967795@skylake-alporthouse-com>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Chris Wilson (2019-02-19 13:38:55)
>> diff --git a/drivers/gpu/drm/i915/i915_reset.c b/drivers/gpu/drm/i915/i915_reset.c
>> index 4df4c674223d..3c74b828f5be 100644
>> --- a/drivers/gpu/drm/i915/i915_reset.c
>> +++ b/drivers/gpu/drm/i915/i915_reset.c
>> @@ -1334,6 +1334,21 @@ __releases(&i915->gpu_error.reset_backoff_srcu)
>>         srcu_read_unlock(&error->reset_backoff_srcu, tag);
>>  }
>>  
>> +int i915_reset_backoff(struct drm_i915_private *i915)
>
> Now this is just returning -EIO, we should rethink its name.
>
> Maybe this should be the i915_terminally_wedged() and the existing
> inline __i915_terminally_wedged(). Though less on the terminally part!

Oh yes please. Lets rethink the terminology and fix it up starting
all the way up from debugs entrypoints =)

-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-02-19 13:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19 13:31 [PATCH] drm/i915: Beware temporary wedging when determining -EIO Chris Wilson
2019-02-19 13:38 ` [PATCH v2] " Chris Wilson
2019-02-19 13:43   ` Chris Wilson
2019-02-19 13:47     ` Mika Kuoppala [this message]
2019-02-19 13:51       ` Chris Wilson
2019-02-19 14:01 ` [PATCH v3] " Chris Wilson
2019-02-19 14:11 ` ✓ Fi.CI.BAT: success for drm/i915: Beware temporary wedging when determining -EIO (rev2) Patchwork
2019-02-19 14:15 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Beware temporary wedging when determining -EIO (rev3) Patchwork
2019-02-19 14:38 ` [PATCH v4] drm/i915: Beware temporary wedging when determining -EIO Chris Wilson
2019-02-19 14:40 ` ✓ Fi.CI.BAT: success for drm/i915: Beware temporary wedging when determining -EIO (rev3) Patchwork
2019-02-19 15:14 ` [PATCH v5] drm/i915: Beware temporary wedging when determining -EIO Chris Wilson
2019-02-19 15:34 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Beware temporary wedging when determining -EIO (rev5) Patchwork
2019-02-19 16:03 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-02-19 16:06   ` Chris Wilson
2019-02-19 16:08 ` [PATCH v6] drm/i915: Beware temporary wedging when determining -EIO Chris Wilson
2019-02-19 16:18 ` [PATCH v7] " Chris Wilson
2019-02-20 14:44   ` Mika Kuoppala
2019-02-19 16:28 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Beware temporary wedging when determining -EIO (rev7) Patchwork
2019-02-19 16:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-02-19 19:21 ` ✓ Fi.CI.IGT: " Patchwork
2019-02-20 14:56 ` [CI] drm/i915: Beware temporary wedging when determining -EIO Chris Wilson
2019-02-20 15:42 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Beware temporary wedging when determining -EIO (rev8) Patchwork
2019-02-20 16:29 ` ✓ Fi.CI.BAT: success " Patchwork
2019-02-20 18:45 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877edvyjnu.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.