From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
den@openvz.org,
Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries
Date: Mon, 04 Feb 2019 14:05:58 +0100 [thread overview]
Message-ID: <877eefsnyh.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <c017dbfe-f619-b626-211a-d3bdafb451aa@redhat.com> (Eric Blake's message of "Fri, 1 Feb 2019 13:28:32 -0600")
Eric Blake <eblake@redhat.com> writes:
> On 2/1/19 1:23 PM, Markus Armbruster wrote:
>
>>>>> +# @unknown-flags: any remaining flags not recognized by the current qemu version
>>>>
>>>> Intended use cases for @unknown-flags?
>>>
>>> The qcow2 spec defines bit 2 extra_data_compatible; and also leaves the
>>> door open for future extensions that may define other bits. If a new
>>> version of qemu (or some non-qemu qcow2 creation app) creates an image
>>> with additional feature bits set, THIS version of qemu doesn't know what
>>> name to give those bits, but can still inform the user that those bits
>>> are set via this field. It will be omitted for all images created by
>>> this version of qemu.
>>
>> What would QMP clients do with this information?
>
> 'qemu-img info' is the intended QMP client; and it will print the
> unknown-flags along with everything else. In other words, we're trying
> to make qemu-img become useful for inspecting as much useful information
> as possible from an image with unknown origins. Knowing that an image
> uses bitmaps with flags unknown to THIS version of qemu is a good
> indication that you should be careful about using/altering the image
> without first upgrading qemu, as it may destroy data that some other
> product desires to utilize.
Okay. Now work that into the documentation :)
next prev parent reply other threads:[~2019-02-04 13:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 13:46 [Qemu-devel] [PATCH v11 0/3] qemu-img info lists bitmap directory entries Andrey Shinkevich
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 1/3] bdrv_query_image_info Error parameter added Andrey Shinkevich
2019-02-01 14:42 ` Vladimir Sementsov-Ogievskiy
2019-02-01 14:46 ` Daniel P. Berrangé
2019-02-01 17:13 ` Kevin Wolf
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries Andrey Shinkevich
2019-02-01 15:19 ` Vladimir Sementsov-Ogievskiy
2019-02-01 17:08 ` Eric Blake
2019-02-01 17:19 ` Kevin Wolf
2019-02-01 18:39 ` Markus Armbruster
2019-02-01 19:04 ` Eric Blake
2019-02-01 19:23 ` Markus Armbruster
2019-02-01 19:28 ` Eric Blake
2019-02-04 13:05 ` Markus Armbruster [this message]
2019-02-04 16:03 ` Vladimir Sementsov-Ogievskiy
2019-02-04 16:24 ` Eric Blake
2019-02-04 16:35 ` Vladimir Sementsov-Ogievskiy
2019-02-04 16:46 ` Vladimir Sementsov-Ogievskiy
2019-02-04 17:33 ` Eric Blake
2019-02-04 17:37 ` Eric Blake
2019-02-04 7:49 ` Vladimir Sementsov-Ogievskiy
2019-02-04 15:23 ` Eric Blake
2019-02-04 9:46 ` Kevin Wolf
2019-02-04 13:45 ` Markus Armbruster
2019-02-04 15:36 ` Vladimir Sementsov-Ogievskiy
2019-02-05 10:00 ` Kevin Wolf
2019-02-05 13:16 ` Vladimir Sementsov-Ogievskiy
2019-02-05 14:28 ` Kevin Wolf
2019-02-05 14:38 ` Eric Blake
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239 Andrey Shinkevich
2019-02-01 15:57 ` Vladimir Sementsov-Ogievskiy
2019-02-01 17:14 ` Kevin Wolf
2019-02-04 7:53 ` Vladimir Sementsov-Ogievskiy
2019-02-04 9:36 ` Kevin Wolf
2019-02-01 17:23 ` Eric Blake
2019-02-01 17:34 ` Kevin Wolf
2019-02-03 15:28 ` [Qemu-devel] [PATCH v11 0/3] qemu-img info lists bitmap directory entries no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eefsnyh.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.