From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable
 functionality
Date: Thu, 04 Oct 2018 12:01:44 +0300
Message-ID: <877eiyqe4n.fsf@intel.com>
References: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com>
 <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com>
 <20180914160655.GJ5565@intel.com> <87pnwrqxbg.fsf@intel.com>
 <87murvqx1o.fsf@intel.com> <87k1mzqmtz.fsf@intel.com>
 <57510F3E2013164E925CD03ED7512A3B7F41B7D9@BGSMSX108.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7E9B66E58C
 for <intel-gfx@lists.freedesktop.org>; Thu,  4 Oct 2018 09:01:52 +0000 (UTC)
In-Reply-To: <57510F3E2013164E925CD03ED7512A3B7F41B7D9@BGSMSX108.gar.corp.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Kulkarni, Vandita" <vandita.kulkarni@intel.com>, Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAwNCBPY3QgMjAxOCwgIkt1bGthcm5pLCBWYW5kaXRhIiA8dmFuZGl0YS5rdWxrYXJu
aUBpbnRlbC5jb20+IHdyb3RlOgo+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9t
OiBOaWt1bGEsIEphbmkKPj4gU2VudDogV2VkbmVzZGF5LCBPY3RvYmVyIDMsIDIwMTggNToxMSBQ
TQo+PiBUbzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT47
IEt1bGthcm5pLCBWYW5kaXRhCj4+IDx2YW5kaXRhLmt1bGthcm5pQGludGVsLmNvbT4KPj4gQ2M6
IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7IFphbm9uaSwgUGF1bG8gUgo+PiA8cGF1
bG8uci56YW5vbmlAaW50ZWwuY29tPgo+PiBTdWJqZWN0OiBSZTogW0ludGVsLWdmeF0gW1JGQyAx
LzNdIGRybS9pOTE1L2ljbDogUmVzdHJ1Y3R1cmUgSUNMIERQTEwgZW5hYmxlCj4+IGZ1bmN0aW9u
YWxpdHkKPj4gCj4+IE9uIFdlZCwgMDMgT2N0IDIwMTgsIEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs
YUBpbnRlbC5jb20+IHdyb3RlOgo+PiA+IE9uIFdlZCwgMDMgT2N0IDIwMTgsIEphbmkgTmlrdWxh
IDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+IHdyb3RlOgo+PiA+PiBPbiBGcmksIDE0IFNlcCAyMDE4
LCBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToK
Pj4gPj4+IE9uIEZyaSwgU2VwIDE0LCAyMDE4IGF0IDEyOjI0OjEyUE0gKzA1MzAsIFZhbmRpdGEg
S3Vsa2Fybmkgd3JvdGU6Cj4+ID4+Pj4gRnJvbTogTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1
aGFuQGludGVsLmNvbT4KPj4gPj4+Pgo+PiA+Pj4+IEluIEdlbjExLCBEUExMIDAgYW5kIDEgYXJl
IHNoYXJlZCBiZXR3ZWVuIERESSBhbmQgRFNJLgo+PiA+Pj4+IE1vc3Qgb2YgdGhlIHN0ZXBzIGZv
ciBlbmFibGluZyBEUExMIGFyZSBjb21tb24gYWNyb3NzIERESSBhbmQgRFNJLgo+PiA+Pj4+IFRo
aXMgcGF0Y2ggbWFrZXMgaWNsX2RwbGxfZW5hYmxlKCkgZ2VuZXJpYyB3aGljaCB3aWxsIGJlIHVz
ZWQgYnkKPj4gPj4+PiBhbGwgdGhlIGVuY29kZXJzLgo+PiA+Pj4+Cj4+ID4+Pj4gU2lnbmVkLW9m
Zi1ieTogTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPj4gPj4+PiBT
aWduZWQtb2ZmLWJ5OiBWYW5kaXRhIEt1bGthcm5pIDx2YW5kaXRhLmt1bGthcm5pQGludGVsLmNv
bT4KPj4gPj4+PiAtLS0KPj4gPj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMg
ICAgICB8IDEyICsrKysrKysrKysrKwo+PiA+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9kcGxsX21nci5jIHwgMTkgKystLS0tLS0tLS0tLS0tLS0tLQo+PiA+Pj4+IGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmggfCAgMiArLQo+PiA+Pj4+ICAzIGZpbGVzIGNoYW5n
ZWQsIDE1IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+PiA+Pj4+Cj4+ID4+Pj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4+ID4+Pj4gYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+PiA+Pj4+IGluZGV4IGNkMDFhMDkuLjI5NDJh
MjQgMTAwNjQ0Cj4+ID4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMK
Pj4gPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+PiA+Pj4+IEBA
IC0yODEwLDYgKzI4MTAsMTggQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX2Nsa19zZWxlY3Qoc3Ry
dWN0Cj4+IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4+ID4+Pj4gIAltdXRleF9sb2NrKCZkZXZf
cHJpdi0+ZHBsbF9sb2NrKTsKPj4gPj4+Pgo+PiA+Pj4+ICAJaWYgKElTX0lDRUxBS0UoZGV2X3By
aXYpKSB7Cj4+ID4+Pj4gKwkJZW51bSBpbnRlbF9kcGxsX2lkIGlkID0gcGxsLT5pbmZvLT5pZDsK
Pj4gPj4+PiArCQlpOTE1X3JlZ190IGVuYWJsZV9yZWcgPSBpY2xfcGxsX2lkX3RvX2VuYWJsZV9y
ZWcoaWQpOwo+PiA+Pj4+ICsKPj4gPj4+PiArCQl2YWwgPSBJOTE1X1JFQUQoZW5hYmxlX3JlZyk7
Cj4+ID4+Pj4gKwkJdmFsIHw9IFBMTF9FTkFCTEU7Cj4+ID4+Pj4gKwkJSTkxNV9XUklURShlbmFi
bGVfcmVnLCB2YWwpOwo+PiA+Pj4+ICsKPj4gPj4+PiArCQkvKiBUT0RPOiB3YWl0IHRpbWVzIG1p
c3NpbmcgZnJvbSB0aGUgc3BlYy4gKi8KPj4gPj4+PiArCQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVn
aXN0ZXIoZGV2X3ByaXYsIGVuYWJsZV9yZWcsIFBMTF9MT0NLLAo+PiA+Pj4+ICsJCQkJCSAgICBQ
TExfTE9DSywgNSkpCj4+ID4+Pj4gKwkJCURSTV9FUlJPUigiUExMICVkIG5vdCBsb2NrZWRcbiIs
IGlkKTsKPj4gPj4+PiArCj4+ID4+Pgo+PiA+Pj4gSSBkb24ndCByZWFsbHkgc2VlIHdoeSB0aGlz
IGNhbid0IHN0YXkgaW4gdGhlIGRwbGwgbWdyLgo+PiA+Pgo+PiA+PiBBZ3JlZWQsIEkgdGhpbmsg
aXQgc2hvdWxkIHN0YXkgaW4gRFBMTCBtYW5hZ2VyLgo+PiA+Pgo+PiA+PiBUaGUgdGhpbmcgaXMs
IERQTEwgZW5hYmxpbmcgZm9yIERTSSByZXF1aXJlcyBlbmNvZGVyIHNwZWNpZmljIHN0ZXBzCj4+
ID4+IGluIHRoZSBtaWRkbGUgb2YgdGhlIHNlcXVlbmNlIGhpZGRlbiBpbiBEUExMIG1hbmFnZXIu
IEl0J3Mgbm90IHByZXR0eQo+PiA+PiB0byBhZGQgdGhhdCBpbiBEUExMIG1hbmFnZXIuCj4+ID4+
Cj4+ID4+IE9uZSBhcHByb2FjaCBtaWdodCBiZSB0byBhZGQgZW5jb2RlciBob29rcyB0byBjYWxs
IGZyb20gdGhlIHJpZ2h0Cj4+ID4+IHNwb3QgaW4gdGhlIERQTEwgbWFuYWdlciwgIm1pZF9wbGxf
ZW5hYmxlIi4gSXQncyBhbm5veWluZyBiZWNhdXNlIGl0Cj4+ID4+IHdvdWxkIGhhdmUgdG8gaGFw
cGVuIGluIHRoZSBtaWRkbGUgb2YgdGhlIHBsYXRmb3JtIHNwZWNpZmljIERQTEwKPj4gPj4gbWFu
YWdlcgo+PiA+PiBwbGwtPmluZm8tPmZ1bmNzLT5lbmFibGUgaG9vay4gV2UnZCBoYXZlIHRvIGNh
bGwgdGhlIGhvb2tzIGZyb20KPj4gPj4gcGxsLT5pbmZvLT5mdW5jcy0+cGxhdGZvcm0KPj4gPj4g
c3BlY2lmaWMgY29kZSwgb3Igc3BsaXQgdGhvc2UgaG9va3MgaW4gdHdvLiBUaGUgZm9ybWVyIGlz
IHVnbHkKPj4gPj4gYmVjYXVzZSBpdCByZXF1aXJlcyBwYXNzaW5nIGNydGMgdG8gdGhlIHBsbCBl
bmFibGUgaG9vay4gU28gSSBndWVzcwo+PiA+PiBhZGQgYSBwbGwgcG9zdCBlbmFibGUgaG9vay4K
Pj4gPj4KPj4gPj4gQmVsb3cncyBzb21lIGRyYWZ0IGNvZGUgdG8gZ2l2ZSBhbiBpZGVhIHdoYXQg
SSBtZWFuLiBZb3UnZCBtb3ZlIHRoZQo+PiA+PiBhYm92ZSBodW5rIHRvIHRoZSBwb3N0IGhvb2sg
aW5zdGVhZC4KPj4gPj4KPj4gPj4gU28gdGhlbiB3ZSdkIGFkZCBtaWRfcGxsX2VuYWJsZSBob29r
cyBhbmQgZG8gdGhlIHJlcXVpcmVkIG1hZ2ljIGluCj4+ID4+IHRoZSBEU0kgbWlkIHBsbCBob29r
Lgo+Cj4gVGhhbmtzIEphbmksIGxldCBtZSB0cnkgdGhpcyBvdXQuCgpMaWtlIEkgc2FpZCwgSSB0
aGluayBWaWxsZSBwcmVmZXJyZWQgcHVzaGluZyB0aGUgcGxsIGVuYWJsZSBjYWxscyBkb3duCnRv
IGVuY29kZXJzIG9uIERESSBwbGF0Zm9ybXMuIEluIHRoaXMgY2FzZSwgd2UnZCBiZSBhYmxlIHRv
IGJldHRlcgpjb250cm9sIHdoZW4gYW5kIHdoZXJlIHRoZSBwbGwgZW5hYmxlIGhhcHBlbnMsIGFu
ZCBwb3RlbnRpYWxseSBzcGxpdCB0aGUKY2FsbHMgb3IgYWRkIGVuY29kZXIgc3BlY2lmaWMgcGFy
dHMgaW50byB0aGUgZHBsbCBtYW5hZ2VyLiAoVGhlcmUKYWxyZWFkeSBleGlzdHMgc29tZS4pCgpC
UiwKSmFuaS4KCgo+Cj4gUmVnYXJkcywKPiBWYW5kaXRhCj4+ID4KPj4gPiBQUy4gQW5kIGV2ZW4g
d2l0aCB0aGlzIEknbSBub3QgeWV0IHN1cmUgaWYgd2UgY2FuIGRvIHRoZSBvdmVyYWxsIERQTEwK
Pj4gPiBlbmFibGluZyBhdCB0aGUgcmlnaHQgc3BvdCB3cnQgYnNwZWMgRFNJIG1vZGUgc2V0IHNl
cXVlbmNlLiAqY3JpbmdlKi4KPj4gCj4+IFZpbGxlIHJlbWluZGVkIG1lIHRoYXQgd2UgZGlkIGhh
dmUgdGhpcyBpZGVhIG9mIHB1c2hpbmcgcGxsIGVuYWJsZSBjYWxscyBkb3duIHRvCj4+IGVuY29k
ZXJzIG9uIERESSBwbGF0Zm9ybXMuIFRoaXMgd291bGQgaGVscCwgb2YgY291cnNlLgo+PiAKPj4g
QlIsCj4+IEphbmkuCj4+IAo+PiAKPj4gPgo+PiA+IEJSLAo+PiA+IEphbmkuCj4+ID4KPj4gPj4K
Pj4gPj4gT3ZlcmFsbCBJJ20gc3RhcnRpbmcgdG8gZmVlbCB0aGUgYXBwZWFsIG9mIGRyaXZpbmcg
bW9kZXNldCBmcm9tCj4+ID4+IGVuY29kZXJzLCB3aXRoIGxpYnJhcnkgc3R5bGUgaGVscGVycyBw
cm92aWRlZCBmcm9tIGludGVsX2Rpc3BsYXkuYywKPj4gPj4gaW5zdGVhZCBvZiBhZGRpbmcgbW9y
ZSBhbmQgbW9yZSBlbmNvZGVyIGhvb2tzIHRvIGRvIHN0dWZmIGF0IHNwZWNpZmljCj4+ID4+IHBs
YWNlcy4gQnV0IEkgZGlncmVzcy4KPj4gPj4KPj4gPj4gQlIsCj4+ID4+IEphbmkuCj4+ID4+Cj4+
ID4+Cj4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21n
ci5jCj4+ID4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+PiA+PiBp
bmRleCBlNmNhYzkyMjU1MzYuLmE0Y2ExYjRhMTI0YyAxMDA2NDQKPj4gPj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+PiA+PiArKysgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4+ID4+IEBAIC0xOTEsNiArMTkxLDEyIEBAIHZvaWQg
aW50ZWxfZW5hYmxlX3NoYXJlZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjCj4+ID4+ICpjcnRjKQo+
PiA+Pgo+PiA+PiAgCURSTV9ERUJVR19LTVMoImVuYWJsaW5nICVzXG4iLCBwbGwtPmluZm8tPm5h
bWUpOwo+PiA+PiAgCXBsbC0+aW5mby0+ZnVuY3MtPmVuYWJsZShkZXZfcHJpdiwgcGxsKTsKPj4g
Pj4gKwo+PiA+PiArCWludGVsX2VuY29kZXJzX21pZF9wbGxfZW5hYmxlKGNydGMpOyAvKiBwaXBl
X2NvbmZpZywgb2xkX3N0YXRlPyAqLwo+PiA+PiArCj4+ID4+ICsJaWYgKHBsbC0+aW5mby0+ZnVu
Y3MtPnBvc3RfZW5hYmxlKQo+PiA+PiArCQlwbGwtPmluZm8tPmZ1bmNzLT5wb3N0X2VuYWJsZShk
ZXZfcHJpdiwgcGxsKTsKPj4gPj4gKwo+PiA+PiAgCXBsbC0+b24gPSB0cnVlOwo+PiA+Pgo+PiA+
PiAgb3V0Ogo+PiA+PiBAQCAtMzE5OSw2ICszMjA1LDcgQEAgc3RhdGljIHZvaWQgaWNsX2R1bXBf
aHdfc3RhdGUoc3RydWN0Cj4+ID4+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiA+Pgo+
PiA+PiAgc3RhdGljIGNvbnN0IHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbF9mdW5jcyBpY2xfcGxs
X2Z1bmNzID0gewo+PiA+PiAgCS5lbmFibGUgPSBpY2xfcGxsX2VuYWJsZSwKPj4gPj4gKwkucG9z
dF9lbmFibGUgPSBpY2xfcGxsX3Bvc3RfZW5hYmxlLAo+PiA+PiAgCS5kaXNhYmxlID0gaWNsX3Bs
bF9kaXNhYmxlLAo+PiA+PiAgCS5nZXRfaHdfc3RhdGUgPSBpY2xfcGxsX2dldF9od19zdGF0ZSwg
IH07IGRpZmYgLS1naXQKPj4gPj4gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21n
ci5oCj4+ID4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+PiA+PiBp
bmRleCBiZjBkZThhNGRjNjMuLmVjZWVlZjNiODg3MiAxMDA2NDQKPj4gPj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+PiA+PiArKysgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kcGxsX21nci5oCj4+ID4+IEBAIC0yMzEsNiArMjMxLDE2IEBAIHN0cnVj
dCBpbnRlbF9zaGFyZWRfZHBsbF9mdW5jcyB7Cj4+ID4+ICAJCSAgICAgICBzdHJ1Y3QgaW50ZWxf
c2hhcmVkX2RwbGwgKnBsbCk7Cj4+ID4+Cj4+ID4+ICAJLyoqCj4+ID4+ICsJICogQHBvc3RfZW5h
YmxlOgo+PiA+PiArCSAqCj4+ID4+ICsJICogT3B0aW9uYWwgaG9vayB0byBjYWxsIGFmdGVyIGVu
Y29kZXIgc3BlY2lmaWMgbWlkIHBsbCBob29rcyBoYXZlIGJlZW4KPj4gPj4gKwkgKiBjYWxsZWQg
ZnJvbSBpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwoKS4KPj4gPj4gKwkgKi8KPj4gPj4gKwl2b2lk
ICgqcG9zdF9lbmFibGUpKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gPj4g
KwkJCSAgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCk7Cj4+ID4+ICsKPj4gPj4gKwo+
PiA+PiArCS8qKgo+PiA+PiAgCSAqIEBkaXNhYmxlOgo+PiA+PiAgCSAqCj4+ID4+ICAJICogSG9v
ayBmb3IgZGlzYWJsaW5nIHRoZSBwbGwsIGNhbGxlZCBmcm9tCj4+ID4+IGludGVsX2Rpc2FibGVf
c2hhcmVkX2RwbGwoKQo+PiAKPj4gLS0KPj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNl
IEdyYXBoaWNzIENlbnRlcgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFw
aGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
Cg==