From: Kalle Valo <kvalo@codeaurora.org>
To: zhong jiang <zhongjiang@huawei.com>
Cc: <davem@davemloft.net>, <hante.meuleman@broadcom.com>,
<franky.lin@broadcom.com>, <arend.vanspriel@broadcom.com>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
Date: Thu, 20 Sep 2018 15:30:42 +0300 [thread overview]
Message-ID: <877ejg1hcd.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <5BA391D4.20205@huawei.com> (zhong jiang's message of "Thu, 20 Sep 2018 20:25:56 +0800")
zhong jiang <zhongjiang@huawei.com> writes:
> On 2018/9/20 20:07, Kalle Valo wrote:
>> zhong jiang <zhongjiang@huawei.com> wrote:
>>
>>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
>>> remove the condition check before debugfs_remove_recursive.
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> It seems you already submitted an identical patch four days earlier:
>>
>> https://patchwork.kernel.org/patch/10593061/
>>
>> Why the duplicate? Please ALWAYS add a changelog and increase the version number:
>
> I am sorry for that. Maybe I send the patch earlier, but I remeber I
> should forget to cc to
> netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch.
Even then please increase the version number and mention in the change
log why you sent a new version. Otherwise you will make maintainers
confused and wasting time with asking what has changed.
--
Kalle Valo
next prev parent reply other threads:[~2018-09-20 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 14:10 [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive zhong jiang
2018-09-12 14:10 ` zhong jiang
2018-09-20 12:07 ` Kalle Valo
[not found] ` <20180920120709.5FE6960BF7@smtp.codeaurora.org>
2018-09-20 12:25 ` zhong jiang
2018-09-20 12:30 ` Kalle Valo [this message]
2018-09-20 12:37 ` zhong jiang
-- strict thread matches above, loose matches on Subject: below --
2018-09-08 13:40 zhong jiang
2018-09-20 12:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ejg1hcd.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.