Re: [PATCH 07/15] iwlwifi: add 80211 hdr offset to trace data

[Kalle Valo <kvalo@codeaurora.org>]

Luca Coelho <luca@coelho.fi> writes:

> From: Mordechay Goodstein <mordechay.goodstein@intel.com>
>
> Every rx mpdu cmd is built from cmd_hdr | 80211_hdr.  The problem is
> that the size of cmd_hdr changes with API changes and we don't know
> where the 80211_hdr starts.
>
> By adding the size of cmd_hdr dynamically, we can ensure that we always
> know how to parse mpdu frames, without dependending on the API changes.
>
> Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

[...]

> --- a/drivers/net/wireless/intel/iwlwifi/iwl-devtrace-data.h
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-devtrace-data.h
> @@ -2,6 +2,7 @@
>   *
>   * Copyright(c) 2009 - 2014 Intel Corporation. All rights reserved.
>   * Copyright(c) 2015        Intel Deutschland GmbH
> + * Copyright(c) 2018        Intel Corporation
>   *
>   * This program is free software; you can redistribute it and/or modify it
>   * under the terms of version 2 of the GNU General Public License as
> @@ -12,10 +13,6 @@
>   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
>   * more details.
>   *
> - * You should have received a copy of the GNU General Public License along with
> - * this program; if not, write to the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
> - *
>   * The full GNU General Public License is included in this distribution in the
>   * file called LICENSE.
>   *

Ok, you have more of these removals in this patch so I guess it's
intentional. But IMHO it would be nicer to remove these all in one go
instead of sprinkle around in different patches.

-- 
Kalle Valo