All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-3.0 2/4] migration: disallow recovery for release-ram
Date: Tue, 24 Jul 2018 11:21:47 +0200	[thread overview]
Message-ID: <877ellgf9w.fsf@secure.mitica> (raw)
In-Reply-To: <20180723123305.24792-3-peterx@redhat.com> (Peter Xu's message of "Mon, 23 Jul 2018 20:33:03 +0800")

Peter Xu <peterx@redhat.com> wrote:
> Postcopy recovery won't work well with release-ram capability since
> release-ram will drop the page buffer as long as the page is put into
> the send buffer.  So if there is a network failure happened, any page
> buffers that have not yet reached the destination VM but have already
> been sent from the source VM will be lost forever.  Let's refuse the
> client from resuming such a postcopy migration.  Luckily release-ram was
> designed to only be used when src and destination VMs are on the same
> host, so it should be fine.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

I wonder if we should have a FAQ somewhere and point an URL to there.

  reply	other threads:[~2018-07-24  9:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 12:33 [Qemu-devel] [PATCH for-3.0 0/4] migration: some fixes for release-ram Peter Xu
2018-07-23 12:33 ` [Qemu-devel] [PATCH for-3.0 1/4] migration: update recv bitmap only on dest vm Peter Xu
2018-07-24  9:20   ` Juan Quintela
2018-07-23 12:33 ` [Qemu-devel] [PATCH for-3.0 2/4] migration: disallow recovery for release-ram Peter Xu
2018-07-24  9:21   ` Juan Quintela [this message]
2018-07-24 11:39     ` Peter Xu
2018-07-23 12:33 ` [Qemu-devel] [PATCH for-3.0 3/4] tests: only update last_byte when at the edge Peter Xu
2018-07-24  9:23   ` Juan Quintela
2018-07-23 12:33 ` [Qemu-devel] [PATCH for-3.0 4/4] tests: torture release-ram in postcopy test Peter Xu
2018-07-24  9:25   ` Juan Quintela
2018-07-24 11:36     ` Peter Xu
2018-07-24 11:42       ` Dr. David Alan Gilbert
2018-07-24 11:52         ` Peter Xu
2018-07-24 16:22 ` [Qemu-devel] [PATCH for-3.0 0/4] migration: some fixes for release-ram Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ellgf9w.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.