From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v2] drm/i915: Promote .format_mod_supported() to the lead role Date: Mon, 21 May 2018 12:21:01 -0700 Message-ID: <877enwu86a.fsf@anholt.net> References: <20180319165017.31908-1-ville.syrjala@linux.intel.com> <20180518162159.30305-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1153174570==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id CE5FE6E500 for ; Mon, 21 May 2018 19:21:04 +0000 (UTC) In-Reply-To: <20180518162159.30305-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1153174570== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ville Syrjala writes: > From: Ville Syrj=C3=A4l=C3=A4 > > Up to now we've used the plane's modifier list as the primary > source of information for which modifiers are supported by a > given plane. In order to allow auxiliary metadata to be embedded > within the bits of the modifier we need to stop doing that. > > Thus we have to make .format_mod_supported() aware of the plane's > capabilities and gracefully deal with any modifier being passed > in directly from userspace. This seems like it would be a lot shorter if you just had a helper to check if your format and modifier was in drm_plane->format_types and drm_plane->modifiers, since then you wouldn't be duplicating your tables and you wouldn't need has_ccs either. However, it's not my driver and it unblocks vc4's patch, so: Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlsDHB4ACgkQtdYpNtH8 nuiMQg/8DonNcA0/8OV7SXaaAzL6ZJsYT6s1DEtZ9MWTJqb0XeDY6vN62bBvfL9R LzNO50lbZVeUZED/VtsXd9iQ93jBfRbZLuECj9IxhzRsPJMnjmJnFwHOCykxUH9U smUUQOTYiF7X3ah4ymloGaUENVciuDhgSrW9RytPVfx2Q8EpnEtGVY5dnX8Vd1hZ dvJih4Lt6HF1sdy0PznvnRc/+gtaJHXJtSDaFBcxXHT9adCJzYu51WTvXJX4c9lG i+L2ayv5q6sfJDpeGmste+zrNbU3J2+Moif5EjRoCbxZxmIJfvAcfyZj1SuK3c2u fEJKTq3el2MDHY4J1332QYXkUWNmGziHLXUPWW/qz8KO2mMuEpV44V7exg5Q0iGo rY76IKVNl/kHd7E3IHQ+uTylvzx/w15aVDIl5psLSjqKjMM0SNose96Dgj1BvaH7 JNvbGe1BwhyZXQJuYfhwsUHJVgkuAd/89UCKilxGTwxxtLXqVTboqHyh58EBmqxN d2Ylw6eMqGX3F+2hA/bD76YnnbuJiuvhIfufQdJRgutxesq78EFQ46kXT3TkTNsJ lAGjHWsZbXNOrP/Lr+Wtw+zi36g1jj3iZGdmevKRKaXuXP9bJJNwn3sHg1TZgh92 I1MpR3SiVHdEApOkyXWjciLUozi6m3GeBIwco8Ibhyqu2kyWPRM= =YHL8 -----END PGP SIGNATURE----- --=-=-=-- --===============1153174570== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1153174570==--