From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net
Subject: Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter
Date: Thu, 17 May 2018 15:11:31 +0200 [thread overview]
Message-ID: <877eo2xw8s.fsf@toke.dk> (raw)
In-Reply-To: <541d62af-3938-5fdc-666c-dd243fa465b5@gmail.com>
Eric Dumazet <eric.dumazet@gmail.com> writes:
> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote:
>
>>
>> We don't do full parsing of SACKs, no; we were trying to keep things
>> simple... We do detect the presence of SACK options, though, and the
>> presence of SACK options on an ACK will make previous ACKs be considered
>> redundant.
>>
>
> But they are not redundant in some cases, particularly when reorders
> happen in the network.
Huh. I was under the impression that SACKs were basically cumulative
until cleared.
I.e., in packet sequence ABCDE where B and D are lost, C would have
SACK(B) and E would have SACK(B,D). Are you saying that E would only
have SACK(D)?
-Toke
next prev parent reply other threads:[~2018-05-17 13:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 20:29 [PATCH net-next v12 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-16 20:29 ` [PATCH net-next v12 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-16 21:09 ` Cong Wang
2018-05-16 21:16 ` Toke Høiland-Jørgensen
2018-05-16 20:29 ` [PATCH net-next v12 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-16 20:29 ` [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-17 11:04 ` Eric Dumazet
2018-05-17 11:23 ` Toke Høiland-Jørgensen
2018-05-17 11:56 ` Eric Dumazet
2018-05-17 13:11 ` Toke Høiland-Jørgensen [this message]
2018-05-18 2:36 ` [Cake] " Ryan Mounce
2018-05-18 4:08 ` Eric Dumazet
2018-05-18 7:43 ` Ryan Mounce
2018-05-18 4:27 ` Cong Wang
2018-05-18 11:18 ` [Cake] " Kevin Darbyshire-Bryant
2018-05-18 11:23 ` Sebastian Moeller
2018-05-18 15:20 ` Eric Dumazet
2018-05-16 20:29 ` [PATCH net-next v12 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-16 20:44 ` Cong Wang
2018-05-16 21:13 ` Toke Høiland-Jørgensen
2018-05-16 20:29 ` [PATCH net-next v12 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
2018-05-16 20:56 ` Cong Wang
2018-05-16 21:14 ` Toke Høiland-Jørgensen
2018-05-16 20:29 ` [PATCH net-next v12 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-16 20:29 ` [PATCH net-next v12 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eo2xw8s.fsf@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.