All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Daniel Mack <daniel@zonque.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
	wcn36xx@lists.infradead.org, Ramon Fried <rfried@codeaurora.org>,
	linux-wireless@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys
Date: Thu, 12 Apr 2018 15:14:38 +0300	[thread overview]
Message-ID: <877epcr58x.fsf@codeaurora.org> (raw)
In-Reply-To: <62942f8b-3e02-868f-6cb1-7423cd44b828@zonque.org> (Daniel Mack's message of "Thu, 12 Apr 2018 14:04:22 +0200")

Daniel Mack <daniel@zonque.org> writes:

> On Thursday, April 12, 2018 01:46 PM, Loic Poulain wrote:
>> Hi Daniel,
>> 
>>> @@ -564,10 +565,13 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
>>>                 break;
>>>         case DISABLE_KEY:
>>>                 if (!(IEEE80211_KEY_FLAG_PAIRWISE & key_conf->flags)) {
>>> +                       if (vif_priv->bss_index != WCN36XX_HAL_BSS_INVALID_IDX)
>>> +                               wcn36xx_smd_remove_bsskey(wcn,
>>> +                                       vif_priv->encrypt_type,
>>> +                                       vif_priv->bss_index,
>>> +                                       key_conf->keyidx);
>>> +
>>>                         vif_priv->encrypt_type = WCN36XX_HAL_ED_NONE;
>>> -                       wcn36xx_smd_remove_bsskey(wcn,
>>> -                               vif_priv->encrypt_type,
>>> -                               key_conf->keyidx);
>> 
>> Note that moving vif_priv->encrypt_type = WCN36XX_HAL_ED_NONE after
>> key removal also fixes an issue I observed in AP mode:
>> wcn36xx: ERROR hal_remove_bsskey response failed err=6
>
> Yeah, sorry. I did that intentionally, but missed to mention it in the
> commit log.

I can add that to the commit log, just tell me what to add.

-- 
Kalle Valo

  reply	other threads:[~2018-04-12 12:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 11:13 [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys Daniel Mack
2018-04-12 11:46 ` Loic Poulain
2018-04-12 12:04   ` Daniel Mack
2018-04-12 12:14     ` Kalle Valo [this message]
2018-04-12 12:16       ` Daniel Mack
2018-04-12 12:38         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877epcr58x.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel@zonque.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=rfried@codeaurora.org \
    --cc=wcn36xx@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.