From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 2/3] drm/vc4: Check if plane requires background fill Date: Tue, 06 Mar 2018 16:10:33 -0800 Message-ID: <877eqoiw3q.fsf@anholt.net> References: <1520300919-103427-1-git-send-email-stschake@gmail.com> <1520300919-103427-3-git-send-email-stschake@gmail.com> <20180306194316.GJ5453@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1164467595==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 753D36E3BD for ; Wed, 7 Mar 2018 00:10:36 +0000 (UTC) In-Reply-To: <20180306194316.GJ5453@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?utf-8?B?U3lyasOkbMOk?= , Stefan Schake Cc: airlied@linux.ie, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1164467595== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ville Syrj=C3=A4l=C3=A4 writes: > On Tue, Mar 06, 2018 at 02:48:38AM +0100, Stefan Schake wrote: >> Considering a single plane only, we have to enable background color >> when the plane has an alpha format and could be blending from the >> background or when it doesn't cover the entire screen. >>=20 >> Signed-off-by: Stefan Schake >> --- >> drivers/gpu/drm/vc4/vc4_drv.h | 6 ++++++ >> drivers/gpu/drm/vc4/vc4_plane.c | 15 ++++++++++++++- >> 2 files changed, 20 insertions(+), 1 deletion(-) >>=20 >> diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv= .h >> index fefa166..7cc6390 100644 >> --- a/drivers/gpu/drm/vc4/vc4_drv.h >> +++ b/drivers/gpu/drm/vc4/vc4_drv.h >> @@ -302,6 +302,12 @@ struct vc4_hvs { >>=20=20 >> struct vc4_plane { >> struct drm_plane base; >> + >> + /* Set when the plane has per-pixel alpha content or does not cover >> + * the entire screen. This is a hint to the CRTC that it might need >> + * to enable background color fill. >> + */ >> + bool needs_bg_fill; > > Looks to me like that should really be a bitmask (or something similar) > in the crtc state. Why? In particular, VC4 really doesn't have a fixed number of planes, and the fact that we're exposing just a handful so far is probably a bug. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlqfLfkACgkQtdYpNtH8 nui1KRAAhIf42LQ1JRd31NHkS9znQC/F8Zec1W/EeHMa+tdFIR/XZDWCiKFYLL2O n8bM01eFrWMrQdzXQdEpC6oU75lvgHCNfGu8J6bOIHmm34C0LGfuwpRp8vGz2K5o bwfkyn/W/NpZVnWxoYaPGo7+LXEYtdWQ43qPjstroeVEmVXgVywk/5Tb6SrVPJas Y0Ep47BK8qx3FpuEmlMiftYwxr75TcAuaXexvTpCbwHn29kzMKO1zQDa4ibZbY0n yrsjqCRzPGMIiATtmC8NVHfm13czjgqEJYRltZ8wPB/hm7ts6CrgTenIqaA3dJMB ptQ9EY0AoafPO0Ke7XySbCs+raGp59st3k+1sfezD/OicyaPU8QlPa6X8k5393xH eJLE1/lQZ5eG9pztS9pb22WUfYd/SjMrNzcEohPpBIfVeAT4le4g3OPygCuI7PRO yTsTUirmSCeYnlgmTAmeStlN8CbQp8KBaGl0dyZwYNSo+RnXfQ8dDzsyOvTsGB5+ cB3Ie68+oMIi94GoDRfkxlnP5iBlimy8kVisksgWElxto7+GF55XO8OmZv3mRcYk o+nFE5e/GQFtAK7RdrKMrfO7FE49fPmyZPMxcwJIroUs2o3I/CFHn6nVOVZdsmZb EPjvU/JuZX674olquc45UgvwLHr/w4DLMu86/j7g8plllSYMqGk= =YBW4 -----END PGP SIGNATURE----- --=-=-=-- --===============1164467595== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1164467595==--