From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV Date: Fri, 17 Nov 2017 15:01:08 +0200 Message-ID: <877eup5aaz.fsf@intel.com> References: <20171115024521.5884-1-alexander.levin@verizon.com> <20171115024521.5884-36-alexander.levin@verizon.com> <20171115110805.GX10981@intel.com> <20171115164451.ogl3ku6qr3cfnbk7@sasha-lappy> <20171115170320.GK10981@intel.com> <87bmk15em2.fsf@intel.com> <20171117124123.GB24300@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171117124123.GB24300@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg KH Cc: intel-gfx@lists.freedesktop.org, "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , alexander.levin@verizon.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxNyBOb3YgMjAxNywgR3JlZyBLSCA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+ IHdyb3RlOgo+IE9uIEZyaSwgTm92IDE3LCAyMDE3IGF0IDAxOjI4OjA1UE0gKzAyMDAsIEphbmkg TmlrdWxhIHdyb3RlOgo+PiAKPj4gQ2M6IEdyZWcKPj4gCj4+IE9uIFdlZCwgMTUgTm92IDIwMTcs IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ PiA+IE9uIFdlZCwgTm92IDE1LCAyMDE3IGF0IDA0OjQ0OjU0UE0gKzAwMDAsIGFsZXhhbmRlci5s ZXZpbkB2ZXJpem9uLmNvbSB3cm90ZToKPj4gPj4gT24gV2VkLCBOb3YgMTUsIDIwMTcgYXQgMDE6 MDg6MDVQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+PiA+PiA+T24gV2VkLCBOb3Yg MTUsIDIwMTcgYXQgMDI6NDU6NDNBTSArMDAwMCwgYWxleGFuZGVyLmxldmluQHZlcml6b24uY29t IHdyb3RlOgo+PiA+PiA+PiBGcm9tOiBWaWxsZSBTeXJqw4PCpGzDg8KkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPj4gPj4gPj4KPj4gPj4gPj4gWyBVcHN0cmVhbSBjb21taXQgMWJl NGQzNzkzZDVhOTNkYWRkY2Q5YmU2NTdjNDI5YjM4YWQ3NTBhMyBdCj4+ID4+ID4+Cj4+ID4+ID4+ IFRoZSB3YXRlcm1hcmsgc2hvdWxkIG5ldmVyIGV4Y2VlZCB0aGUgRklGTyBzaXplLCBzbyB3ZSBu ZWVkIHRvCj4+ID4+ID4+IGNoZWNrIGFnYWluc3QgdGhlIGN1cnJlbnQgRklGTyBzaXplIGluc3Rl YWQgb2YgdGhlIHRoZW9yZXRpY2FsCj4+ID4+ID4+IG1heGltdW0gd2hlbiB3ZSBjbGFtcCB0aGUg bGV2ZWwgMCB3YXRlcm1hcmsuCj4+ID4+ID4+Cj4+ID4+ID4+IFNpZ25lZC1vZmYtYnk6IFZpbGxl IFN5cmrDg8KkbMODwqQgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+PiA+PiA+PiBM aW5rOiBodHRwczovL3VybGRlZmVuc2UucHJvb2Zwb2ludC5jb20vdjIvdXJsP3U9aHR0cC0zQV9f cGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZ19wYXRjaF9tc2dpZF8xNDgwMzU0NjM3LTJEMTQyMDkt MkQ0LTJEZ2l0LTJEc2VuZC0yRGVtYWlsLTJEdmlsbGUuc3lyamFsYS00MGxpbnV4LmludGVsLmNv bSZkPUR3SURBdyZjPXVkQlRSdkZ2WEM1RGhxZzdVSHBKbFBwczNtWjNMUnhwYjZfXzBQb21CVFEm cj1iVXRhYUM5bWxCaWo0T2pFR19ELUtQdWxfMzM1YXpZemZDNFJqZ29tb2JvJm09aXVQdFVhci1W RUdiSDFqbVZIX1VUcjRDMDJYOGZtakhVZk5ZaXgtWWMwWSZzPWhhX0YwelAzQTFBenRwNVM1ZTZf YnFkaGl1dVBYaG4wZFJXUTU4dnYzSXMmZT0KPj4gPj4gPj4gUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+ID4+ID4+IFNp Z25lZC1vZmYtYnk6IFNhc2hhIExldmluIDxhbGV4YW5kZXIubGV2aW5AdmVyaXpvbi5jb20+Cj4+ ID4+ID4KPj4gPj4gPldoeSBhcmUgdGhlc2UgcGF0Y2hlcyBiZWluZyBwcm9wb3NlZCBmb3Igc3Rh YmxlPyBUaGV5J3JlIG5vdCBzdHJhaWdodCB1cAo+PiA+PiA+Zml4ZXMgZm9yIGtub3duIGlzc3Vl cywgYW5kIHRoZXJlJ3MgYWx3YXlzIGEgY2hhbmNlIHRoYXQgc29tZXRoaW5nIHdpbGwKPj4gPj4g PmJyZWFrLiBXaG8gaXMgZG9pbmcgdGhlIHFhIG9uIHRoaXM/Cj4+ID4+IAo+PiA+PiBIaSBWaWxs ZSwKPj4gPj4gCj4+ID4+IFRoZXkgd2VyZSBzZWxlY3RlZCBhdXRvbWF0aWNhbGx5IGFzIHBhcnQg b2YgYSBuZXcgcHJvY2VzcyB3ZSdyZSB0cnlpbmcKPj4gPj4gb3V0LiBJZiB5b3UgZGlzYWdyZWUg d2l0aCB0aGUgc2VsZWN0aW9uIEknZCBiZSBoYXBweSB0byBkcm9wIGl0Lgo+PiA+Cj4+ID4gSG93 IGRvZXMgdGhhdCBhdXRvbWF0aWMgcHJvY2VzcyBkZWNpZGUgdGhhdCBhIHBhdGNoIHNob3VsZCBi ZSBiYWNrcG9ydGVkPwo+PiA+Cj4+ID4gZHJtIGFuZCBpOTE1IGFyZSB2ZXJ5IGZhc3QgbW92aW5n IHRhcmdldHMgc28gdW5pbnRlbmRlZCBzaWRlIGVmZmVjdHMgZnJvbQo+PiA+IGJhY2twb3J0ZWQg cGF0Y2hlcyBpcyBhIHJlYWwgcG9zc2liaWxpdHkuIFNvIEkgd291bGQgcmVjb21tZW5kIGFnYWlu c3QKPj4gPiBiYWNrcG9ydGluZyBhbnl0aGluZyB0aGF0IGlzbid0IGZpeGluZyBhIHJlYWwgaXNz dWUgYWZmZWN0aW5nIHVzZXJzLiBXZQo+PiA+IGRvIHRyeSB0byBhZGQgdGhlIGNjOnN0YWJsZSB0 byBzdWNoIHBhdGNoZXMuCj4+IAo+PiBBZ3JlZWQuCj4+IAo+PiBGaXJzdCwgSSB0aGluayBhbiBh dXRvbWF0aWMgYmFja3BvcnQgcHJvY2VzcyBpcyBhZ2FpbnN0IHRoZSBzdGFibGUKPj4ga2VybmVs IHJ1bGVzIChlLmcuICJJdCBtdXN0IGZpeCBhIHJlYWwgYnVnIHRoYXQgYm90aGVycyBwZW9wbGUi KS4KPgo+IEl0J3MgZmluZGluZyBsb3RzIG9mIGZpeGVzIHRoYXQgZGlkIGJvdGhlciBwZW9wbGUg ZW5vdWdoIHRvIHN1Ym1pdCBhIGZpeAo+IGZvci4KCkkgc3RpbGwgaGF2ZSBubyBpZGVhIGhvdyB0 aGlzIGF1dG9zZWxlY3QgcGlja3MgdXAgcGF0Y2hlcyB0aGF0IGRvICpub3QqCmhhdmUgY2M6IHN0 YWJsZSBub3IgRml4ZXM6IGZyb20gdXMuIFdoYXQgaW5mb3JtYXRpb24gZG8geW91IGhhdmUgdGhh dCB3ZQpkb24ndCBmb3IgbWFraW5nIHRoYXQgY2FsbD8KCkJSLApKYW5pLgoKPj4gU2Vjb25kLCB3 ZSBjYW4ndCBhbmQgd29uJ3QgdGFrZSBhbnkgcmVzcG9uc2liaWxpdHkgZm9yIGJhY2twb3J0cyB3 ZQo+PiBkaWRuJ3QgaW5kaWNhdGUgd2l0aCBDYzogc3RhYmxlLCBhIEZpeGVzOiB0YWcsIG9yIGEg c3BlY2lmaWMgYmFja3BvcnQKPj4gcmVxdWVzdC4KPgo+IE9rLCB5b3UgYWxsIGFyZSBhbHJlYWR5 IHRvdGFsbHkgbWVzc2luZyB3aXRoIG15IG5vcm1hbCBzdGFibGUgd29ya2Zsb3csCj4gc28gbWln aHQgYXMgd2VsbCBqdXN0IHRydXN0IHlvdSBhbGwgY29tcGxldGVseS4gIFNvIGxldCdzIGp1c3Qg b25seSB0YWtlCj4gcGF0Y2hlcyB0aGF0IHlvdSBhbGwgZG8gc2VuZCBtZSBpbiB0aGUgbm9ybWFs IHdheS4gIEl0J3MgZWFzeSBmb3IgU2FzaGEKPiB0byBmaWx0ZXIgb3V0IHRoZSBkcm0vaTkxNSBw YXRjaGVzIGZyb20gaGlzIHJlc3VsdHMuCj4KPiBJcyB0aGF0IG9rPwo+Cj4+IElmIHlvdSB0aGlu ayB0aGVyZSdzIGEgY29tbWl0IHRoYXQgc2hvdWxkIGJlIGJhY2twb3J0ZWQgYW5kIGlzIGtub3du IHRvCj4+IGZpeCBhIHVzZXIgdmlzaWJsZSBpc3N1ZSAoYXMgcGVyIHRoZSBzdGFibGUgcnVsZXMh KSwgcGxlYXNlIGNoZWNrIHdpdGgKPj4gdXMgZmlyc3QuCj4KPiBVbSwgdGhhdCBpcyB3aGF0IGhl IHdhcyBkb2luZyB3aXRoIHRoZSBjYzogb2YgeW91IGFsbCBvbiB0aGUgcGF0Y2gKPiBpdHNlbGYg dGhhdCBzdGFydGVkIHRoaXMgd2hvbGUgY29udmVyc2F0aW9uLi4uCj4KPiB7c2lnaH0KPgo+IGdy ZWcgay1oCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2Vu dGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934458AbdKQNAA convert rfc822-to-8bit (ORCPT ); Fri, 17 Nov 2017 08:00:00 -0500 Received: from mga05.intel.com ([192.55.52.43]:37019 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932731AbdKQM7s (ORCPT ); Fri, 17 Nov 2017 07:59:48 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,409,1505804400"; d="scan'208";a="3769770" From: Jani Nikula To: Greg KH Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , alexander.levin@verizon.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, "linux-kernel\@vger.kernel.org" , "stable\@vger.kernel.org" Subject: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV In-Reply-To: <20171117124123.GB24300@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20171115024521.5884-1-alexander.levin@verizon.com> <20171115024521.5884-36-alexander.levin@verizon.com> <20171115110805.GX10981@intel.com> <20171115164451.ogl3ku6qr3cfnbk7@sasha-lappy> <20171115170320.GK10981@intel.com> <87bmk15em2.fsf@intel.com> <20171117124123.GB24300@kroah.com> Date: Fri, 17 Nov 2017 15:01:08 +0200 Message-ID: <877eup5aaz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Nov 2017, Greg KH wrote: > On Fri, Nov 17, 2017 at 01:28:05PM +0200, Jani Nikula wrote: >> >> Cc: Greg >> >> On Wed, 15 Nov 2017, Ville Syrjälä wrote: >> > On Wed, Nov 15, 2017 at 04:44:54PM +0000, alexander.levin@verizon.com wrote: >> >> On Wed, Nov 15, 2017 at 01:08:05PM +0200, Ville Syrjälä wrote: >> >> >On Wed, Nov 15, 2017 at 02:45:43AM +0000, alexander.levin@verizon.com wrote: >> >> >> From: Ville Syrjälä >> >> >> >> >> >> [ Upstream commit 1be4d3793d5a93daddcd9be657c429b38ad750a3 ] >> >> >> >> >> >> The watermark should never exceed the FIFO size, so we need to >> >> >> check against the current FIFO size instead of the theoretical >> >> >> maximum when we clamp the level 0 watermark. >> >> >> >> >> >> Signed-off-by: Ville Syrjälä >> >> >> Link: https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.freedesktop.org_patch_msgid_1480354637-2D14209-2D4-2Dgit-2Dsend-2Demail-2Dville.syrjala-40linux.intel.com&d=DwIDAw&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=bUtaaC9mlBij4OjEG_D-KPul_335azYzfC4Rjgomobo&m=iuPtUar-VEGbH1jmVH_UTr4C02X8fmjHUfNYix-Yc0Y&s=ha_F0zP3A1Aztp5S5e6_bqdhiuuPXhn0dRWQ58vv3Is&e= >> >> >> Reviewed-by: Maarten Lankhorst >> >> >> Signed-off-by: Sasha Levin >> >> > >> >> >Why are these patches being proposed for stable? They're not straight up >> >> >fixes for known issues, and there's always a chance that something will >> >> >break. Who is doing the qa on this? >> >> >> >> Hi Ville, >> >> >> >> They were selected automatically as part of a new process we're trying >> >> out. If you disagree with the selection I'd be happy to drop it. >> > >> > How does that automatic process decide that a patch should be backported? >> > >> > drm and i915 are very fast moving targets so unintended side effects from >> > backported patches is a real possibility. So I would recommend against >> > backporting anything that isn't fixing a real issue affecting users. We >> > do try to add the cc:stable to such patches. >> >> Agreed. >> >> First, I think an automatic backport process is against the stable >> kernel rules (e.g. "It must fix a real bug that bothers people"). > > It's finding lots of fixes that did bother people enough to submit a fix > for. I still have no idea how this autoselect picks up patches that do *not* have cc: stable nor Fixes: from us. What information do you have that we don't for making that call? BR, Jani. >> Second, we can't and won't take any responsibility for backports we >> didn't indicate with Cc: stable, a Fixes: tag, or a specific backport >> request. > > Ok, you all are already totally messing with my normal stable workflow, > so might as well just trust you all completely. So let's just only take > patches that you all do send me in the normal way. It's easy for Sasha > to filter out the drm/i915 patches from his results. > > Is that ok? > >> If you think there's a commit that should be backported and is known to >> fix a user visible issue (as per the stable rules!), please check with >> us first. > > Um, that is what he was doing with the cc: of you all on the patch > itself that started this whole conversation... > > {sigh} > > greg k-h -- Jani Nikula, Intel Open Source Technology Center