From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Keith Packard" <keithp@keithp.com>
Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v4]
Date: Tue, 10 Oct 2017 09:56:53 -0700
Message-ID: <877ew30wmi.fsf@keithp.com>
References: <20171005061310.29919-1-keithp@keithp.com> <20171005061310.29919-7-keithp@keithp.com> <CAPM=9ty10SjSrkvxfcx41BzLMfizxT4pYwcv6F7RJcJU5kufdw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAPM=9ty10SjSrkvxfcx41BzLMfizxT4pYwcv6F7RJcJU5kufdw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Dave Airlie <airlied@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Dave Airlie <airlied@redhat.com>, Daniel Vetter <daniel@ffwll.ch>, dri-devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Dave Airlie <airlied@gmail.com> writes:

>> +                */
>> +               ret =3D idr_alloc(&leases, &drm_lease_idr_object , objec=
t_id, object_id + 1, GFP_KERNEL);
>
> In current kernels, the idr_alloc warns if start < 0, so if object_id
> is a negative signed integer, which your
> igt tests actually make it.
>
> So we get an ugly debug splat from the idr code, you should probably
> make sure object_id is
> something valid in signed space first, to avoid the splat.

Yeah, makes sense. I also found the vboxvideo driver in staging which
needed an API tweak.

I've pushed that as drm-lease-v5 and will plan on dumping that to the
list when you're done with -v4.

There are a couple of conflicts and another update needed when merging
leases and the new vblank ioctls together; once we've got one of the two
ready to go, I can rebase the other on top of that and fix things up.

=2D-=20
=2Dkeith

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlnc+9UACgkQ2yIaaQAA
ABFseg//boCgWYq6pdEFvtLKOoTIS9w6KnGnCnt+3sLE2l0J2AYuxmHKHwhcuIRi
TxDAf8z/JcXuRagxDYscP4hwS7ihed04/vbTjguP0gJ6oBNWtuCOk4x8UQ/nPcwd
yDFFCmDlSieVTJ3nza1D2TbTYIYis9ZRhDgMseAsgmHIntErzvM4R6mFx750aWH2
MR6Ky0flDVaHl6sp37CVlY39nXufUt6RAwEhUFPzfEOBKjkKeFHqe3sr7X+5G8t3
eqk3bKRIq9o9eQAMXAcjbbOYz9Rugz1ILZyxe6htUK9SLdJBYzjBbjlDtPnI5kN7
uQSsKAwfTsU/8SealdXvIUFS4XEpRqlbUTnm/1byBhDrqOmmDD4sVtLo0Z9xCt1q
c6YhBpCgQsVA1uOTXq32yBv50vQW/ZEnZQ/J1FKXwtPFN6WXWw+PfaF8UKwrE7qv
hfzfAMMc80SMhdJE/RMQZ9FnDAwCiDLDyqa8P6PSi2EmGYxsn3m3CktqyR3APZoH
jACFxqpaMMO/T0lnNraChXECJc2L0UjzMI45Hhedk8/JD9l7QLYMeuw22wwtyfRA
el0kXgB7NOltShEgNP6HScFd63BzEKwgqP9pfOfCfbsKqSNwKakfZBiElGvVv0dc
Uo8e+8b87BvTcw3UZrH36IknEXU9c0mIWlw547lCPgSsFPvnqU8=
=vBqj
-----END PGP SIGNATURE-----
--=-=-=--